* [PATCH] arm64: dts: mediatek: Add smi_common node for MT8183
@ 2020-10-01 16:28 Enric Balletbo i Serra
2020-10-02 9:17 ` Matthias Brugger
0 siblings, 1 reply; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-10-01 16:28 UTC (permalink / raw)
To: linux-kernel
Cc: Collabora Kernel ML, weiyi.lu, matthias.bgg, drinkcat, hsinyi,
fparent, Rob Herring, devicetree, linux-arm-kernel,
linux-mediatek
The SMI (Smart Multimedia Interface) Common is a bridge between the m4u
(Multimedia Memory Management Unit) and the Multimedia HW. This block is
needed to support different multimedia features, like display, video
decode, and camera. Also is needed to control the power domains of such
HW blocks.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index c2fd141afcf6..9082bc65e15e 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -916,6 +916,16 @@ mmsys: syscon@14000000 {
#clock-cells = <1>;
};
+ smi_common: smi@14019000 {
+ compatible = "mediatek,mt8183-smi-common", "syscon";
+ reg = <0 0x14019000 0 0x1000>;
+ clocks = <&mmsys CLK_MM_SMI_COMMON>,
+ <&mmsys CLK_MM_SMI_COMMON>,
+ <&mmsys CLK_MM_GALS_COMM0>,
+ <&mmsys CLK_MM_GALS_COMM1>;
+ clock-names = "apb", "smi", "gals0", "gals1";
+ };
+
imgsys: syscon@15020000 {
compatible = "mediatek,mt8183-imgsys", "syscon";
reg = <0 0x15020000 0 0x1000>;
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: Add smi_common node for MT8183
2020-10-01 16:28 [PATCH] arm64: dts: mediatek: Add smi_common node for MT8183 Enric Balletbo i Serra
@ 2020-10-02 9:17 ` Matthias Brugger
2020-10-15 16:07 ` Enric Balletbo i Serra
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Brugger @ 2020-10-02 9:17 UTC (permalink / raw)
To: Enric Balletbo i Serra, linux-kernel
Cc: Collabora Kernel ML, weiyi.lu, drinkcat, hsinyi, fparent,
Rob Herring, devicetree, linux-arm-kernel, linux-mediatek
On 01/10/2020 18:28, Enric Balletbo i Serra wrote:
> The SMI (Smart Multimedia Interface) Common is a bridge between the m4u
> (Multimedia Memory Management Unit) and the Multimedia HW. This block is
> needed to support different multimedia features, like display, video
> decode, and camera. Also is needed to control the power domains of such
> HW blocks.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c2fd141afcf6..9082bc65e15e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -916,6 +916,16 @@ mmsys: syscon@14000000 {
> #clock-cells = <1>;
> };
>
> + smi_common: smi@14019000 {
> + compatible = "mediatek,mt8183-smi-common", "syscon";
> + reg = <0 0x14019000 0 0x1000>;
> + clocks = <&mmsys CLK_MM_SMI_COMMON>,
> + <&mmsys CLK_MM_SMI_COMMON>,
> + <&mmsys CLK_MM_GALS_COMM0>,
> + <&mmsys CLK_MM_GALS_COMM1>;
> + clock-names = "apb", "smi", "gals0", "gals1";
> + };
> +
Having a look at the bindings description, it states that the power-domains
phandle is a required property.
So I suppose you have to base this on the power domains series.
Regards,
Matthias
> imgsys: syscon@15020000 {
> compatible = "mediatek,mt8183-imgsys", "syscon";
> reg = <0 0x15020000 0 0x1000>;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: Add smi_common node for MT8183
2020-10-02 9:17 ` Matthias Brugger
@ 2020-10-15 16:07 ` Enric Balletbo i Serra
0 siblings, 0 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-10-15 16:07 UTC (permalink / raw)
To: Matthias Brugger, linux-kernel
Cc: Collabora Kernel ML, weiyi.lu, drinkcat, hsinyi, fparent,
Rob Herring, devicetree, linux-arm-kernel, linux-mediatek
Hi Matthias,
On 2/10/20 11:17, Matthias Brugger wrote:
>
>
> On 01/10/2020 18:28, Enric Balletbo i Serra wrote:
>> The SMI (Smart Multimedia Interface) Common is a bridge between the m4u
>> (Multimedia Memory Management Unit) and the Multimedia HW. This block is
>> needed to support different multimedia features, like display, video
>> decode, and camera. Also is needed to control the power domains of such
>> HW blocks.
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> ---
>>
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index c2fd141afcf6..9082bc65e15e 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -916,6 +916,16 @@ mmsys: syscon@14000000 {
>> #clock-cells = <1>;
>> };
>> + smi_common: smi@14019000 {
>> + compatible = "mediatek,mt8183-smi-common", "syscon";
>> + reg = <0 0x14019000 0 0x1000>;
>> + clocks = <&mmsys CLK_MM_SMI_COMMON>,
>> + <&mmsys CLK_MM_SMI_COMMON>,
>> + <&mmsys CLK_MM_GALS_COMM0>,
>> + <&mmsys CLK_MM_GALS_COMM1>;
>> + clock-names = "apb", "smi", "gals0", "gals1";
>> + };
>> +
>
> Having a look at the bindings description, it states that the power-domains
> phandle is a required property.
Hmmm, this makes me think that there is a kind of circular dependency for
MT8183, so MT8183 power domains depends on smi_common and smi_common depends on
MT8183 power domains. Will take a deeper look.
Thanks
Enric
> So I suppose you have to base this on the power domains series.
>
> Regards,
> Matthias
>
>> imgsys: syscon@15020000 {
>> compatible = "mediatek,mt8183-imgsys", "syscon";
>> reg = <0 0x15020000 0 0x1000>;
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-15 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 16:28 [PATCH] arm64: dts: mediatek: Add smi_common node for MT8183 Enric Balletbo i Serra
2020-10-02 9:17 ` Matthias Brugger
2020-10-15 16:07 ` Enric Balletbo i Serra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).