* Re: Patch "ASoC: topology: disable size checks for bytes_ext controls if needed" has been added to the 4.9-stable tree [not found] <20201026055347.0F79E20882@mail.kernel.org> @ 2020-10-26 12:11 ` Greg KH 2020-10-26 15:01 ` Pierre-Louis Bossart 0 siblings, 1 reply; 3+ messages in thread From: Greg KH @ 2020-10-26 12:11 UTC (permalink / raw) To: linux-kernel; +Cc: pierre-louis.bossart, stable-commits On Mon, Oct 26, 2020 at 01:53:46AM -0400, Sasha Levin wrote: > This is a note to let you know that I've just added the patch titled > > ASoC: topology: disable size checks for bytes_ext controls if needed > > to the 4.9-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > asoc-topology-disable-size-checks-for-bytes_ext-cont.patch > and it can be found in the queue-4.9 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@vger.kernel.org> know about it. > This breaks the build, so I'm dropping it from everywhere it had problems. Also, why 5.4.y and not 4.19.y, but 4.14.y and 4.9.y? thanks, greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch "ASoC: topology: disable size checks for bytes_ext controls if needed" has been added to the 4.9-stable tree 2020-10-26 12:11 ` Patch "ASoC: topology: disable size checks for bytes_ext controls if needed" has been added to the 4.9-stable tree Greg KH @ 2020-10-26 15:01 ` Pierre-Louis Bossart 2020-10-26 15:22 ` Takashi Iwai 0 siblings, 1 reply; 3+ messages in thread From: Pierre-Louis Bossart @ 2020-10-26 15:01 UTC (permalink / raw) To: Greg KH, linux-kernel; +Cc: stable-commits, Takashi Iwai On 10/26/20 7:11 AM, Greg KH wrote: > On Mon, Oct 26, 2020 at 01:53:46AM -0400, Sasha Levin wrote: >> This is a note to let you know that I've just added the patch titled >> >> ASoC: topology: disable size checks for bytes_ext controls if needed >> >> to the 4.9-stable tree which can be found at: >> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary >> >> The filename of the patch is: >> asoc-topology-disable-size-checks-for-bytes_ext-cont.patch >> and it can be found in the queue-4.9 subdirectory. >> >> If you, or anyone else, feels it should not be added to the stable tree, >> please let <stable@vger.kernel.org> know about it. >> > > This breaks the build, so I'm dropping it from everywhere it had > problems. > > Also, why 5.4.y and not 4.19.y, but 4.14.y and 4.9.y? Ah yes, there's a missed dependency on fbd3eb7f66c5b ('ALSA: control: Add verification for kctl accesses') I thought all of this was 20 years old but that commit added the option SND_CTL_VALIDATION which exposed the problem with this topology patch. Given the date (January 2020), I don't think it makes sense before 5.6? I don't think this could have compiled prior to 5.6, I e.g. checked on 4.14.202 and the define SNDRV_CTL_ELEM_ACCESS_SKIP_CHECK was not defined either. git grep SNDRV_CTL_ELEM_ACCESS_SKIP_CHECK sound/soc/soc-topology.c: k->access |= SNDRV_CTL_ELEM_ACCESS_SKIP_CHECK; Summary: I suggested this patch be dropped for all versions that don't contain fbd3eb7f66c5b. Takashi, do you concur? Thanks for spotting this. -Pierre ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch "ASoC: topology: disable size checks for bytes_ext controls if needed" has been added to the 4.9-stable tree 2020-10-26 15:01 ` Pierre-Louis Bossart @ 2020-10-26 15:22 ` Takashi Iwai 0 siblings, 0 replies; 3+ messages in thread From: Takashi Iwai @ 2020-10-26 15:22 UTC (permalink / raw) To: Pierre-Louis Bossart; +Cc: Greg KH, linux-kernel, stable-commits, Takashi Iwai On Mon, 26 Oct 2020 16:01:09 +0100, Pierre-Louis Bossart wrote: > > > > On 10/26/20 7:11 AM, Greg KH wrote: > > On Mon, Oct 26, 2020 at 01:53:46AM -0400, Sasha Levin wrote: > >> This is a note to let you know that I've just added the patch titled > >> > >> ASoC: topology: disable size checks for bytes_ext controls if needed > >> > >> to the 4.9-stable tree which can be found at: > >> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > >> > >> The filename of the patch is: > >> asoc-topology-disable-size-checks-for-bytes_ext-cont.patch > >> and it can be found in the queue-4.9 subdirectory. > >> > >> If you, or anyone else, feels it should not be added to the stable tree, > >> please let <stable@vger.kernel.org> know about it. > >> > > > > This breaks the build, so I'm dropping it from everywhere it had > > problems. > > > > Also, why 5.4.y and not 4.19.y, but 4.14.y and 4.9.y? > > Ah yes, there's a missed dependency on > fbd3eb7f66c5b ('ALSA: control: Add verification for kctl accesses') > > I thought all of this was 20 years old but that commit added the > option SND_CTL_VALIDATION which exposed the problem with this topology > patch. Given the date (January 2020), I don't think it makes sense > before 5.6? > > I don't think this could have compiled prior to 5.6, I e.g. checked on > 4.14.202 and the define SNDRV_CTL_ELEM_ACCESS_SKIP_CHECK was not > defined either. > > git grep SNDRV_CTL_ELEM_ACCESS_SKIP_CHECK > sound/soc/soc-topology.c: k->access |= > SNDRV_CTL_ELEM_ACCESS_SKIP_CHECK; > > Summary: I suggested this patch be dropped for all versions that don't > contain fbd3eb7f66c5b. Takashi, do you concur? Yes, correct. thanks, Takashi ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-26 15:22 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20201026055347.0F79E20882@mail.kernel.org> 2020-10-26 12:11 ` Patch "ASoC: topology: disable size checks for bytes_ext controls if needed" has been added to the 4.9-stable tree Greg KH 2020-10-26 15:01 ` Pierre-Louis Bossart 2020-10-26 15:22 ` Takashi Iwai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).