From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Qais Yousef <qyousef@layalina.io>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [RFC PATCH 3/7] sched/fair: Remove magic margin in fits_capacity()
Date: Wed, 6 Sep 2023 16:38:47 +0200 [thread overview]
Message-ID: <e2c161dc-381a-4cd6-9b46-6810fab58222@arm.com> (raw)
In-Reply-To: <20230827233203.1315953-4-qyousef@layalina.io>
On 28/08/2023 01:31, Qais Yousef wrote:
> 80% margin is a magic value that has served its purpose for now, but it
> no longer fits the variety of systems exist today. If a system is over
> powered specifically, this 80% will mean we leave a lot of capacity
> unused before we decide to upmigrate on HMP system.
>
> The upmigration behavior should rely on the fact that a bad decision
> made will need load balance to kick in to perform misfit migration. And
> I think this is an adequate definition for what to consider as enough
> headroom to consider whether a util fits capacity or not.
>
> Use the new approximate_util_avg() function to predict the util if the
> task continues to run for TICK_US. If the value is not strictly less
> than the capacity, then it must not be placed there, ie considered
> misfit.
>
> Signed-off-by: Qais Yousef (Google) <qyousef@layalina.io>
> ---
> kernel/sched/fair.c | 21 ++++++++++++++++++---
> 1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 0b7445cd5af9..facbf3eb7141 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -109,16 +109,31 @@ int __weak arch_asym_cpu_priority(int cpu)
> }
>
> /*
> - * The margin used when comparing utilization with CPU capacity.
> + * The util will fit the capacity if it has enough headroom to grow within the
> + * next tick - which is when any load balancing activity happens to do the
> + * correction.
> *
> - * (default: ~20%)
> + * If util stays within the capacity before tick has elapsed, then it should be
> + * fine. If not, then a correction action must happen shortly after it starts
> + * running, hence we treat it as !fit.
> + *
> + * TODO: TICK is not actually accurate enough. balance_interval is the correct
> + * one to use as the next load balance doesn't not happen religiously at tick.
> + * Accessing balance_interval might be tricky and will require some refactoring
> + * first.
> */
I understand that you want to have a more intelligent margin (depending
on the util value) but why you want to use the time value of TICK_USEC
(or the balance_interval)?
We call fits_capacity() e.g. in wakeup and the next lb can just happen
immediately after it.
> -#define fits_capacity(cap, max) ((cap) * 1280 < (max) * 1024)
> +static inline bool fits_capacity(unsigned long util, unsigned long capacity)
> +{
> + return approximate_util_avg(util, TICK_USEC) < capacity;
> +}
[...]
next prev parent reply other threads:[~2023-09-06 14:39 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-27 23:31 [RFC PATCH 0/7] sched: cpufreq: Remove magic margins Qais Yousef
2023-08-27 23:31 ` [RFC PATCH 1/7] sched/pelt: Add a new function to approximate the future util_avg value Qais Yousef
2023-09-06 12:56 ` Dietmar Eggemann
2023-09-06 21:19 ` Qais Yousef
2023-09-07 11:12 ` Dietmar Eggemann
2023-09-10 19:58 ` Qais Yousef
2023-09-13 17:22 ` Dietmar Eggemann
2023-09-16 19:49 ` Qais Yousef
2023-09-16 19:52 ` Qais Yousef
2023-08-27 23:31 ` [RFC PATCH 2/7] sched/pelt: Add a new function to approximate runtime to reach given util Qais Yousef
2023-09-06 12:56 ` Dietmar Eggemann
2023-09-06 20:44 ` Dietmar Eggemann
2023-09-06 21:38 ` Qais Yousef
2023-09-15 9:15 ` Hongyan Xia
2023-09-16 19:56 ` Qais Yousef
2023-08-27 23:31 ` [RFC PATCH 3/7] sched/fair: Remove magic margin in fits_capacity() Qais Yousef
2023-09-06 14:38 ` Dietmar Eggemann [this message]
2023-09-06 21:45 ` Qais Yousef
2023-08-27 23:32 ` [RFC PATCH 4/7] sched: cpufreq: Remove magic 1.25 headroom from apply_dvfs_headroom() Qais Yousef
2023-09-07 11:34 ` Peter Zijlstra
2023-09-10 19:23 ` Qais Yousef
2023-08-27 23:32 ` [RFC PATCH 5/7] sched/schedutil: Add a new tunable to dictate response time Qais Yousef
2023-09-06 21:13 ` Dietmar Eggemann
2023-09-06 21:52 ` Qais Yousef
2023-09-07 11:44 ` Peter Zijlstra
2023-09-10 19:25 ` Qais Yousef
2023-08-27 23:32 ` [RFC PATCH 6/7] sched/pelt: Introduce PELT multiplier Qais Yousef
2023-08-27 23:32 ` [RFC PATCH 7/7] cpufreq: Change default transition delay to 2ms Qais Yousef
2023-09-06 9:18 ` [RFC PATCH 0/7] sched: cpufreq: Remove magic margins Lukasz Luba
2023-09-06 21:18 ` Qais Yousef
2023-09-07 7:48 ` Lukasz Luba
2023-09-07 11:53 ` Peter Zijlstra
2023-09-07 13:06 ` Lukasz Luba
2023-09-07 13:29 ` Peter Zijlstra
2023-09-07 13:33 ` Lukasz Luba
2023-09-07 13:38 ` Peter Zijlstra
2023-09-07 13:45 ` Lukasz Luba
2023-09-08 12:51 ` Daniel Bristot de Oliveira
2023-09-12 11:57 ` Lukasz Luba
2023-09-10 18:20 ` Qais Yousef
2023-09-10 18:14 ` Qais Yousef
2023-09-07 13:26 ` Peter Zijlstra
2023-09-07 13:57 ` Lukasz Luba
2023-09-07 14:29 ` Peter Zijlstra
2023-09-07 14:42 ` Lukasz Luba
2023-09-07 20:16 ` Peter Zijlstra
2023-09-12 11:51 ` Lukasz Luba
2023-09-12 14:01 ` Vincent Guittot
2023-09-13 9:53 ` Lukasz Luba
2023-09-12 14:28 ` Peter Zijlstra
2023-09-10 19:06 ` Qais Yousef
2023-09-10 18:46 ` Qais Yousef
2023-09-07 13:08 ` Peter Zijlstra
2023-09-08 0:17 ` Qais Yousef
2023-09-08 7:40 ` Dietmar Eggemann
2023-09-08 14:07 ` Qais Yousef
2023-09-12 17:18 ` Dietmar Eggemann
2023-09-16 19:38 ` Qais Yousef
2023-09-08 10:25 ` Peter Zijlstra
2023-09-08 13:33 ` Qais Yousef
2023-09-08 13:58 ` Peter Zijlstra
2023-09-08 13:59 ` Peter Zijlstra
2023-09-08 14:11 ` Qais Yousef
2023-09-10 21:17 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2c161dc-381a-4cd6-9b46-6810fab58222@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rafael@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).