* [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings
@ 2022-09-26 7:43 Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins Krzysztof Kozlowski
` (33 more replies)
0 siblings, 34 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Hi,
Changes since v1
================
v1: https://lore.kernel.org/linux-devicetree/20220924080459.13084-1-krzysztof.kozlowski@linaro.org/T/#t
1. As Stephan suggested, move check for function on non-GPIO pins to common
TLMM schema. This affects few commits in the set named:
"use common TLMM schema"
"do not require function on non-GPIOs"
Overview
========
This is the third, independent patchset around Qualcomm pinctrl in recent days:
1. First round of TLMM fixes: merged
2. LPASS fixes:
https://lore.kernel.org/linux-devicetree/20220922195651.345369-1-krzysztof.kozlowski@linaro.org/T/#t
3. ARMv7 TLMM fixes: *THIS PATCHSET*
4. ARMv8 remaining TLMM fixes: v1 send:
https://lore.kernel.org/linux-devicetree/20220925110608.145728-1-krzysztof.kozlowski@linaro.org/T/#t
Dependencies
============
1. No dependencies.
2. dt-bindings are independent of DTS patches.
Best regards,
Krzysztof
Krzysztof Kozlowski (33):
arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins
arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema
ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl
ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema
ARM: dts: qcom: msm8226: align TLMM pin configuration with DT schema
ARM: dts: qcom: msm8974: align TLMM pin configuration with DT schema
dt-bindings: pinctrl: qcom,tlmm-common: add common check for function
dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function
dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux
dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config
dt-bindings: pinctrl: qcom,ipq6018: use common TLMM schema
dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example
dt-bindings: pinctrl: qcom,msm8226: fix matching pin config
dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema
dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable
dt-bindings: pinctrl: qcom,msm8226: fix indentation in example
dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config
dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on
non-GPIOs
dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example
dt-bindings: pinctrl: qcom,msm8953: fix matching pin config
dt-bindings: pinctrl: qcom,msm8953: use common TLMM schema
dt-bindings: pinctrl: qcom,msm8953: fix indentation in example
dt-bindings: pinctrl: qcom,mdm9607: do not require function on
non-GPIOs
dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example
dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config
dt-bindings: pinctrl: qcom,qcm2290: use common TLMM schema
dt-bindings: pinctrl: qcom,sdx55: fix matching pin config
dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema
dt-bindings: pinctrl: qcom,sdx55: fix indentation in example
dt-bindings: pinctrl: qcom,sdx65: fix matching pin config
dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema
dt-bindings: pinctrl: qcom,sc7280: fix matching pin config
dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example
(remaining piece)
.../pinctrl/qcom,ipq6018-pinctrl.yaml | 60 +++++++++--------
.../pinctrl/qcom,mdm9607-pinctrl.yaml | 23 ++++---
.../pinctrl/qcom,msm8226-pinctrl.yaml | 63 +++++++++---------
.../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 64 +++++++++----------
.../pinctrl/qcom,msm8953-pinctrl.yaml | 51 ++++++++-------
.../pinctrl/qcom,qcm2290-pinctrl.yaml | 11 ++--
.../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 14 +++-
.../pinctrl/qcom,sc8280xp-pinctrl.yaml | 4 +-
.../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 51 ++++++++-------
.../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 12 ++--
.../bindings/pinctrl/qcom,tlmm-common.yaml | 20 ++++--
arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 6 +-
arch/arm/boot/dts/qcom-msm8226.dtsi | 24 +++----
.../qcom-msm8974-lge-nexus5-hammerhead.dts | 30 ++++-----
.../boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 45 +++++--------
arch/arm/boot/dts/qcom-sdx55.dtsi | 1 +
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 8 ++-
arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 +-
18 files changed, 264 insertions(+), 227 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-27 14:01 ` Robert Marko
2022-09-26 7:43 ` [PATCH v2 02/33] arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema Krzysztof Kozlowski
` (32 subsequent siblings)
33 siblings, 2 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
When BLSPI1 (originally SPI0, later renamed in commit f82c48d46852
("arm64: dts: qcom: ipq6018: correct QUP peripheral labels")) was added,
the device node lacked respective pin configuration assignment. It
used also blsp0_spi function but that was probably the same mistake as
naming it SPI0.
Fixes: 5bf635621245 ("arm64: dts: ipq6018: Add a few device nodes")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
index 1ba2eca33c7b..afc2dc79767d 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
+++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
@@ -37,6 +37,8 @@ &blsp1_i2c3 {
&blsp1_spi1 {
cs-select = <0>;
+ pinctrl-0 = <&spi_0_pins>;
+ pinctrl-names = "default";
status = "okay";
flash@0 {
@@ -57,7 +59,7 @@ i2c_1_pins: i2c-1-pins {
spi_0_pins: spi-0-pins {
pins = "gpio38", "gpio39", "gpio40", "gpio41";
- function = "blsp0_spi";
+ function = "blsp1_spi";
drive-strength = <8>;
bias-pull-down;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 02/33] arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 03/33] ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl Krzysztof Kozlowski
` (31 subsequent siblings)
33 siblings, 1 reply; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
DT schema expects TLMM pin configuration nodes to be named with
'-state' suffix and their optional children with '-pins' suffix.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 4 ++--
arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
index afc2dc79767d..e1fe7d598580 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
+++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
@@ -51,13 +51,13 @@ flash@0 {
};
&tlmm {
- i2c_1_pins: i2c-1-pins {
+ i2c_1_pins: i2c-1-state {
pins = "gpio42", "gpio43";
function = "blsp2_i2c";
drive-strength = <8>;
};
- spi_0_pins: spi-0-pins {
+ spi_0_pins: spi-0-state {
pins = "gpio38", "gpio39", "gpio40", "gpio41";
function = "blsp1_spi";
drive-strength = <8>;
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index a7c7ca980a71..9b9f778090e1 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -218,14 +218,14 @@ tlmm: pinctrl@1000000 {
interrupt-controller;
#interrupt-cells = <2>;
- serial_3_pins: serial3-pinmux {
+ serial_3_pins: serial3-state {
pins = "gpio44", "gpio45";
function = "blsp2_uart";
drive-strength = <8>;
bias-pull-down;
};
- qpic_pins: qpic-pins {
+ qpic_pins: qpic-state {
pins = "gpio1", "gpio3", "gpio4",
"gpio5", "gpio6", "gpio7",
"gpio8", "gpio10", "gpio11",
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 03/33] ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 02/33] arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 04/33] ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema Krzysztof Kozlowski
` (30 subsequent siblings)
33 siblings, 1 reply; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Add required gpio-ranges property to TLMM pinctrl node:
qcom-sdx55-mtp.dtb: pinctrl@f100000: 'gpio-ranges' is a required property
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/qcom-sdx55.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index c72540223fa9..f1c0dab40992 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -559,6 +559,7 @@ tlmm: pinctrl@f100000 {
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
+ gpio-ranges = <&tlmm 0 0 109>;
};
sram@1468f000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 04/33] ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 03/33] ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 05/33] ARM: dts: qcom: msm8226: " Krzysztof Kozlowski
` (29 subsequent siblings)
33 siblings, 1 reply; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
DT schema expects TLMM pin configuration nodes to be named with
'-state' suffix and their optional children with '-pins' suffix. Schema
also requires 'function' property, so two nodes for the same gpio (mux
and config) should be merged into one.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 45 +++++++------------
1 file changed, 15 insertions(+), 30 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
index a4fa468a095f..ac8b4626ae9a 100644
--- a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
+++ b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
@@ -282,40 +282,25 @@ &remoteproc_mpss {
};
&tlmm {
- pcie_ep_clkreq_default: pcie_ep_clkreq_default {
- mux {
- pins = "gpio56";
- function = "pcie_clkreq";
- };
- config {
- pins = "gpio56";
- drive-strength = <2>;
- bias-disable;
- };
+ pcie_ep_clkreq_default: pcie-ep-clkreq-default-state {
+ pins = "gpio56";
+ function = "pcie_clkreq";
+ drive-strength = <2>;
+ bias-disable;
};
- pcie_ep_perst_default: pcie_ep_perst_default {
- mux {
- pins = "gpio57";
- function = "gpio";
- };
- config {
- pins = "gpio57";
- drive-strength = <2>;
- bias-pull-down;
- };
+ pcie_ep_perst_default: pcie-ep-perst-default-state {
+ pins = "gpio57";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
};
- pcie_ep_wake_default: pcie_ep_wake_default {
- mux {
- pins = "gpio53";
- function = "gpio";
- };
- config {
- pins = "gpio53";
- drive-strength = <2>;
- bias-disable;
- };
+ pcie_ep_wake_default: pcie-ep-wake-default-state {
+ pins = "gpio53";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 05/33] ARM: dts: qcom: msm8226: align TLMM pin configuration with DT schema
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (3 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 04/33] ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-27 13:11 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 06/33] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
` (28 subsequent siblings)
33 siblings, 1 reply; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
DT schema expects TLMM pin configuration nodes to be named with
'-state' suffix and their optional children with '-pins' suffix.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 6 +++---
arch/arm/boot/dts/qcom-msm8226.dtsi | 24 ++++++++++-----------
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
index 193569f0ca5f..02bef5870526 100644
--- a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
+++ b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
@@ -299,8 +299,8 @@ bluetooth_default_state: bluetooth-default-state {
input-enable;
};
- touch_pins: touch {
- irq {
+ touch_pins: touch-state {
+ irq-pins {
pins = "gpio17";
function = "gpio";
@@ -309,7 +309,7 @@ irq {
input-enable;
};
- reset {
+ reset-pins {
pins = "gpio16";
function = "gpio";
diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
index cf2d56929428..3b6e746a4af9 100644
--- a/arch/arm/boot/dts/qcom-msm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
@@ -354,35 +354,35 @@ tlmm: pinctrl@fd510000 {
#interrupt-cells = <2>;
interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
- blsp1_i2c1_pins: blsp1-i2c1 {
+ blsp1_i2c1_pins: blsp1-i2c1-state {
pins = "gpio2", "gpio3";
function = "blsp_i2c1";
drive-strength = <2>;
bias-disable;
};
- blsp1_i2c2_pins: blsp1-i2c2 {
+ blsp1_i2c2_pins: blsp1-i2c2-state {
pins = "gpio6", "gpio7";
function = "blsp_i2c2";
drive-strength = <2>;
bias-disable;
};
- blsp1_i2c3_pins: blsp1-i2c3 {
+ blsp1_i2c3_pins: blsp1-i2c3-state {
pins = "gpio10", "gpio11";
function = "blsp_i2c3";
drive-strength = <2>;
bias-disable;
};
- blsp1_i2c4_pins: blsp1-i2c4 {
+ blsp1_i2c4_pins: blsp1-i2c4-state {
pins = "gpio14", "gpio15";
function = "blsp_i2c4";
drive-strength = <2>;
bias-disable;
};
- blsp1_i2c5_pins: blsp1-i2c5 {
+ blsp1_i2c5_pins: blsp1-i2c5-state {
pins = "gpio18", "gpio19";
function = "blsp_i2c5";
drive-strength = <2>;
@@ -390,13 +390,13 @@ blsp1_i2c5_pins: blsp1-i2c5 {
};
sdhc1_default_state: sdhc1-default-state {
- clk {
+ clk-pins {
pins = "sdc1_clk";
drive-strength = <10>;
bias-disable;
};
- cmd-data {
+ cmd-data-pins {
pins = "sdc1_cmd", "sdc1_data";
drive-strength = <10>;
bias-pull-up;
@@ -404,13 +404,13 @@ cmd-data {
};
sdhc2_default_state: sdhc2-default-state {
- clk {
+ clk-pins {
pins = "sdc2_clk";
drive-strength = <10>;
bias-disable;
};
- cmd-data {
+ cmd-data-pins {
pins = "sdc2_cmd", "sdc2_data";
drive-strength = <10>;
bias-pull-up;
@@ -418,21 +418,21 @@ cmd-data {
};
sdhc3_default_state: sdhc3-default-state {
- clk {
+ clk-pins {
pins = "gpio44";
function = "sdc3";
drive-strength = <8>;
bias-disable;
};
- cmd {
+ cmd-pins {
pins = "gpio43";
function = "sdc3";
drive-strength = <8>;
bias-pull-up;
};
- data {
+ data-pins {
pins = "gpio39", "gpio40", "gpio41", "gpio42";
function = "sdc3";
drive-strength = <8>;
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 06/33] ARM: dts: qcom: msm8974: align TLMM pin configuration with DT schema
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (4 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 05/33] ARM: dts: qcom: msm8226: " Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-27 13:11 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 07/33] dt-bindings: pinctrl: qcom,tlmm-common: add common check for function Krzysztof Kozlowski
` (27 subsequent siblings)
33 siblings, 1 reply; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
DT schema expects TLMM pin configuration nodes to be named with
'-state' suffix and their optional children with '-pins' suffix.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../qcom-msm8974-lge-nexus5-hammerhead.dts | 30 +++++++++----------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
index 6daceaa87802..8138f37233aa 100644
--- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
+++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
@@ -573,43 +573,43 @@ bcrmf@1 {
};
&tlmm {
- sdc1_on: sdc1-on {
- clk {
+ sdc1_on: sdc1-on-state {
+ clk-pins {
pins = "sdc1_clk";
drive-strength = <16>;
bias-disable;
};
- cmd-data {
+ cmd-data-pins {
pins = "sdc1_cmd", "sdc1_data";
drive-strength = <10>;
bias-pull-up;
};
};
- sdc2_on: sdc2-on {
- clk {
+ sdc2_on: sdc2-on-state {
+ clk-pins {
pins = "sdc2_clk";
drive-strength = <6>;
bias-disable;
};
- cmd-data {
+ cmd-data-pins {
pins = "sdc2_cmd", "sdc2_data";
drive-strength = <6>;
bias-pull-up;
};
};
- mpu6515_pin: mpu6515 {
+ mpu6515_pin: mpu6515-state {
pins = "gpio73";
function = "gpio";
bias-disable;
input-enable;
};
- touch_pin: touch {
- int {
+ touch_pin: touch-state {
+ int-pins {
pins = "gpio5";
function = "gpio";
@@ -618,7 +618,7 @@ int {
input-enable;
};
- reset {
+ reset-pins {
pins = "gpio8";
function = "gpio";
@@ -627,25 +627,25 @@ reset {
};
};
- panel_pin: panel {
+ panel_pin: panel-state {
pins = "gpio12";
function = "mdp_vsync";
drive-strength = <2>;
bias-disable;
};
- bt_pin: bt {
- hostwake {
+ bt_pin: bt-state {
+ hostwake-pins {
pins = "gpio42";
function = "gpio";
};
- devwake {
+ devwake-pins {
pins = "gpio62";
function = "gpio";
};
- shutdown {
+ shutdown-pins {
pins = "gpio41";
function = "gpio";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 07/33] dt-bindings: pinctrl: qcom,tlmm-common: add common check for function
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (5 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 06/33] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 08/33] dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function Krzysztof Kozlowski
` (26 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Certain pins, like SDcard related, do not have functions and such should
not be required. Add a check for this in common Qualcomm TLMM pin
controller schema.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,tlmm-common.yaml | 20 +++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
index c88c8dcb69d9..e1354f0c64f8 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
@@ -65,10 +65,6 @@ additionalProperties: true
$defs:
qcom-tlmm-state:
- allOf:
- - $ref: pincfg-node.yaml#
- - $ref: pinmux-node.yaml#
-
properties:
drive-strength:
enum: [2, 4, 6, 8, 10, 12, 14, 16]
@@ -82,5 +78,21 @@ $defs:
output-high: true
output-low: true
+ allOf:
+ - $ref: pincfg-node.yaml#
+ - $ref: pinmux-node.yaml#
+
+ - if:
+ properties:
+ pins:
+ items:
+ pattern: "^gpio"
+ then:
+ required:
+ - function
+ else:
+ properties:
+ function: false
+
additionalProperties: true
...
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 08/33] dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (6 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 07/33] dt-bindings: pinctrl: qcom,tlmm-common: add common check for function Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 09/33] dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux Krzysztof Kozlowski
` (25 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The IPQ6018 pinctrl driver supports qpic_pad and DTS already uses it:
'qpic_pad' is not one of ['adsp_ext', 'alsp_int', 'atest_bbrx0', ...
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
index 9c6e2cb0c6a5..0bd1aded132d 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
@@ -92,9 +92,9 @@ patternProperties:
qdss_ctitrig_in_b0, qdss_ctitrig_in_b1, qdss_ctitrig_out_a0,
qdss_ctitrig_out_a1, qdss_ctitrig_out_b0, qdss_ctitrig_out_b1,
qdss_traceclk_a, qdss_traceclk_b, qdss_tracectl_a, qdss_tracectl_b,
- qdss_tracedata_a, qdss_tracedata_b, reset_n, sd_card, sd_write,
- sec_mi2s, smb_int, ssbi_wtr0, ssbi_wtr1, uim1, uim2, uim3,
- uim_batt, wcss_bt, wcss_fm, wcss_wlan, webcam1_rst ]
+ qdss_tracedata_a, qdss_tracedata_b, qpic_pad, reset_n, sd_card,
+ sd_write, sec_mi2s, smb_int, ssbi_wtr0, ssbi_wtr1, uim1, uim2,
+ uim3, uim_batt, wcss_bt, wcss_fm, wcss_wlan, webcam1_rst ]
drive-strength:
enum: [2, 4, 6, 8, 10, 12, 14, 16]
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 09/33] dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (7 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 08/33] dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 10/33] dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config Krzysztof Kozlowski
` (24 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
One pinxmux node can have more than 4 pins to configure:
['gpio1', 'gpio3', 'gpio4', 'gpio5', 'gpio6', 'gpio7', 'gpio8', 'gpio10', 'gpio11', 'gpio12', 'gpio13', 'gpio14', 'gpio15', 'gpio17'] is too long
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
index 0bd1aded132d..670eb7162e1a 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
@@ -63,7 +63,7 @@ patternProperties:
sdc2_data, qdsd_cmd, qdsd_data0, qdsd_data1, qdsd_data2,
qdsd_data3 ]
minItems: 1
- maxItems: 4
+ maxItems: 16
function:
description:
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 10/33] dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (8 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 09/33] dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 11/33] dt-bindings: pinctrl: qcom,ipq6018: use common TLMM schema Krzysztof Kozlowski
` (23 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched. This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
index 670eb7162e1a..50d8b04bb590 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
@@ -42,10 +42,17 @@ properties:
gpio-ranges:
maxItems: 1
-#PIN CONFIGURATION NODES
patternProperties:
- '-pinmux$':
- type: object
+ "-state$":
+ oneOf:
+ - $ref: "#/$defs/qcom-ipq6018-tlmm-state"
+ - patternProperties:
+ "-pins$":
+ $ref: "#/$defs/qcom-ipq6018-tlmm-state"
+ additionalProperties: false
+
+$defs:
+ qcom-ipq6018-tlmm-state:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
@@ -146,7 +153,7 @@ examples:
#gpio-cells = <2>;
gpio-ranges = <&tlmm 0 0 80>;
- serial3-pinmux {
+ serial3-state {
pins = "gpio44", "gpio45";
function = "blsp2_uart";
drive-strength = <8>;
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 11/33] dt-bindings: pinctrl: qcom,ipq6018: use common TLMM schema
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (9 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 10/33] dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 12/33] dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example Krzysztof Kozlowski
` (22 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Reference common Qualcomm TLMM pin controller schema, to bring other
regular schemas and additional checks, like function required only for
GPIOs.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
index 50d8b04bb590..111eb5b60e8a 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
@@ -56,7 +56,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
- $ref: "/schemas/pinctrl/pincfg-node.yaml"
+ $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
properties:
pins:
@@ -121,12 +121,11 @@ $defs:
required:
- pins
- - function
additionalProperties: false
allOf:
- - $ref: "pinctrl.yaml#"
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
required:
- compatible
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 12/33] dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (10 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 11/33] dt-bindings: pinctrl: qcom,ipq6018: use common TLMM schema Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 13/33] dt-bindings: pinctrl: qcom,msm8226: fix matching pin config Krzysztof Kozlowski
` (21 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings example should be indented with 4-spaces.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../pinctrl/qcom,ipq6018-pinctrl.yaml | 34 +++++++++----------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
index 111eb5b60e8a..fc00158069b0 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
@@ -141,21 +141,21 @@ additionalProperties: false
examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- tlmm: pinctrl@1000000 {
- compatible = "qcom,ipq6018-pinctrl";
- reg = <0x01000000 0x300000>;
- interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-controller;
- #interrupt-cells = <2>;
- gpio-controller;
- #gpio-cells = <2>;
- gpio-ranges = <&tlmm 0 0 80>;
-
- serial3-state {
- pins = "gpio44", "gpio45";
- function = "blsp2_uart";
- drive-strength = <8>;
- bias-pull-down;
- };
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ tlmm: pinctrl@1000000 {
+ compatible = "qcom,ipq6018-pinctrl";
+ reg = <0x01000000 0x300000>;
+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-ranges = <&tlmm 0 0 80>;
+
+ serial3-state {
+ pins = "gpio44", "gpio45";
+ function = "blsp2_uart";
+ drive-strength = <8>;
+ bias-pull-down;
};
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 13/33] dt-bindings: pinctrl: qcom,msm8226: fix matching pin config
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (11 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 12/33] dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 14/33] dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema Krzysztof Kozlowski
` (20 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched. This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
index ab4a2b4cfda2..ecb90c77f666 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
@@ -45,9 +45,17 @@ properties:
gpio-reserved-ranges:
maxItems: 1
-#PIN CONFIGURATION NODES
patternProperties:
- '-pins$':
+ "-state$":
+ oneOf:
+ - $ref: "#/$defs/qcom-msm8226-tlmm-state"
+ - patternProperties:
+ "-pins$":
+ $ref: "#/$defs/qcom-msm8226-tlmm-state"
+ additionalProperties: false
+
+$defs:
+ qcom-msm8226-tlmm-state:
type: object
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
@@ -126,7 +134,7 @@ examples:
#interrupt-cells = <2>;
interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
- serial-pins {
+ serial-state {
pins = "gpio8", "gpio9";
function = "blsp_uart3";
drive-strength = <8>;
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 14/33] dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (12 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 13/33] dt-bindings: pinctrl: qcom,msm8226: fix matching pin config Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 15/33] dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable Krzysztof Kozlowski
` (19 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Reference common Qualcomm TLMM pin controller schema, to bring other
regular schemas and additional checks, like function required only for
GPIOs.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
index ecb90c77f666..4420bb23c9dc 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
@@ -60,7 +60,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
- $ref: "/schemas/pinctrl/pincfg-node.yaml"
+ $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
properties:
pins:
@@ -101,12 +101,11 @@ $defs:
required:
- pins
- - function
additionalProperties: false
allOf:
- - $ref: "pinctrl.yaml#"
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
required:
- compatible
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 15/33] dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (13 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 14/33] dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 16/33] dt-bindings: pinctrl: qcom,msm8226: fix indentation in example Krzysztof Kozlowski
` (18 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The MSM8226 pinctrl driver supports input-enable, blsp_i2c4, blsp_uart4
and sdc3 functions and DTS already uses it:
qcom-msm8226-samsung-s3ve3g.dtb: pinctrl@fd510000: 'blsp1-i2c1', 'blsp1-i2c2', 'blsp1-i2c3', 'blsp1-i2c4', 'blsp1-i2c5' ...
qcom-apq8026-lg-lenok.dtb: pinctrl@fd510000: touch-state: 'oneOf' conditional failed, one must be fixed:
'input-enable' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
index 4420bb23c9dc..8c5c85807882 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
@@ -79,9 +79,10 @@ $defs:
Specify the alternative function to be configured for the specified
pins. Functions are only valid for gpio pins.
enum: [ gpio, cci_i2c0, blsp_uim1, blsp_uim2, blsp_uim3, blsp_uim5,
- blsp_i2c1, blsp_i2c2, blsp_i2c3, blsp_i2c5, blsp_spi1,
+ blsp_i2c1, blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_spi1,
blsp_spi2, blsp_spi3, blsp_spi5, blsp_uart1, blsp_uart2,
- blsp_uart3, blsp_uart5, cam_mclk0, cam_mclk1, wlan ]
+ blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, sdc3,
+ wlan ]
drive-strength:
enum: [2, 4, 6, 8, 10, 12, 14, 16]
@@ -90,13 +91,10 @@ $defs:
Selects the drive strength for the specified pins, in mA.
bias-pull-down: true
-
bias-pull-up: true
-
bias-disable: true
-
+ input-enable: true
output-high: true
-
output-low: true
required:
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 16/33] dt-bindings: pinctrl: qcom,msm8226: fix indentation in example
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (14 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 15/33] dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 17/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config Krzysztof Kozlowski
` (17 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings example should be indented with 4-spaces.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../pinctrl/qcom,msm8226-pinctrl.yaml | 36 +++++++++----------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
index 8c5c85807882..b466d2ffc437 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
@@ -119,22 +119,22 @@ additionalProperties: false
examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- msmgpio: pinctrl@fd510000 {
- compatible = "qcom,msm8226-pinctrl";
- reg = <0xfd510000 0x4000>;
-
- gpio-controller;
- #gpio-cells = <2>;
- gpio-ranges = <&msmgpio 0 0 117>;
- interrupt-controller;
- #interrupt-cells = <2>;
- interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
-
- serial-state {
- pins = "gpio8", "gpio9";
- function = "blsp_uart3";
- drive-strength = <8>;
- bias-disable;
- };
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ msmgpio: pinctrl@fd510000 {
+ compatible = "qcom,msm8226-pinctrl";
+ reg = <0xfd510000 0x4000>;
+
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-ranges = <&msmgpio 0 0 117>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+
+ serial-state {
+ pins = "gpio8", "gpio9";
+ function = "blsp_uart3";
+ drive-strength = <8>;
+ bias-disable;
};
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 17/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (15 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 16/33] dt-bindings: pinctrl: qcom,msm8226: fix indentation in example Krzysztof Kozlowski
@ 2022-09-26 7:43 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 18/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs Krzysztof Kozlowski
` (16 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched. This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
index e03530091478..b1735918fa90 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
@@ -43,8 +43,9 @@ patternProperties:
oneOf:
- $ref: "#/$defs/qcom-msm8909-tlmm-state"
- patternProperties:
- ".*":
+ "-pins$":
$ref: "#/$defs/qcom-msm8909-tlmm-state"
+ additionalProperties: false
$defs:
qcom-msm8909-tlmm-state:
@@ -136,13 +137,13 @@ examples:
};
uart-w-subnodes-state {
- rx {
+ rx-pins {
pins = "gpio4";
function = "blsp_uart1";
bias-pull-up;
};
- tx {
+ tx-pins {
pins = "gpio5";
function = "blsp_uart1";
bias-disable;
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 18/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (16 preceding siblings ...)
2022-09-26 7:43 ` [PATCH v2 17/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 19/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example Krzysztof Kozlowski
` (15 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Certain pins, like SDcard related, do not have functions and such should
not be required.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
index b1735918fa90..08e2dd5cbebe 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
@@ -113,7 +113,6 @@ $defs:
required:
- pins
- - function
additionalProperties: false
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 19/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (17 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 18/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 20/33] dt-bindings: pinctrl: qcom,msm8953: fix matching pin config Krzysztof Kozlowski
` (14 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings example should be indented with 4-spaces.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 60 +++++++++----------
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
index 08e2dd5cbebe..9c647e24fa9a 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
@@ -118,35 +118,35 @@ $defs:
examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
-
- pinctrl@1000000 {
- compatible = "qcom,msm8909-tlmm";
- reg = <0x1000000 0x300000>;
- interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
- gpio-controller;
- #gpio-cells = <2>;
- gpio-ranges = <&tlmm 0 0 117>;
- interrupt-controller;
- #interrupt-cells = <2>;
-
- gpio-wo-subnode-state {
- pins = "gpio1";
- function = "gpio";
- };
-
- uart-w-subnodes-state {
- rx-pins {
- pins = "gpio4";
- function = "blsp_uart1";
- bias-pull-up;
- };
-
- tx-pins {
- pins = "gpio5";
- function = "blsp_uart1";
- bias-disable;
- };
- };
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ pinctrl@1000000 {
+ compatible = "qcom,msm8909-tlmm";
+ reg = <0x1000000 0x300000>;
+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-ranges = <&tlmm 0 0 117>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+
+ gpio-wo-subnode-state {
+ pins = "gpio1";
+ function = "gpio";
};
+
+ uart-w-subnodes-state {
+ rx-pins {
+ pins = "gpio4";
+ function = "blsp_uart1";
+ bias-pull-up;
+ };
+
+ tx-pins {
+ pins = "gpio5";
+ function = "blsp_uart1";
+ bias-disable;
+ };
+ };
+ };
...
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 20/33] dt-bindings: pinctrl: qcom,msm8953: fix matching pin config
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (18 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 19/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 21/33] dt-bindings: pinctrl: qcom,msm8953: use common TLMM schema Krzysztof Kozlowski
` (13 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched. This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,msm8953-pinctrl.yaml | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
index d4da558cde54..c162796ab604 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
@@ -44,9 +44,17 @@ properties:
gpio-ranges:
maxItems: 1
-#PIN CONFIGURATION NODES
patternProperties:
- '-pins$':
+ "-state$":
+ oneOf:
+ - $ref: "#/$defs/qcom-msm8953-tlmm-state"
+ - patternProperties:
+ "-pins$":
+ $ref: "#/$defs/qcom-msm8953-tlmm-state"
+ additionalProperties: false
+
+$defs:
+ qcom-msm8953-tlmm-state:
type: object
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
@@ -163,7 +171,7 @@ examples:
#gpio-cells = <2>;
gpio-ranges = <&tlmm 0 0 142>;
- serial_default: serial-pins {
+ serial_default: serial-state {
pins = "gpio4", "gpio5";
function = "blsp_uart2";
drive-strength = <2>;
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 21/33] dt-bindings: pinctrl: qcom,msm8953: use common TLMM schema
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (19 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 20/33] dt-bindings: pinctrl: qcom,msm8953: fix matching pin config Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 22/33] dt-bindings: pinctrl: qcom,msm8953: fix indentation in example Krzysztof Kozlowski
` (12 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Reference common Qualcomm TLMM pin controller schema, to bring other
regular schemas and additional checks, like function required only for
GPIOs.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
index c162796ab604..c4ab54c9d5e8 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
@@ -59,7 +59,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
- $ref: "/schemas/pinctrl/pincfg-node.yaml"
+ $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
properties:
pins:
@@ -139,12 +139,11 @@ $defs:
required:
- pins
- - function
additionalProperties: false
allOf:
- - $ref: "pinctrl.yaml#"
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
required:
- compatible
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 22/33] dt-bindings: pinctrl: qcom,msm8953: fix indentation in example
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (20 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 21/33] dt-bindings: pinctrl: qcom,msm8953: use common TLMM schema Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 23/33] dt-bindings: pinctrl: qcom,mdm9607: do not require function on non-GPIOs Krzysztof Kozlowski
` (11 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings example should be indented with 4-spaces.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../pinctrl/qcom,msm8953-pinctrl.yaml | 34 +++++++++----------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
index c4ab54c9d5e8..48676393352e 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
@@ -159,21 +159,21 @@ additionalProperties: false
examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- tlmm: pinctrl@1000000 {
- compatible = "qcom,msm8953-pinctrl";
- reg = <0x01000000 0x300000>;
- interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-controller;
- #interrupt-cells = <2>;
- gpio-controller;
- #gpio-cells = <2>;
- gpio-ranges = <&tlmm 0 0 142>;
-
- serial_default: serial-state {
- pins = "gpio4", "gpio5";
- function = "blsp_uart2";
- drive-strength = <2>;
- bias-disable;
- };
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ tlmm: pinctrl@1000000 {
+ compatible = "qcom,msm8953-pinctrl";
+ reg = <0x01000000 0x300000>;
+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-ranges = <&tlmm 0 0 142>;
+
+ serial_default: serial-state {
+ pins = "gpio4", "gpio5";
+ function = "blsp_uart2";
+ drive-strength = <2>;
+ bias-disable;
};
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 23/33] dt-bindings: pinctrl: qcom,mdm9607: do not require function on non-GPIOs
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (21 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 22/33] dt-bindings: pinctrl: qcom,msm8953: fix indentation in example Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 24/33] dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example Krzysztof Kozlowski
` (10 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Certain pins, like SDcard related, do not have functions and such should
not be required.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
index f7bd4be1739e..57a4fed55de7 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
@@ -115,7 +115,6 @@ patternProperties:
required:
- pins
- - function
additionalProperties: false
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 24/33] dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (22 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 23/33] dt-bindings: pinctrl: qcom,mdm9607: do not require function on non-GPIOs Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 25/33] dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config Krzysztof Kozlowski
` (9 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings example should be indented with 4-spaces.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../pinctrl/qcom,mdm9607-pinctrl.yaml | 22 +++++++++----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
index 57a4fed55de7..a37b358715a3 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
@@ -120,14 +120,14 @@ patternProperties:
examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- tlmm: pinctrl@1000000 {
- compatible = "qcom,mdm9607-tlmm";
- reg = <0x01000000 0x300000>;
- interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
- gpio-controller;
- gpio-ranges = <&msmgpio 0 0 80>;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- };
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ tlmm: pinctrl@1000000 {
+ compatible = "qcom,mdm9607-tlmm";
+ reg = <0x01000000 0x300000>;
+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+ gpio-controller;
+ gpio-ranges = <&msmgpio 0 0 80>;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 25/33] dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (23 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 24/33] dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 26/33] dt-bindings: pinctrl: qcom,qcm2290: use common TLMM schema Krzysztof Kozlowski
` (8 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched. This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,qcm2290-pinctrl.yaml | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml
index 3f4f1c0360b5..5324b61eb4f7 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml
@@ -50,8 +50,9 @@ patternProperties:
oneOf:
- $ref: "#/$defs/qcom-qcm2290-tlmm-state"
- patternProperties:
- ".*":
+ "-pins$":
$ref: "#/$defs/qcom-qcm2290-tlmm-state"
+ additionalProperties: false
'$defs':
qcom-qcm2290-tlmm-state:
@@ -146,19 +147,19 @@ examples:
gpio-ranges = <&tlmm 0 0 127>;
sdc2_on_state: sdc2-on-state {
- clk {
+ clk-pins {
pins = "sdc2_clk";
bias-disable;
drive-strength = <16>;
};
- cmd {
+ cmd-pins {
pins = "sdc2_cmd";
bias-pull-up;
drive-strength = <10>;
};
- data {
+ data-pins {
pins = "sdc2_data";
bias-pull-up;
drive-strength = <10>;
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 26/33] dt-bindings: pinctrl: qcom,qcm2290: use common TLMM schema
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (24 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 25/33] dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 27/33] dt-bindings: pinctrl: qcom,sdx55: fix matching pin config Krzysztof Kozlowski
` (7 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Reference common Qualcomm TLMM pin controller schema, to bring other
regular schemas and additional checks, like function required only for
GPIOs.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml
index 5324b61eb4f7..2a23f413c8c2 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml
@@ -119,7 +119,7 @@ patternProperties:
additionalProperties: false
allOf:
- - $ref: "pinctrl.yaml#"
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
required:
- compatible
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 27/33] dt-bindings: pinctrl: qcom,sdx55: fix matching pin config
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (25 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 26/33] dt-bindings: pinctrl: qcom,qcm2290: use common TLMM schema Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 28/33] dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema Krzysztof Kozlowski
` (6 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched.
qcom-sdx55-telit-fn980-tlb.dtb: pinctrl@f100000: 'pcie_ep_clkreq_default', 'pcie_ep_perst_default', 'pcie_ep_wake_default' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
This method also unifies the bindings with other Qualcomm TLMM and LPASS
pinctrl bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
index a38090b14aab..fff57abf4fbc 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
@@ -45,9 +45,17 @@ properties:
gpio-reserved-ranges:
maxItems: 1
-#PIN CONFIGURATION NODES
patternProperties:
- '-pins$':
+ "-state$":
+ oneOf:
+ - $ref: "#/$defs/qcom-sdx55-tlmm-state"
+ - patternProperties:
+ "-pins$":
+ $ref: "#/$defs/qcom-sdx55-tlmm-state"
+ additionalProperties: false
+
+$defs:
+ qcom-sdx55-tlmm-state:
type: object
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
@@ -146,7 +154,7 @@ examples:
#interrupt-cells = <2>;
interrupts = <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>;
- serial-pins {
+ serial-state {
pins = "gpio8", "gpio9";
function = "blsp_uart3";
drive-strength = <8>;
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 28/33] dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (26 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 27/33] dt-bindings: pinctrl: qcom,sdx55: fix matching pin config Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 29/33] dt-bindings: pinctrl: qcom,sdx55: fix indentation in example Krzysztof Kozlowski
` (5 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Reference common Qualcomm TLMM pin controller schema, to bring other
regular schemas and additional checks, like function required only for
GPIOs.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
index fff57abf4fbc..52b7a557f452 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
@@ -60,7 +60,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
- $ref: "/schemas/pinctrl/pincfg-node.yaml"
+ $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
properties:
pins:
@@ -122,12 +122,11 @@ $defs:
required:
- pins
- - function
additionalProperties: false
allOf:
- - $ref: "pinctrl.yaml#"
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
required:
- compatible
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 29/33] dt-bindings: pinctrl: qcom,sdx55: fix indentation in example
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (27 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 28/33] dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 30/33] dt-bindings: pinctrl: qcom,sdx65: fix matching pin config Krzysztof Kozlowski
` (4 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings example should be indented with 4-spaces.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 34 +++++++++----------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
index 52b7a557f452..b861feab73dd 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
@@ -142,23 +142,23 @@ additionalProperties: false
examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- tlmm: pinctrl@1f00000 {
- compatible = "qcom,sdx55-pinctrl";
- reg = <0x0f100000 0x300000>;
- gpio-controller;
- #gpio-cells = <2>;
- gpio-ranges = <&tlmm 0 0 108>;
- interrupt-controller;
- #interrupt-cells = <2>;
- interrupts = <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>;
-
- serial-state {
- pins = "gpio8", "gpio9";
- function = "blsp_uart3";
- drive-strength = <8>;
- bias-disable;
- };
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ tlmm: pinctrl@1f00000 {
+ compatible = "qcom,sdx55-pinctrl";
+ reg = <0x0f100000 0x300000>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-ranges = <&tlmm 0 0 108>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ interrupts = <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>;
+
+ serial-state {
+ pins = "gpio8", "gpio9";
+ function = "blsp_uart3";
+ drive-strength = <8>;
+ bias-disable;
};
+ };
...
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 30/33] dt-bindings: pinctrl: qcom,sdx65: fix matching pin config
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (28 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 29/33] dt-bindings: pinctrl: qcom,sdx55: fix indentation in example Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 31/33] dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema Krzysztof Kozlowski
` (3 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched. This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
index cdfcf29dffee..0f796f1f0104 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
@@ -49,8 +49,10 @@ patternProperties:
oneOf:
- $ref: "#/$defs/qcom-sdx65-tlmm-state"
- patternProperties:
- ".*":
+ "-pins$":
$ref: "#/$defs/qcom-sdx65-tlmm-state"
+ additionalProperties: false
+
'$defs':
qcom-sdx65-tlmm-state:
type: object
@@ -175,13 +177,13 @@ examples:
};
uart-w-subnodes-state {
- rx {
+ rx-pins {
pins = "gpio4";
function = "blsp_uart1";
bias-pull-up;
};
- tx {
+ tx-pins {
pins = "gpio5";
function = "blsp_uart1";
bias-disable;
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 31/33] dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (29 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 30/33] dt-bindings: pinctrl: qcom,sdx65: fix matching pin config Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 32/33] dt-bindings: pinctrl: qcom,sc7280: fix matching pin config Krzysztof Kozlowski
` (2 subsequent siblings)
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Reference common Qualcomm TLMM pin controller schema, to bring other
regular schemas and additional checks, like function required only for
GPIOs.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
index 0f796f1f0104..f5451b1a3a2f 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
@@ -142,10 +142,12 @@ patternProperties:
required:
- pins
- - function
additionalProperties: false
+allOf:
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
+
required:
- compatible
- reg
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 32/33] dt-bindings: pinctrl: qcom,sc7280: fix matching pin config
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (30 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 31/33] dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 33/33] dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example (remaining piece) Krzysztof Kozlowski
2022-09-27 3:41 ` [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Bjorn Andersson
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched. This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
index ad3496784678..4606ca980dc4 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
@@ -47,9 +47,17 @@ properties:
wakeup-parent: true
-#PIN CONFIGURATION NODES
patternProperties:
- '-pins$':
+ "-state$":
+ oneOf:
+ - $ref: "#/$defs/qcom-sc7280-tlmm-state"
+ - patternProperties:
+ "-pins$":
+ $ref: "#/$defs/qcom-sc7280-tlmm-state"
+ additionalProperties: false
+
+$defs:
+ qcom-sc7280-tlmm-state:
type: object
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
@@ -162,7 +170,7 @@ examples:
gpio-ranges = <&tlmm 0 0 175>;
wakeup-parent = <&pdc>;
- qup_uart5_default: qup-uart5-pins {
+ qup_uart5_default: qup-uart5-state {
pins = "gpio46", "gpio47";
function = "qup13";
drive-strength = <2>;
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH v2 33/33] dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example (remaining piece)
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (31 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 32/33] dt-bindings: pinctrl: qcom,sc7280: fix matching pin config Krzysztof Kozlowski
@ 2022-09-26 7:44 ` Krzysztof Kozlowski
2022-09-27 3:41 ` [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Bjorn Andersson
33 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 7:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings example should be indented with 4-spaces. Previous adjustment
missefd one spot.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
index b9ab130cd558..0b251caaebf2 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
@@ -139,8 +139,8 @@ examples:
gpio-ranges = <&tlmm 0 0 230>;
gpio-wo-subnode-state {
- pins = "gpio1";
- function = "gpio";
+ pins = "gpio1";
+ function = "gpio";
};
uart-w-subnodes-state {
--
2.34.1
^ permalink raw reply related [flat|nested] 45+ messages in thread
* Re: [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
` (32 preceding siblings ...)
2022-09-26 7:44 ` [PATCH v2 33/33] dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example (remaining piece) Krzysztof Kozlowski
@ 2022-09-27 3:41 ` Bjorn Andersson
33 siblings, 0 replies; 45+ messages in thread
From: Bjorn Andersson @ 2022-09-27 3:41 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Konrad Dybcio, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo, Vinod Koul,
krishna Lanka, Sivaprakash Murugesan, linux-arm-msm, linux-gpio,
devicetree, linux-kernel
On Mon, Sep 26, 2022 at 09:43:42AM +0200, Krzysztof Kozlowski wrote:
> Hi,
>
> Changes since v1
> ================
> v1: https://lore.kernel.org/linux-devicetree/20220924080459.13084-1-krzysztof.kozlowski@linaro.org/T/#t
> 1. As Stephan suggested, move check for function on non-GPIO pins to common
> TLMM schema. This affects few commits in the set named:
> "use common TLMM schema"
> "do not require function on non-GPIOs"
>
> Overview
> ========
> This is the third, independent patchset around Qualcomm pinctrl in recent days:
> 1. First round of TLMM fixes: merged
> 2. LPASS fixes:
> https://lore.kernel.org/linux-devicetree/20220922195651.345369-1-krzysztof.kozlowski@linaro.org/T/#t
> 3. ARMv7 TLMM fixes: *THIS PATCHSET*
> 4. ARMv8 remaining TLMM fixes: v1 send:
> https://lore.kernel.org/linux-devicetree/20220925110608.145728-1-krzysztof.kozlowski@linaro.org/T/#t
>
> Dependencies
> ============
> 1. No dependencies.
> 2. dt-bindings are independent of DTS patches.
>
> Best regards,
> Krzysztof
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
>
> Krzysztof Kozlowski (33):
> arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins
> arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema
> ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl
> ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema
> ARM: dts: qcom: msm8226: align TLMM pin configuration with DT schema
> ARM: dts: qcom: msm8974: align TLMM pin configuration with DT schema
> dt-bindings: pinctrl: qcom,tlmm-common: add common check for function
> dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function
> dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux
> dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config
> dt-bindings: pinctrl: qcom,ipq6018: use common TLMM schema
> dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example
> dt-bindings: pinctrl: qcom,msm8226: fix matching pin config
> dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema
> dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable
> dt-bindings: pinctrl: qcom,msm8226: fix indentation in example
> dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config
> dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on
> non-GPIOs
> dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example
> dt-bindings: pinctrl: qcom,msm8953: fix matching pin config
> dt-bindings: pinctrl: qcom,msm8953: use common TLMM schema
> dt-bindings: pinctrl: qcom,msm8953: fix indentation in example
> dt-bindings: pinctrl: qcom,mdm9607: do not require function on
> non-GPIOs
> dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example
> dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config
> dt-bindings: pinctrl: qcom,qcm2290: use common TLMM schema
> dt-bindings: pinctrl: qcom,sdx55: fix matching pin config
> dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema
> dt-bindings: pinctrl: qcom,sdx55: fix indentation in example
> dt-bindings: pinctrl: qcom,sdx65: fix matching pin config
> dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema
> dt-bindings: pinctrl: qcom,sc7280: fix matching pin config
> dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example
> (remaining piece)
>
> .../pinctrl/qcom,ipq6018-pinctrl.yaml | 60 +++++++++--------
> .../pinctrl/qcom,mdm9607-pinctrl.yaml | 23 ++++---
> .../pinctrl/qcom,msm8226-pinctrl.yaml | 63 +++++++++---------
> .../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 64 +++++++++----------
> .../pinctrl/qcom,msm8953-pinctrl.yaml | 51 ++++++++-------
> .../pinctrl/qcom,qcm2290-pinctrl.yaml | 11 ++--
> .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 14 +++-
> .../pinctrl/qcom,sc8280xp-pinctrl.yaml | 4 +-
> .../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 51 ++++++++-------
> .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 12 ++--
> .../bindings/pinctrl/qcom,tlmm-common.yaml | 20 ++++--
> arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 6 +-
> arch/arm/boot/dts/qcom-msm8226.dtsi | 24 +++----
> .../qcom-msm8974-lge-nexus5-hammerhead.dts | 30 ++++-----
> .../boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 45 +++++--------
> arch/arm/boot/dts/qcom-sdx55.dtsi | 1 +
> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 8 ++-
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 +-
> 18 files changed, 264 insertions(+), 227 deletions(-)
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins
2022-09-26 7:43 ` [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins Krzysztof Kozlowski
@ 2022-09-27 13:10 ` Konrad Dybcio
2022-09-27 14:01 ` Robert Marko
1 sibling, 0 replies; 45+ messages in thread
From: Konrad Dybcio @ 2022-09-27 13:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On 26.09.2022 09:43, Krzysztof Kozlowski wrote:
> When BLSPI1 (originally SPI0, later renamed in commit f82c48d46852
> ("arm64: dts: qcom: ipq6018: correct QUP peripheral labels")) was added,
> the device node lacked respective pin configuration assignment. It
> used also blsp0_spi function but that was probably the same mistake as
> naming it SPI0.
>
> Fixes: 5bf635621245 ("arm64: dts: ipq6018: Add a few device nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> index 1ba2eca33c7b..afc2dc79767d 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> @@ -37,6 +37,8 @@ &blsp1_i2c3 {
>
> &blsp1_spi1 {
> cs-select = <0>;
> + pinctrl-0 = <&spi_0_pins>;
> + pinctrl-names = "default";
> status = "okay";
>
> flash@0 {
> @@ -57,7 +59,7 @@ i2c_1_pins: i2c-1-pins {
>
> spi_0_pins: spi-0-pins {
> pins = "gpio38", "gpio39", "gpio40", "gpio41";
> - function = "blsp0_spi";
> + function = "blsp1_spi";
> drive-strength = <8>;
> bias-pull-down;
> };
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH v2 02/33] arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema
2022-09-26 7:43 ` [PATCH v2 02/33] arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema Krzysztof Kozlowski
@ 2022-09-27 13:10 ` Konrad Dybcio
0 siblings, 0 replies; 45+ messages in thread
From: Konrad Dybcio @ 2022-09-27 13:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On 26.09.2022 09:43, Krzysztof Kozlowski wrote:
> DT schema expects TLMM pin configuration nodes to be named with
> '-state' suffix and their optional children with '-pins' suffix.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 4 ++--
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> index afc2dc79767d..e1fe7d598580 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> @@ -51,13 +51,13 @@ flash@0 {
> };
>
> &tlmm {
> - i2c_1_pins: i2c-1-pins {
> + i2c_1_pins: i2c-1-state {
> pins = "gpio42", "gpio43";
> function = "blsp2_i2c";
> drive-strength = <8>;
> };
>
> - spi_0_pins: spi-0-pins {
> + spi_0_pins: spi-0-state {
> pins = "gpio38", "gpio39", "gpio40", "gpio41";
> function = "blsp1_spi";
> drive-strength = <8>;
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index a7c7ca980a71..9b9f778090e1 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -218,14 +218,14 @@ tlmm: pinctrl@1000000 {
> interrupt-controller;
> #interrupt-cells = <2>;
>
> - serial_3_pins: serial3-pinmux {
> + serial_3_pins: serial3-state {
> pins = "gpio44", "gpio45";
> function = "blsp2_uart";
> drive-strength = <8>;
> bias-pull-down;
> };
>
> - qpic_pins: qpic-pins {
> + qpic_pins: qpic-state {
> pins = "gpio1", "gpio3", "gpio4",
> "gpio5", "gpio6", "gpio7",
> "gpio8", "gpio10", "gpio11",
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH v2 03/33] ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl
2022-09-26 7:43 ` [PATCH v2 03/33] ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl Krzysztof Kozlowski
@ 2022-09-27 13:10 ` Konrad Dybcio
0 siblings, 0 replies; 45+ messages in thread
From: Konrad Dybcio @ 2022-09-27 13:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On 26.09.2022 09:43, Krzysztof Kozlowski wrote:
> Add required gpio-ranges property to TLMM pinctrl node:
>
> qcom-sdx55-mtp.dtb: pinctrl@f100000: 'gpio-ranges' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm/boot/dts/qcom-sdx55.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index c72540223fa9..f1c0dab40992 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -559,6 +559,7 @@ tlmm: pinctrl@f100000 {
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> + gpio-ranges = <&tlmm 0 0 109>;
> };
>
> sram@1468f000 {
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH v2 04/33] ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema
2022-09-26 7:43 ` [PATCH v2 04/33] ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema Krzysztof Kozlowski
@ 2022-09-27 13:10 ` Konrad Dybcio
0 siblings, 0 replies; 45+ messages in thread
From: Konrad Dybcio @ 2022-09-27 13:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On 26.09.2022 09:43, Krzysztof Kozlowski wrote:
> DT schema expects TLMM pin configuration nodes to be named with
> '-state' suffix and their optional children with '-pins' suffix. Schema
> also requires 'function' property, so two nodes for the same gpio (mux
> and config) should be merged into one.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> .../boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 45 +++++++------------
> 1 file changed, 15 insertions(+), 30 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> index a4fa468a095f..ac8b4626ae9a 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> @@ -282,40 +282,25 @@ &remoteproc_mpss {
> };
>
> &tlmm {
> - pcie_ep_clkreq_default: pcie_ep_clkreq_default {
> - mux {
> - pins = "gpio56";
> - function = "pcie_clkreq";
> - };
> - config {
> - pins = "gpio56";
> - drive-strength = <2>;
> - bias-disable;
> - };
> + pcie_ep_clkreq_default: pcie-ep-clkreq-default-state {
> + pins = "gpio56";
> + function = "pcie_clkreq";
> + drive-strength = <2>;
> + bias-disable;
> };
>
> - pcie_ep_perst_default: pcie_ep_perst_default {
> - mux {
> - pins = "gpio57";
> - function = "gpio";
> - };
> - config {
> - pins = "gpio57";
> - drive-strength = <2>;
> - bias-pull-down;
> - };
> + pcie_ep_perst_default: pcie-ep-perst-default-state {
> + pins = "gpio57";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-down;
> };
>
> - pcie_ep_wake_default: pcie_ep_wake_default {
> - mux {
> - pins = "gpio53";
> - function = "gpio";
> - };
> - config {
> - pins = "gpio53";
> - drive-strength = <2>;
> - bias-disable;
> - };
> + pcie_ep_wake_default: pcie-ep-wake-default-state {
> + pins = "gpio53";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> };
> };
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH v2 05/33] ARM: dts: qcom: msm8226: align TLMM pin configuration with DT schema
2022-09-26 7:43 ` [PATCH v2 05/33] ARM: dts: qcom: msm8226: " Krzysztof Kozlowski
@ 2022-09-27 13:11 ` Konrad Dybcio
0 siblings, 0 replies; 45+ messages in thread
From: Konrad Dybcio @ 2022-09-27 13:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On 26.09.2022 09:43, Krzysztof Kozlowski wrote:
> DT schema expects TLMM pin configuration nodes to be named with
> '-state' suffix and their optional children with '-pins' suffix.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 6 +++---
> arch/arm/boot/dts/qcom-msm8226.dtsi | 24 ++++++++++-----------
> 2 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> index 193569f0ca5f..02bef5870526 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> @@ -299,8 +299,8 @@ bluetooth_default_state: bluetooth-default-state {
> input-enable;
> };
>
> - touch_pins: touch {
> - irq {
> + touch_pins: touch-state {
> + irq-pins {
> pins = "gpio17";
> function = "gpio";
>
> @@ -309,7 +309,7 @@ irq {
> input-enable;
> };
>
> - reset {
> + reset-pins {
> pins = "gpio16";
> function = "gpio";
>
> diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
> index cf2d56929428..3b6e746a4af9 100644
> --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> @@ -354,35 +354,35 @@ tlmm: pinctrl@fd510000 {
> #interrupt-cells = <2>;
> interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
>
> - blsp1_i2c1_pins: blsp1-i2c1 {
> + blsp1_i2c1_pins: blsp1-i2c1-state {
> pins = "gpio2", "gpio3";
> function = "blsp_i2c1";
> drive-strength = <2>;
> bias-disable;
> };
>
> - blsp1_i2c2_pins: blsp1-i2c2 {
> + blsp1_i2c2_pins: blsp1-i2c2-state {
> pins = "gpio6", "gpio7";
> function = "blsp_i2c2";
> drive-strength = <2>;
> bias-disable;
> };
>
> - blsp1_i2c3_pins: blsp1-i2c3 {
> + blsp1_i2c3_pins: blsp1-i2c3-state {
> pins = "gpio10", "gpio11";
> function = "blsp_i2c3";
> drive-strength = <2>;
> bias-disable;
> };
>
> - blsp1_i2c4_pins: blsp1-i2c4 {
> + blsp1_i2c4_pins: blsp1-i2c4-state {
> pins = "gpio14", "gpio15";
> function = "blsp_i2c4";
> drive-strength = <2>;
> bias-disable;
> };
>
> - blsp1_i2c5_pins: blsp1-i2c5 {
> + blsp1_i2c5_pins: blsp1-i2c5-state {
> pins = "gpio18", "gpio19";
> function = "blsp_i2c5";
> drive-strength = <2>;
> @@ -390,13 +390,13 @@ blsp1_i2c5_pins: blsp1-i2c5 {
> };
>
> sdhc1_default_state: sdhc1-default-state {
> - clk {
> + clk-pins {
> pins = "sdc1_clk";
> drive-strength = <10>;
> bias-disable;
> };
>
> - cmd-data {
> + cmd-data-pins {
> pins = "sdc1_cmd", "sdc1_data";
> drive-strength = <10>;
> bias-pull-up;
> @@ -404,13 +404,13 @@ cmd-data {
> };
>
> sdhc2_default_state: sdhc2-default-state {
> - clk {
> + clk-pins {
> pins = "sdc2_clk";
> drive-strength = <10>;
> bias-disable;
> };
>
> - cmd-data {
> + cmd-data-pins {
> pins = "sdc2_cmd", "sdc2_data";
> drive-strength = <10>;
> bias-pull-up;
> @@ -418,21 +418,21 @@ cmd-data {
> };
>
> sdhc3_default_state: sdhc3-default-state {
> - clk {
> + clk-pins {
> pins = "gpio44";
> function = "sdc3";
> drive-strength = <8>;
> bias-disable;
> };
>
> - cmd {
> + cmd-pins {
> pins = "gpio43";
> function = "sdc3";
> drive-strength = <8>;
> bias-pull-up;
> };
>
> - data {
> + data-pins {
> pins = "gpio39", "gpio40", "gpio41", "gpio42";
> function = "sdc3";
> drive-strength = <8>;
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH v2 06/33] ARM: dts: qcom: msm8974: align TLMM pin configuration with DT schema
2022-09-26 7:43 ` [PATCH v2 06/33] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
@ 2022-09-27 13:11 ` Konrad Dybcio
0 siblings, 0 replies; 45+ messages in thread
From: Konrad Dybcio @ 2022-09-27 13:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Stephan Gerhold, Shawn Guo,
Vinod Koul, krishna Lanka, Sivaprakash Murugesan, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On 26.09.2022 09:43, Krzysztof Kozlowski wrote:
> DT schema expects TLMM pin configuration nodes to be named with
> '-state' suffix and their optional children with '-pins' suffix.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> .../qcom-msm8974-lge-nexus5-hammerhead.dts | 30 +++++++++----------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> index 6daceaa87802..8138f37233aa 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> @@ -573,43 +573,43 @@ bcrmf@1 {
> };
>
> &tlmm {
> - sdc1_on: sdc1-on {
> - clk {
> + sdc1_on: sdc1-on-state {
> + clk-pins {
> pins = "sdc1_clk";
> drive-strength = <16>;
> bias-disable;
> };
>
> - cmd-data {
> + cmd-data-pins {
> pins = "sdc1_cmd", "sdc1_data";
> drive-strength = <10>;
> bias-pull-up;
> };
> };
>
> - sdc2_on: sdc2-on {
> - clk {
> + sdc2_on: sdc2-on-state {
> + clk-pins {
> pins = "sdc2_clk";
> drive-strength = <6>;
> bias-disable;
> };
>
> - cmd-data {
> + cmd-data-pins {
> pins = "sdc2_cmd", "sdc2_data";
> drive-strength = <6>;
> bias-pull-up;
> };
> };
>
> - mpu6515_pin: mpu6515 {
> + mpu6515_pin: mpu6515-state {
> pins = "gpio73";
> function = "gpio";
> bias-disable;
> input-enable;
> };
>
> - touch_pin: touch {
> - int {
> + touch_pin: touch-state {
> + int-pins {
> pins = "gpio5";
> function = "gpio";
>
> @@ -618,7 +618,7 @@ int {
> input-enable;
> };
>
> - reset {
> + reset-pins {
> pins = "gpio8";
> function = "gpio";
>
> @@ -627,25 +627,25 @@ reset {
> };
> };
>
> - panel_pin: panel {
> + panel_pin: panel-state {
> pins = "gpio12";
> function = "mdp_vsync";
> drive-strength = <2>;
> bias-disable;
> };
>
> - bt_pin: bt {
> - hostwake {
> + bt_pin: bt-state {
> + hostwake-pins {
> pins = "gpio42";
> function = "gpio";
> };
>
> - devwake {
> + devwake-pins {
> pins = "gpio62";
> function = "gpio";
> };
>
> - shutdown {
> + shutdown-pins {
> pins = "gpio41";
> function = "gpio";
> };
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins
2022-09-26 7:43 ` [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
@ 2022-09-27 14:01 ` Robert Marko
2022-09-27 14:33 ` Krzysztof Kozlowski
1 sibling, 1 reply; 45+ messages in thread
From: Robert Marko @ 2022-09-27 14:01 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Linus Walleij, Rob Herring, Krzysztof Kozlowski, Stephan Gerhold,
Shawn Guo, Vinod Koul, krishna Lanka, Sivaprakash Murugesan,
linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 26. 09. 2022. 09:43, Krzysztof Kozlowski wrote:
> When BLSPI1 (originally SPI0, later renamed in commit f82c48d46852
> ("arm64: dts: qcom: ipq6018: correct QUP peripheral labels")) was added,
> the device node lacked respective pin configuration assignment. It
> used also blsp0_spi function but that was probably the same mistake as
> naming it SPI0.
Hi,
Sorry for making it confusing, but "blsp0_spi" is the correct function.
Pinctrl driver and datasheets call functions blsp0-blps5, but usually in DT
we call the nodes blsp1-blsp6.
It would probably be better for me to rename the nodes to blsp0-5 instead.
Regards,
Robert
>
> Fixes: 5bf635621245 ("arm64: dts: ipq6018: Add a few device nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> index 1ba2eca33c7b..afc2dc79767d 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> @@ -37,6 +37,8 @@ &blsp1_i2c3 {
>
> &blsp1_spi1 {
> cs-select = <0>;
> + pinctrl-0 = <&spi_0_pins>;
> + pinctrl-names = "default";
> status = "okay";
>
> flash@0 {
> @@ -57,7 +59,7 @@ i2c_1_pins: i2c-1-pins {
>
> spi_0_pins: spi-0-pins {
> pins = "gpio38", "gpio39", "gpio40", "gpio41";
> - function = "blsp0_spi";
> + function = "blsp1_spi";
> drive-strength = <8>;
> bias-pull-down;
> };
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins
2022-09-27 14:01 ` Robert Marko
@ 2022-09-27 14:33 ` Krzysztof Kozlowski
2022-09-27 15:20 ` Robert Marko
0 siblings, 1 reply; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-27 14:33 UTC (permalink / raw)
To: Robert Marko, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Linus Walleij, Rob Herring, Krzysztof Kozlowski, Stephan Gerhold,
Shawn Guo, Vinod Koul, krishna Lanka, Sivaprakash Murugesan,
linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 27/09/2022 16:01, Robert Marko wrote:
>
> On 26. 09. 2022. 09:43, Krzysztof Kozlowski wrote:
>> When BLSPI1 (originally SPI0, later renamed in commit f82c48d46852
>> ("arm64: dts: qcom: ipq6018: correct QUP peripheral labels")) was added,
>> the device node lacked respective pin configuration assignment. It
>> used also blsp0_spi function but that was probably the same mistake as
>> naming it SPI0.
>
> Hi,
>
> Sorry for making it confusing, but "blsp0_spi" is the correct function.
> Pinctrl driver and datasheets call functions blsp0-blps5, but usually in DT
> we call the nodes blsp1-blsp6.
>
> It would probably be better for me to rename the nodes to blsp0-5 instead.
OK, so instead I will add blsp0_spi to the bindings.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins
2022-09-27 14:33 ` Krzysztof Kozlowski
@ 2022-09-27 15:20 ` Robert Marko
2022-09-27 15:20 ` Krzysztof Kozlowski
0 siblings, 1 reply; 45+ messages in thread
From: Robert Marko @ 2022-09-27 15:20 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Linus Walleij, Rob Herring, Krzysztof Kozlowski, Stephan Gerhold,
Shawn Guo, Vinod Koul, krishna Lanka, Sivaprakash Murugesan,
linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 27. 09. 2022. 16:33, Krzysztof Kozlowski wrote:
> On 27/09/2022 16:01, Robert Marko wrote:
>> On 26. 09. 2022. 09:43, Krzysztof Kozlowski wrote:
>>> When BLSPI1 (originally SPI0, later renamed in commit f82c48d46852
>>> ("arm64: dts: qcom: ipq6018: correct QUP peripheral labels")) was added,
>>> the device node lacked respective pin configuration assignment. It
>>> used also blsp0_spi function but that was probably the same mistake as
>>> naming it SPI0.
>> Hi,
>>
>> Sorry for making it confusing, but "blsp0_spi" is the correct function.
>> Pinctrl driver and datasheets call functions blsp0-blps5, but usually in DT
>> we call the nodes blsp1-blsp6.
>>
>> It would probably be better for me to rename the nodes to blsp0-5 instead.
> OK, so instead I will add blsp0_spi to the bindings.
Can you add blsp0_uart and blsp0_i2c as well?
All 6 of the QUP-s have same features.
I am adding MDIO to CP01, so I can add mdc and mdio to bindings
as they are lacking there as well.
Regards,
Robert
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins
2022-09-27 15:20 ` Robert Marko
@ 2022-09-27 15:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 45+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-27 15:20 UTC (permalink / raw)
To: Robert Marko, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Linus Walleij, Rob Herring, Krzysztof Kozlowski, Stephan Gerhold,
Shawn Guo, Vinod Koul, krishna Lanka, Sivaprakash Murugesan,
linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 27/09/2022 17:20, Robert Marko wrote:
>
> On 27. 09. 2022. 16:33, Krzysztof Kozlowski wrote:
>> On 27/09/2022 16:01, Robert Marko wrote:
>>> On 26. 09. 2022. 09:43, Krzysztof Kozlowski wrote:
>>>> When BLSPI1 (originally SPI0, later renamed in commit f82c48d46852
>>>> ("arm64: dts: qcom: ipq6018: correct QUP peripheral labels")) was added,
>>>> the device node lacked respective pin configuration assignment. It
>>>> used also blsp0_spi function but that was probably the same mistake as
>>>> naming it SPI0.
>>> Hi,
>>>
>>> Sorry for making it confusing, but "blsp0_spi" is the correct function.
>>> Pinctrl driver and datasheets call functions blsp0-blps5, but usually in DT
>>> we call the nodes blsp1-blsp6.
>>>
>>> It would probably be better for me to rename the nodes to blsp0-5 instead.
>> OK, so instead I will add blsp0_spi to the bindings.
>
> Can you add blsp0_uart and blsp0_i2c as well?
> All 6 of the QUP-s have same features.
Sure
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 45+ messages in thread
end of thread, other threads:[~2022-09-27 15:21 UTC | newest]
Thread overview: 45+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 7:43 [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 01/33] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-27 14:01 ` Robert Marko
2022-09-27 14:33 ` Krzysztof Kozlowski
2022-09-27 15:20 ` Robert Marko
2022-09-27 15:20 ` Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 02/33] arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 03/33] ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 04/33] ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-09-27 13:10 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 05/33] ARM: dts: qcom: msm8226: " Krzysztof Kozlowski
2022-09-27 13:11 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 06/33] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2022-09-27 13:11 ` Konrad Dybcio
2022-09-26 7:43 ` [PATCH v2 07/33] dt-bindings: pinctrl: qcom,tlmm-common: add common check for function Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 08/33] dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 09/33] dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 10/33] dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 11/33] dt-bindings: pinctrl: qcom,ipq6018: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 12/33] dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 13/33] dt-bindings: pinctrl: qcom,msm8226: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 14/33] dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 15/33] dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 16/33] dt-bindings: pinctrl: qcom,msm8226: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:43 ` [PATCH v2 17/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 18/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 19/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 20/33] dt-bindings: pinctrl: qcom,msm8953: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 21/33] dt-bindings: pinctrl: qcom,msm8953: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 22/33] dt-bindings: pinctrl: qcom,msm8953: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 23/33] dt-bindings: pinctrl: qcom,mdm9607: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 24/33] dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 25/33] dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 26/33] dt-bindings: pinctrl: qcom,qcm2290: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 27/33] dt-bindings: pinctrl: qcom,sdx55: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 28/33] dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 29/33] dt-bindings: pinctrl: qcom,sdx55: fix indentation in example Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 30/33] dt-bindings: pinctrl: qcom,sdx65: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 31/33] dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 32/33] dt-bindings: pinctrl: qcom,sc7280: fix matching pin config Krzysztof Kozlowski
2022-09-26 7:44 ` [PATCH v2 33/33] dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example (remaining piece) Krzysztof Kozlowski
2022-09-27 3:41 ` [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).