* [PATCH] media: v4l: omap_vout: vrfb: remove an unused variable
@ 2018-03-13 12:05 Arnd Bergmann
2018-03-13 13:29 ` Peter Ujfalusi
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-03-13 12:05 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Peter Ujfalusi
Cc: Arnd Bergmann, Hans Verkuil, Sakari Ailus, linux-media, linux-kernel
We now get a warning after the 'dmadev' variable is no longer used:
drivers/media/platform/omap/omap_vout_vrfb.c: In function 'omap_vout_prepare_vrfb':
drivers/media/platform/omap/omap_vout_vrfb.c:239:21: error: unused variable 'dmadev' [-Werror=unused-variable]
Fixes: 8f0aa38292f2 ("media: v4l: omap_vout: vrfb: Use the wrapper for prep_interleaved_dma()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/platform/omap/omap_vout_vrfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/omap/omap_vout_vrfb.c b/drivers/media/platform/omap/omap_vout_vrfb.c
index 72c0ac2cbf3d..1d8508237220 100644
--- a/drivers/media/platform/omap/omap_vout_vrfb.c
+++ b/drivers/media/platform/omap/omap_vout_vrfb.c
@@ -236,7 +236,6 @@ int omap_vout_prepare_vrfb(struct omap_vout_device *vout,
struct dma_async_tx_descriptor *tx;
enum dma_ctrl_flags flags = DMA_PREP_INTERRUPT | DMA_CTRL_ACK;
struct dma_chan *chan = vout->vrfb_dma_tx.chan;
- struct dma_device *dmadev = chan->device;
struct dma_interleaved_template *xt = vout->vrfb_dma_tx.xt;
dma_cookie_t cookie;
enum dma_status status;
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: v4l: omap_vout: vrfb: remove an unused variable
2018-03-13 12:05 [PATCH] media: v4l: omap_vout: vrfb: remove an unused variable Arnd Bergmann
@ 2018-03-13 13:29 ` Peter Ujfalusi
0 siblings, 0 replies; 2+ messages in thread
From: Peter Ujfalusi @ 2018-03-13 13:29 UTC (permalink / raw)
To: Arnd Bergmann, Mauro Carvalho Chehab
Cc: Hans Verkuil, Sakari Ailus, linux-media, linux-kernel
On 2018-03-13 14:05, Arnd Bergmann wrote:
> We now get a warning after the 'dmadev' variable is no longer used:
>
> drivers/media/platform/omap/omap_vout_vrfb.c: In function 'omap_vout_prepare_vrfb':
> drivers/media/platform/omap/omap_vout_vrfb.c:239:21: error: unused variable 'dmadev' [-Werror=unused-variable]
>
> Fixes: 8f0aa38292f2 ("media: v4l: omap_vout: vrfb: Use the wrapper for prep_interleaved_dma()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/media/platform/omap/omap_vout_vrfb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/omap/omap_vout_vrfb.c b/drivers/media/platform/omap/omap_vout_vrfb.c
> index 72c0ac2cbf3d..1d8508237220 100644
> --- a/drivers/media/platform/omap/omap_vout_vrfb.c
> +++ b/drivers/media/platform/omap/omap_vout_vrfb.c
> @@ -236,7 +236,6 @@ int omap_vout_prepare_vrfb(struct omap_vout_device *vout,
> struct dma_async_tx_descriptor *tx;
> enum dma_ctrl_flags flags = DMA_PREP_INTERRUPT | DMA_CTRL_ACK;
> struct dma_chan *chan = vout->vrfb_dma_tx.chan;
> - struct dma_device *dmadev = chan->device;
> struct dma_interleaved_template *xt = vout->vrfb_dma_tx.xt;
> dma_cookie_t cookie;
> enum dma_status status;
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-13 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-13 12:05 [PATCH] media: v4l: omap_vout: vrfb: remove an unused variable Arnd Bergmann
2018-03-13 13:29 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).