* [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe
@ 2020-11-11 9:52 Zheng Zengkai
2020-11-11 19:42 ` Martin Blumenstingl
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Zengkai @ 2020-11-11 9:52 UTC (permalink / raw)
To: balbi, gregkh, khilman, narmstrong
Cc: linux-kernel, linux-usb, linux-arm-kernel, linux-amlogic, zhengzengkai
dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare()
on one error handling path. This patch fixes that.
Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
---
drivers/usb/dwc3/dwc3-meson-g12a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
index 417e05381b5d..bdf1f98dfad8 100644
--- a/drivers/usb/dwc3/dwc3-meson-g12a.c
+++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
@@ -754,7 +754,7 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
ret = priv->drvdata->setup_regmaps(priv, base);
if (ret)
- return ret;
+ goto err_disable_clks;
if (priv->vbus) {
ret = regulator_enable(priv->vbus);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe
2020-11-11 9:52 [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe Zheng Zengkai
@ 2020-11-11 19:42 ` Martin Blumenstingl
2020-11-27 7:31 ` Zheng Zengkai
0 siblings, 1 reply; 4+ messages in thread
From: Martin Blumenstingl @ 2020-11-11 19:42 UTC (permalink / raw)
To: Zheng Zengkai
Cc: balbi, gregkh, khilman, Neil Armstrong, linux-amlogic, linux-usb,
linux-kernel, linux-arm-kernel
On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai <zhengzengkai@huawei.com> wrote:
>
> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare()
> on one error handling path. This patch fixes that.
>
> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
many thanks for this fix!
Best regards
Martin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe
2020-11-11 19:42 ` Martin Blumenstingl
@ 2020-11-27 7:31 ` Zheng Zengkai
2020-12-01 3:03 ` Zheng Zengkai
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Zengkai @ 2020-11-27 7:31 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: balbi, gregkh, khilman, Neil Armstrong, linux-amlogic, linux-usb,
linux-kernel, linux-arm-kernel
Ping...
> On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai <zhengzengkai@huawei.com> wrote:
>> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare()
>> on one error handling path. This patch fixes that.
>>
>> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> many thanks for this fix!
>
>
> Best regards
> Martin
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe
2020-11-27 7:31 ` Zheng Zengkai
@ 2020-12-01 3:03 ` Zheng Zengkai
0 siblings, 0 replies; 4+ messages in thread
From: Zheng Zengkai @ 2020-12-01 3:03 UTC (permalink / raw)
To: balbi
Cc: gregkh, khilman, Neil Armstrong, linux-amlogic, linux-usb,
linux-kernel, linux-arm-kernel, Martin Blumenstingl
Hi Felipe and Greg,
> Ping...
>
>> On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai
>> <zhengzengkai@huawei.com> wrote:
>>> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare()
>>> on one error handling path. This patch fixes that.
>>>
>>> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY
>>> initialization on G12A and A1 SoCs")
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
>> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>>
>> many thanks for this fix!
>>
>>
>> Best regards
>> Martin
>>
>> .
Could you please get round to taking a glance and giving me a reply? ;-)
Thank you very much!
Best regards
Zengkai
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-01 3:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11 9:52 [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe Zheng Zengkai
2020-11-11 19:42 ` Martin Blumenstingl
2020-11-27 7:31 ` Zheng Zengkai
2020-12-01 3:03 ` Zheng Zengkai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).