From: Bernd Schubert <bernd.schubert@fastmail.fm>
To: Miklos Szeredi <miklos@szeredi.hu>, Bernd Schubert <bschubert@ddn.com>
Cc: linux-fsdevel@vger.kernel.org,
Dharmendra Singh <dharamhans87@gmail.com>,
fuse-devel <fuse-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [fuse-devel] [PATCH v5 0/3] FUSE: Implement atomic lookup + open/create
Date: Thu, 19 May 2022 22:47:11 +0200 [thread overview]
Message-ID: <fb2937b5-1bbf-511f-082f-b3b7fbc65128@fastmail.fm> (raw)
In-Reply-To: <CAJfpegsJijCeNZ9ES72e=gDNDisK5itG67GK8xNWRar=HMm6gA@mail.gmail.com>
On 5/19/22 20:16, Miklos Szeredi wrote:
> On Thu, 19 May 2022 at 19:42, Bernd Schubert <bschubert@ddn.com> wrote:
>
>> Can you help me a bit to understand what we should change? I had also
>> already thought to merge CREATE_EXT and OPEN_ATOMIC - so agreed.
>> Shall we make the other cases more visible?
>
> Make it clear in the code flow if we are using the new request or the
> old; e.g. rename current fuse_atomic_open() to fuse_open_nonatomic()
> and do
>
> static int fuse_open_atomic(...)
> {
> ...
> args.opcode = FUSE_OPEN_ATOMIC;
> ...
> err = fuse_simple_request(...);
> if (err == -ENOSYS)
> goto fallback;
> ...
> fallback:
> return fuse_open_nonatomic();
> }
>
> static int fuse_atomic_open(...)
> {
> if (fc->no_open_atomic)
> return fuse_open_nonatomic();
> else
> return fuse_open_atomic();
> }
>
> Also we can tweak fuse_dentry_revalidate() so it always invalidates
> negative dentries if the new atomic open is available, and possibly
> for positive dentries as well, if the rfc patch makes it.
Thank you, we will try to do it like that during the next day.
Thanks,
Bernd
next prev parent reply other threads:[~2022-05-19 20:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 10:07 [PATCH v5 0/3] FUSE: Implement atomic lookup + open/create Dharmendra Singh
2022-05-17 10:07 ` [PATCH v5 1/3] FUSE: Avoid lookups in fuse create Dharmendra Singh
2022-05-17 21:21 ` Vivek Goyal
2022-05-18 17:41 ` Vivek Goyal
2022-05-18 17:44 ` Vivek Goyal
2022-05-18 20:28 ` Bernd Schubert
2022-05-17 10:07 ` [PATCH v5 2/3] FUSE: Rename fuse_create_open() to fuse_atomic_common() Dharmendra Singh
2022-05-17 10:07 ` [PATCH v5 3/3] FUSE: Implement atomic lookup + open Dharmendra Singh
2022-05-19 9:39 ` [PATCH v5 0/3] FUSE: Implement atomic lookup + open/create Miklos Szeredi
2022-05-19 13:13 ` Miklos Szeredi
2022-05-19 17:41 ` Bernd Schubert
2022-05-19 18:16 ` Miklos Szeredi
2022-05-19 20:47 ` Bernd Schubert [this message]
2022-05-19 19:33 ` Vivek Goyal
2023-06-01 11:16 ` Bernd Schubert
2023-06-01 11:50 ` Miklos Szeredi
2023-06-01 12:01 ` Bernd Schubert
2023-06-01 12:18 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb2937b5-1bbf-511f-082f-b3b7fbc65128@fastmail.fm \
--to=bernd.schubert@fastmail.fm \
--cc=bschubert@ddn.com \
--cc=dharamhans87@gmail.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).