[REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[Michael Catanzaro]

Hi,

On my System76 Gazelle Pro (gazp9) laptop, internal audio broke after 
upgrading to kernel 5.10.

The laptop's speakers produce no sound. Audio from headphones still 
works fine. A quick test is to visit GNOME System Settings -> Sound -> 
Output, select Test, click Front Left or Front Right and notice there 
is no sound. I tested a mainline kernel revision from yesterday 
(5.11-rc5+) and the regression is not yet fixed. I bisected the 
regression to "ALSA: HDA: Early Forbid of runtime PM":

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a0645daf16101bb9a6d87598c17e9a8b7bd60ea7

I created a downstream bug report here, including some bits from dmesg 
that may or may not be relevant in comment #2:

https://bugzilla.redhat.com/show_bug.cgi?id=1918933

Audio devices:

$ lspci | grep -i audio
00:03.0 Audio device: Intel Corporation Xeon E3-1200 v3/4th Gen Core 
Processor HD Audio Controller (rev 06)
00:1b.0 Audio device: Intel Corporation 8 Series/C220 Series Chipset 
High Definition Audio Controller (rev 05)

OS: Fedora 33

I'm happy to provide any additional required info or test patches if 
you CC me, since I'm not a kernel developer and am not subscribed to 
these lists. Thanks.

RE: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[N, Harshapriya]

> The laptop's speakers produce no sound. Audio from headphones still works
> fine. A quick test is to visit GNOME System Settings -> Sound -> Output,
> select Test, click Front Left or Front Right and notice there is no sound. I
> tested a mainline kernel revision from yesterday
> (5.11-rc5+) and the regression is not yet fixed. I bisected the regression to
> "ALSA: HDA: Early Forbid of runtime PM":
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i
> d=a0645daf16101bb9a6d87598c17e9a8b7bd60ea7

Does reverting just this patch fix the issue you are seeing?

> 
> I created a downstream bug report here, including some bits from dmesg
> that may or may not be relevant in comment #2:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1918933
> 
> Audio devices:
> 
> $ lspci | grep -i audio
> 00:03.0 Audio device: Intel Corporation Xeon E3-1200 v3/4th Gen Core
> Processor HD Audio Controller (rev 06)
> 00:1b.0 Audio device: Intel Corporation 8 Series/C220 Series Chipset High
> Definition Audio Controller (rev 05)
> 
> OS: Fedora 33
> 
> I'm happy to provide any additional required info or test patches if you CC
> me, since I'm not a kernel developer and am not subscribed to these lists.

Can you share the full dmesg and also let us know which codecs are on your system?

> Thanks.
> 

Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[Takashi Iwai]

On Fri, 29 Jan 2021 17:12:08 +0100,
Michael Catanzaro wrote:
> 
> On Fri, Jan 29, 2021 at 9:30 am, Michael Catanzaro
> <mcatanzaro@redhat.com> wrote:
> > OK, I found "ALSA: hda/via: Apply the workaround generically for
> > Clevo machines" which was just merged yesterday. So I will test
> > again to find out.
> 
> Hi Takashi, hi Harsha,
> 
> I can confirm that the problem is fixed by this commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4961167bf7482944ca09a6f71263b9e47f949851

Thanks, good to hear.

Then I think we can drop the entry from power_save_denylist in
hda_intel.c.  Could you try that it still works with the patch below?


thanks,

Takashi

--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk power_save_denylist[] = {
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
-	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
-	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev */

Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[Michael Catanzaro]

On Fri, Jan 29, 2021 at 5:17 pm, Takashi Iwai <tiwai@suse.de> wrote:
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk 
> power_save_denylist[] = {
>  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
>  	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
>  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
> -	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
> -	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
>  	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
>  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
>  	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA 
> dev */

Hi,

This patch works fine on my laptop. I have no clue whether that means 
it's really safe to remove the quirk. I've never noticed any clicking 
noise myself, but I understand it has been a problem for other System76 
laptops.

Michael

Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[Takashi Iwai]

On Fri, 29 Jan 2021 18:24:16 +0100,
Michael Catanzaro wrote:
> 
> On Fri, Jan 29, 2021 at 5:17 pm, Takashi Iwai <tiwai@suse.de> wrote:
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk
> > power_save_denylist[] = {
> >  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
> >  	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
> >  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
> > -	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
> > -	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
> >  	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
> >  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
> >  	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the
> > HDA dev */
> 
> Hi,
> 
> This patch works fine on my laptop. I have no clue whether that means
> it's really safe to remove the quirk. I've never noticed any clicking
> noise myself, but I understand it has been a problem for other
> System76 laptops.

If you find no noticeable problem, that's fine, and I believe we can
drop from the deny list.  But it's no urgent issue and fit well as a
5.12 material.  Will submit a proper patch later.


thanks,

Takashi

Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[藍挺瑋]

I am not sure if I should join this old thread, but it seems that I saw the same
issue on my ASUS B23E laptop. It couldn't produce any sound after upgrading to
Linux 5.10, and 'git bisect' shows it was broken by the same commit
a0645daf16101bb9a6d87598c17e9a8b7bd60ea7.

I have tested the latest master branch (v5.14-rc4-322-gcceb634774ef) last week.
It still had no sound. If I reverted the broken commit, sound worked.

alsa-info from the broken kernel:
https://gist.github.com/lantw44/0660e059c488e3ff3d841bb03b371866

alsa-info from the working kernel:
https://gist.github.com/lantw44/9367f425e4f5ba98cf12343cb90f3301

lspci:
00:00.0 Host bridge: Intel Corporation 2nd Generation Core Processor Family DRAM
Controller (rev 09)
00:02.0 VGA compatible controller: Intel Corporation 2nd Generation Core
Processor Family Integrated Graphics Controller (rev 09)
00:16.0 Communication controller: Intel Corporation 6 Series/C200 Series Chipset
Family MEI Controller #1 (rev 04)
00:16.3 Serial controller: Intel Corporation 6 Series/C200 Series Chipset Family
KT Controller (rev 04)
00:19.0 Ethernet controller: Intel Corporation 82579LM Gigabit Network
Connection (Lewisville) (rev 05)
00:1a.0 USB controller: Intel Corporation 6 Series/C200 Series Chipset Family
USB Enhanced Host Controller #2 (rev 05)
00:1b.0 Audio device: Intel Corporation 6 Series/C200 Series Chipset Family High
Definition Audio Controller (rev 05)
00:1c.0 PCI bridge: Intel Corporation 6 Series/C200 Series Chipset Family PCI
Express Root Port 1 (rev b5)
00:1c.1 PCI bridge: Intel Corporation 6 Series/C200 Series Chipset Family PCI
Express Root Port 2 (rev b5)
00:1c.2 PCI bridge: Intel Corporation 6 Series/C200 Series Chipset Family PCI
Express Root Port 3 (rev b5)
00:1c.3 PCI bridge: Intel Corporation 6 Series/C200 Series Chipset Family PCI
Express Root Port 4 (rev b5)
00:1d.0 USB controller: Intel Corporation 6 Series/C200 Series Chipset Family
USB Enhanced Host Controller #1 (rev 05)
00:1f.0 ISA bridge: Intel Corporation QM67 Express Chipset LPC Controller (rev
05)
00:1f.2 SATA controller: Intel Corporation 6 Series/C200 Series Chipset Family 6
port Mobile SATA AHCI Controller (rev 05)
00:1f.3 SMBus: Intel Corporation 6 Series/C200 Series Chipset Family SMBus
Controller (rev 05)
02:00.0 Network controller: Intel Corporation Centrino Advanced-N 6230 [Rainbow
Peak] (rev 34)
06:00.0 USB controller: Fresco Logic FL1000G USB 3.0 Host Controller (rev 04)

Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[Takashi Iwai]

On Sat, 14 Aug 2021 16:02:36 +0200,
藍挺瑋 wrote:
> 
> I am not sure if I should join this old thread, but it seems that I saw the same
> issue on my ASUS B23E laptop. It couldn't produce any sound after upgrading to
> Linux 5.10, and 'git bisect' shows it was broken by the same commit
> a0645daf16101bb9a6d87598c17e9a8b7bd60ea7.
> 
> I have tested the latest master branch (v5.14-rc4-322-gcceb634774ef) last week.
> It still had no sound. If I reverted the broken commit, sound worked.

> 
> alsa-info from the broken kernel:
> https://gist.github.com/lantw44/0660e059c488e3ff3d841bb03b371866
> 
> alsa-info from the working kernel:
> https://gist.github.com/lantw44/9367f425e4f5ba98cf12343cb90f3301

Thanks for the report.  A quick workaround be a patch like below.
Could you verify whether it fixes the problem?


Takashi

--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -1041,6 +1041,7 @@ static const struct hda_fixup via_fixups[] = {
 };
 
 static const struct snd_pci_quirk vt2002p_fixups[] = {
+	SND_PCI_QUIRK(0x1043, 0x13f7, "Asus B23E", VIA_FIXUP_POWER_SAVE),
 	SND_PCI_QUIRK(0x1043, 0x1487, "Asus G75", VIA_FIXUP_ASUS_G75),
 	SND_PCI_QUIRK(0x1043, 0x8532, "Asus X202E", VIA_FIXUP_INTMIC_BOOST),
 	SND_PCI_QUIRK_VENDOR(0x1558, "Clevo", VIA_FIXUP_POWER_SAVE),

Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[藍挺瑋]

於 星期日，2021-08-15 於 11:20 +0200，Takashi Iwai 提到：
> On Sat, 14 Aug 2021 16:02:36 +0200,
> 藍挺瑋 wrote:
> > 
> > I am not sure if I should join this old thread, but it seems that I saw the
> > same
> > issue on my ASUS B23E laptop. It couldn't produce any sound after upgrading
> > to
> > Linux 5.10, and 'git bisect' shows it was broken by the same commit
> > a0645daf16101bb9a6d87598c17e9a8b7bd60ea7.
> > 
> > I have tested the latest master branch (v5.14-rc4-322-gcceb634774ef) last
> > week.
> > It still had no sound. If I reverted the broken commit, sound worked.
> 
> > 
> > alsa-info from the broken kernel:
> > https://gist.github.com/lantw44/0660e059c488e3ff3d841bb03b371866
> > 
> > alsa-info from the working kernel:
> > https://gist.github.com/lantw44/9367f425e4f5ba98cf12343cb90f3301
> 
> Thanks for the report.  A quick workaround be a patch like below.
> Could you verify whether it fixes the problem?

Yes, it fixes the problem.

> 
> 
> Takashi
> 
> --- a/sound/pci/hda/patch_via.c
> +++ b/sound/pci/hda/patch_via.c
> @@ -1041,6 +1041,7 @@ static const struct hda_fixup via_fixups[] = {
>  };
>  
>  static const struct snd_pci_quirk vt2002p_fixups[] = {
> +       SND_PCI_QUIRK(0x1043, 0x13f7, "Asus B23E", VIA_FIXUP_POWER_SAVE),
>         SND_PCI_QUIRK(0x1043, 0x1487, "Asus G75", VIA_FIXUP_ASUS_G75),
>         SND_PCI_QUIRK(0x1043, 0x8532, "Asus X202E", VIA_FIXUP_INTMIC_BOOST),
>         SND_PCI_QUIRK_VENDOR(0x1558, "Clevo", VIA_FIXUP_POWER_SAVE),

Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[Takashi Iwai]

On Mon, 16 Aug 2021 18:57:03 +0200,
藍挺瑋 wrote:
> 
> 於 星期日，2021-08-15 於 11:20 +0200，Takashi Iwai 提到：
> > On Sat, 14 Aug 2021 16:02:36 +0200,
> > 藍挺瑋 wrote:
> > > 
> > > I am not sure if I should join this old thread, but it seems that I saw the
> > > same
> > > issue on my ASUS B23E laptop. It couldn't produce any sound after upgrading
> > > to
> > > Linux 5.10, and 'git bisect' shows it was broken by the same commit
> > > a0645daf16101bb9a6d87598c17e9a8b7bd60ea7.
> > > 
> > > I have tested the latest master branch (v5.14-rc4-322-gcceb634774ef) last
> > > week.
> > > It still had no sound. If I reverted the broken commit, sound worked.
> > 
> > > 
> > > alsa-info from the broken kernel:
> > > https://gist.github.com/lantw44/0660e059c488e3ff3d841bb03b371866
> > > 
> > > alsa-info from the working kernel:
> > > https://gist.github.com/lantw44/9367f425e4f5ba98cf12343cb90f3301
> > 
> > Thanks for the report.  A quick workaround be a patch like below.
> > Could you verify whether it fixes the problem?
> 
> Yes, it fixes the problem.

Thanks.  Now I submitted a final patch and will merge it for
5.14-rc7 pull request.


Takashi

Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[Erich Ritz]

On Friday, January 29, 2021 9:17 AM, Takashi Iwai <tiwai@suse.de> wrote:

> On Fri, 29 Jan 2021 17:12:08 +0100,
> Michael Catanzaro wrote:
>
> > On Fri, Jan 29, 2021 at 9:30 am, Michael Catanzaro
> > mcatanzaro@redhat.com wrote:
> >
> > > OK, I found "ALSA: hda/via: Apply the workaround generically for
> > > Clevo machines" which was just merged yesterday. So I will test
> > > again to find out.
> >
> > Hi Takashi, hi Harsha,
> > I can confirm that the problem is fixed by this commit:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4961167bf7482944ca09a6f71263b9e47f949851
>
> Thanks, good to hear.
>
> Then I think we can drop the entry from power_save_denylist in
> hda_intel.c. Could you try that it still works with the patch below?
>
> thanks,
>
> Takashi
>
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk power_save_denylist[] = {
> /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 /
> SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
> / https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
>
> -   SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
> -   /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 /
>     SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
>     / https://bugzilla.redhat.com/show_bug.cgi?id=1525104 /
>     / Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev */

For me applying patch 4961167bf7482944ca09a6f71263b9e47f949851 on top of 5.10.12 fixes audio, but the above quoted patch applied to 5.10.12 does NOT fix audio.  What I mean by fixes:
Audio works normally on 5.4.94, and on 5.10.12 with patch 4961167 applied.
I hear no audio from the laptop speakers on 5.10.12 and 5.10.12 with the above quoted patch applied.  Opening pavucontrol shows a graphical response in the meter, but no audio is heard from the speakers.  I did not test plugging in headphones and did not test audio over HDMI.

I have a System76 Gazelle Pro 7 (gazp7).

# lspci -s "00:1b" -vv
00:1b.0 Audio device: Intel Corporation 7 Series/C210 Series Chipset Family High Definition Audio Controller (rev 04)
        Subsystem: CLEVO/KAPOK Computer 7 Series/C210 Series Chipset Family High Definition Audio Controller
        Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
        Latency: 0, Cache Line Size: 64 bytes
        Interrupt: pin A routed to IRQ 36
        Region 0: Memory at f7e10000 (64-bit, non-prefetchable) [size=16K]
        Capabilities: [50] Power Management version 2
                Flags: PMEClk- DSI- D1- D2- AuxCurrent=55mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
                Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
        Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
                Address: 00000000fee003b8  Data: 0000
        Capabilities: [70] Express (v1) Root Complex Integrated Endpoint, MSI 00
                DevCap: MaxPayload 128 bytes, PhantFunc 0
                        ExtTag- RBE-
                DevCtl: Report errors: Correctable- Non-Fatal- Fatal- Unsupported-
                        RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
                        MaxPayload 128 bytes, MaxReadReq 128 bytes
                DevSta: CorrErr- UncorrErr- FatalErr- UnsuppReq- AuxPwr+ TransPend-
        Capabilities: [100 v1] Virtual Channel
                Caps:   LPEVC=0 RefClk=100ns PATEntryBits=1
                Arb:    Fixed- WRR32- WRR64- WRR128-
                Ctrl:   ArbSelect=Fixed
                Status: InProgress-
                VC0:    Caps:   PATOffset=00 MaxTimeSlots=1 RejSnoopTrans-
                        Arb:    Fixed- WRR32- WRR64- WRR128- TWRR128- WRR256-
                        Ctrl:   Enable+ ID=0 ArbSelect=Fixed TC/VC=01
                        Status: NegoPending- InProgress-
                VC1:    Caps:   PATOffset=00 MaxTimeSlots=1 RejSnoopTrans-
                        Arb:    Fixed- WRR32- WRR64- WRR128- TWRR128- WRR256-
                        Ctrl:   Enable+ ID=1 ArbSelect=Fixed TC/VC=22
                        Status: NegoPending- InProgress-
        Capabilities: [130 v1] Root Complex Link
                Desc:   PortNumber=0f ComponentID=00 EltType=Config
                Link0:  Desc:   TargetPort=00 TargetComponent=00 AssocRCRB- LinkType=MemMapped LinkValid+
                        Addr:   00000000fed1c000
        Kernel driver in use: snd_hda_intel
        Kernel modules: snd_hda_intel

And on kernel 5.4.94:
# dmesg | grep hda
[   21.307684] snd_hda_intel 0000:00:1b.0: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915])
[   21.493303] snd_hda_codec_via hdaudioC0D0: autoconfig for VT1802: line_outs=1 (0x24/0x0/0x0/0x0/0x0) type:speaker
[   21.493306] snd_hda_codec_via hdaudioC0D0:    speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
[   21.493309] snd_hda_codec_via hdaudioC0D0:    hp_outs=1 (0x25/0x0/0x0/0x0/0x0)
[   21.493310] snd_hda_codec_via hdaudioC0D0:    mono: mono_out=0x0
[   21.493312] snd_hda_codec_via hdaudioC0D0:    inputs:
[   21.493315] snd_hda_codec_via hdaudioC0D0:      Mic=0x2b
[   21.493317] snd_hda_codec_via hdaudioC0D0:      Internal Mic=0x29


Apologies if this is noise.  I haven't been able to find if 4961167bf7482944ca09a6f71263b9e47f949851 is queued up for the next stable release of 5.10.

Erich

Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[Greg KH]

On Mon, Feb 01, 2021 at 04:24:51AM +0000, Erich Ritz wrote:
> On Friday, January 29, 2021 9:17 AM, Takashi Iwai <tiwai@suse.de> wrote:
> 
> > On Fri, 29 Jan 2021 17:12:08 +0100,
> > Michael Catanzaro wrote:
> >
> > > On Fri, Jan 29, 2021 at 9:30 am, Michael Catanzaro
> > > mcatanzaro@redhat.com wrote:
> > >
> > > > OK, I found "ALSA: hda/via: Apply the workaround generically for
> > > > Clevo machines" which was just merged yesterday. So I will test
> > > > again to find out.
> > >
> > > Hi Takashi, hi Harsha,
> > > I can confirm that the problem is fixed by this commit:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4961167bf7482944ca09a6f71263b9e47f949851
> >
> > Thanks, good to hear.
> >
> > Then I think we can drop the entry from power_save_denylist in
> > hda_intel.c. Could you try that it still works with the patch below?
> >
> > thanks,
> >
> > Takashi
> >
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk power_save_denylist[] = {
> > /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 /
> > SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
> > / https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
> >
> > -   SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
> > -   /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 /
> >     SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
> >     / https://bugzilla.redhat.com/show_bug.cgi?id=1525104 /
> >     / Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev */
> 
> For me applying patch 4961167bf7482944ca09a6f71263b9e47f949851 on top of 5.10.12 fixes audio, but the above quoted patch applied to 5.10.12 does NOT fix audio.  What I mean by fixes:
> Audio works normally on 5.4.94, and on 5.10.12 with patch 4961167 applied.
> I hear no audio from the laptop speakers on 5.10.12 and 5.10.12 with the above quoted patch applied.  Opening pavucontrol shows a graphical response in the meter, but no audio is heard from the speakers.  I did not test plugging in headphones and did not test audio over HDMI.
> 
> I have a System76 Gazelle Pro 7 (gazp7).
> 
> # lspci -s "00:1b" -vv
> 00:1b.0 Audio device: Intel Corporation 7 Series/C210 Series Chipset Family High Definition Audio Controller (rev 04)
>         Subsystem: CLEVO/KAPOK Computer 7 Series/C210 Series Chipset Family High Definition Audio Controller
>         Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
>         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
>         Latency: 0, Cache Line Size: 64 bytes
>         Interrupt: pin A routed to IRQ 36
>         Region 0: Memory at f7e10000 (64-bit, non-prefetchable) [size=16K]
>         Capabilities: [50] Power Management version 2
>                 Flags: PMEClk- DSI- D1- D2- AuxCurrent=55mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
>                 Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
>         Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
>                 Address: 00000000fee003b8  Data: 0000
>         Capabilities: [70] Express (v1) Root Complex Integrated Endpoint, MSI 00
>                 DevCap: MaxPayload 128 bytes, PhantFunc 0
>                         ExtTag- RBE-
>                 DevCtl: Report errors: Correctable- Non-Fatal- Fatal- Unsupported-
>                         RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
>                         MaxPayload 128 bytes, MaxReadReq 128 bytes
>                 DevSta: CorrErr- UncorrErr- FatalErr- UnsuppReq- AuxPwr+ TransPend-
>         Capabilities: [100 v1] Virtual Channel
>                 Caps:   LPEVC=0 RefClk=100ns PATEntryBits=1
>                 Arb:    Fixed- WRR32- WRR64- WRR128-
>                 Ctrl:   ArbSelect=Fixed
>                 Status: InProgress-
>                 VC0:    Caps:   PATOffset=00 MaxTimeSlots=1 RejSnoopTrans-
>                         Arb:    Fixed- WRR32- WRR64- WRR128- TWRR128- WRR256-
>                         Ctrl:   Enable+ ID=0 ArbSelect=Fixed TC/VC=01
>                         Status: NegoPending- InProgress-
>                 VC1:    Caps:   PATOffset=00 MaxTimeSlots=1 RejSnoopTrans-
>                         Arb:    Fixed- WRR32- WRR64- WRR128- TWRR128- WRR256-
>                         Ctrl:   Enable+ ID=1 ArbSelect=Fixed TC/VC=22
>                         Status: NegoPending- InProgress-
>         Capabilities: [130 v1] Root Complex Link
>                 Desc:   PortNumber=0f ComponentID=00 EltType=Config
>                 Link0:  Desc:   TargetPort=00 TargetComponent=00 AssocRCRB- LinkType=MemMapped LinkValid+
>                         Addr:   00000000fed1c000
>         Kernel driver in use: snd_hda_intel
>         Kernel modules: snd_hda_intel
> 
> And on kernel 5.4.94:
> # dmesg | grep hda
> [   21.307684] snd_hda_intel 0000:00:1b.0: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915])
> [   21.493303] snd_hda_codec_via hdaudioC0D0: autoconfig for VT1802: line_outs=1 (0x24/0x0/0x0/0x0/0x0) type:speaker
> [   21.493306] snd_hda_codec_via hdaudioC0D0:    speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
> [   21.493309] snd_hda_codec_via hdaudioC0D0:    hp_outs=1 (0x25/0x0/0x0/0x0/0x0)
> [   21.493310] snd_hda_codec_via hdaudioC0D0:    mono: mono_out=0x0
> [   21.493312] snd_hda_codec_via hdaudioC0D0:    inputs:
> [   21.493315] snd_hda_codec_via hdaudioC0D0:      Mic=0x2b
> [   21.493317] snd_hda_codec_via hdaudioC0D0:      Internal Mic=0x29
> 
> 
> Apologies if this is noise.  I haven't been able to find if 4961167bf7482944ca09a6f71263b9e47f949851 is queued up for the next stable release of 5.10.

It will be in the next 5.10.y release.

thanks,

greg k-h