* [PATCH] fs/ext2: Fix code indentation
@ 2022-11-25 13:38 Rong Tao
2022-11-28 10:17 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Rong Tao @ 2022-11-25 13:38 UTC (permalink / raw)
To: jack; +Cc: linux-ext4, linux-kernel, Rong Tao
From: Rong Tao <rongtao@cestc.cn>
ts=4 can cause misunderstanding in code reading. It is better to replace
8 spaces with one tab.
Signed-off-by: Rong Tao <rongtao@cestc.cn>
---
fs/ext2/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 03f2af98b1b4..69c88facfe90 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1648,7 +1648,7 @@ static int __init init_ext2_fs(void)
err = init_inodecache();
if (err)
return err;
- err = register_filesystem(&ext2_fs_type);
+ err = register_filesystem(&ext2_fs_type);
if (err)
goto out;
return 0;
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/ext2: Fix code indentation
2022-11-25 13:38 [PATCH] fs/ext2: Fix code indentation Rong Tao
@ 2022-11-28 10:17 ` Jan Kara
2022-11-28 12:16 ` Rong Tao
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2022-11-28 10:17 UTC (permalink / raw)
To: Rong Tao; +Cc: jack, linux-ext4, linux-kernel, Rong Tao
On Fri 25-11-22 21:38:21, Rong Tao wrote:
> From: Rong Tao <rongtao@cestc.cn>
>
> ts=4 can cause misunderstanding in code reading. It is better to replace
> 8 spaces with one tab.
>
> Signed-off-by: Rong Tao <rongtao@cestc.cn>
Thanks for the cleanup! When doing whitespace cleanup like this, can you
please also fix another 5 lines in fs/ext2/balloc.c which have this problem
and submit it as a single patch together with this? Thanks!
Honza
> ---
> fs/ext2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 03f2af98b1b4..69c88facfe90 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1648,7 +1648,7 @@ static int __init init_ext2_fs(void)
> err = init_inodecache();
> if (err)
> return err;
> - err = register_filesystem(&ext2_fs_type);
> + err = register_filesystem(&ext2_fs_type);
> if (err)
> goto out;
> return 0;
> --
> 2.31.1
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [PATCH] fs/ext2: Fix code indentation
2022-11-28 10:17 ` Jan Kara
@ 2022-11-28 12:16 ` Rong Tao
0 siblings, 0 replies; 3+ messages in thread
From: Rong Tao @ 2022-11-28 12:16 UTC (permalink / raw)
To: jack; +Cc: jack, linux-ext4, linux-kernel, rongtao, rtoax
Thanks for your reply, i just submit a v2.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-28 12:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25 13:38 [PATCH] fs/ext2: Fix code indentation Rong Tao
2022-11-28 10:17 ` Jan Kara
2022-11-28 12:16 ` Rong Tao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).