* [PATCH] x86/ioapic: Remove unused function IO_APIC_irq_trigger()
@ 2017-05-22 23:20 Matthias Kaehlcke
2017-05-23 8:40 ` [tip:irq/core] x86/ioapic: Remove unused IO_APIC_irq_trigger() function tip-bot for Matthias Kaehlcke
2017-05-26 12:57 ` [tip:x86/apic] " tip-bot for Matthias Kaehlcke
0 siblings, 2 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2017-05-22 23:20 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H . Peter Anvin
Cc: x86, linux-kernel, Douglas Anderson, Andrew Morton, Matthias Kaehlcke
The function isn't used since commit 5ad274d41c1b ("x86/irq: Remove
unused old IOAPIC irqdomain interfaces"). Removing it fixes the
following warning when building with clang:
arch/x86/kernel/apic/io_apic.c:1219:19: error: unused function
'IO_APIC_irq_trigger' [-Werror,-Wunused-function]
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Andrew, this is a practical example of clangs 'unused-function' warning
on static inline functions being useful.
arch/x86/kernel/apic/io_apic.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 347bb9f65737..247880fc29f9 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1200,28 +1200,6 @@ EXPORT_SYMBOL(IO_APIC_get_PCI_irq_vector);
static struct irq_chip ioapic_chip, ioapic_ir_chip;
-#ifdef CONFIG_X86_32
-static inline int IO_APIC_irq_trigger(int irq)
-{
- int apic, idx, pin;
-
- for_each_ioapic_pin(apic, pin) {
- idx = find_irq_entry(apic, pin, mp_INT);
- if ((idx != -1) && (irq == pin_2_irq(idx, apic, pin, 0)))
- return irq_trigger(idx);
- }
- /*
- * nonexistent IRQs are edge default
- */
- return 0;
-}
-#else
-static inline int IO_APIC_irq_trigger(int irq)
-{
- return 1;
-}
-#endif
-
static void __init setup_IO_APIC_irqs(void)
{
unsigned int ioapic, pin;
--
2.13.0.303.g4ebf302169-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:irq/core] x86/ioapic: Remove unused IO_APIC_irq_trigger() function
2017-05-22 23:20 [PATCH] x86/ioapic: Remove unused function IO_APIC_irq_trigger() Matthias Kaehlcke
@ 2017-05-23 8:40 ` tip-bot for Matthias Kaehlcke
2017-05-26 12:57 ` [tip:x86/apic] " tip-bot for Matthias Kaehlcke
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Matthias Kaehlcke @ 2017-05-23 8:40 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, mingo, mka, tglx, hpa, akpm, dianders, linux-kernel, torvalds
Commit-ID: b9de5068b2d7c22de1bb89d62a7119a6b8dff88f
Gitweb: http://git.kernel.org/tip/b9de5068b2d7c22de1bb89d62a7119a6b8dff88f
Author: Matthias Kaehlcke <mka@chromium.org>
AuthorDate: Mon, 22 May 2017 16:20:35 -0700
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 23 May 2017 09:06:32 +0200
x86/ioapic: Remove unused IO_APIC_irq_trigger() function
The function isn't used since commit:
5ad274d41c1b ("x86/irq: Remove unused old IOAPIC irqdomain interfaces")
Removing it fixes the following warning when building with clang:
arch/x86/kernel/apic/io_apic.c:1219:19: error: unused function
'IO_APIC_irq_trigger' [-Werror,-Wunused-function]
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170522232035.187985-1-mka@chromium.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/apic/io_apic.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 347bb9f..247880f 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1200,28 +1200,6 @@ EXPORT_SYMBOL(IO_APIC_get_PCI_irq_vector);
static struct irq_chip ioapic_chip, ioapic_ir_chip;
-#ifdef CONFIG_X86_32
-static inline int IO_APIC_irq_trigger(int irq)
-{
- int apic, idx, pin;
-
- for_each_ioapic_pin(apic, pin) {
- idx = find_irq_entry(apic, pin, mp_INT);
- if ((idx != -1) && (irq == pin_2_irq(idx, apic, pin, 0)))
- return irq_trigger(idx);
- }
- /*
- * nonexistent IRQs are edge default
- */
- return 0;
-}
-#else
-static inline int IO_APIC_irq_trigger(int irq)
-{
- return 1;
-}
-#endif
-
static void __init setup_IO_APIC_irqs(void)
{
unsigned int ioapic, pin;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:x86/apic] x86/ioapic: Remove unused IO_APIC_irq_trigger() function
2017-05-22 23:20 [PATCH] x86/ioapic: Remove unused function IO_APIC_irq_trigger() Matthias Kaehlcke
2017-05-23 8:40 ` [tip:irq/core] x86/ioapic: Remove unused IO_APIC_irq_trigger() function tip-bot for Matthias Kaehlcke
@ 2017-05-26 12:57 ` tip-bot for Matthias Kaehlcke
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Matthias Kaehlcke @ 2017-05-26 12:57 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, dianders, peterz, akpm, torvalds, linux-kernel, hpa, mka, tglx
Commit-ID: 9df8109fd7969b94ed2332ae828e0b08ae8cbf9a
Gitweb: http://git.kernel.org/tip/9df8109fd7969b94ed2332ae828e0b08ae8cbf9a
Author: Matthias Kaehlcke <mka@chromium.org>
AuthorDate: Mon, 22 May 2017 16:20:35 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 26 May 2017 14:37:41 +0200
x86/ioapic: Remove unused IO_APIC_irq_trigger() function
The function isn't used since commit:
5ad274d41c1b ("x86/irq: Remove unused old IOAPIC irqdomain interfaces")
Removing it fixes the following warning when building with clang:
arch/x86/kernel/apic/io_apic.c:1219:19: error: unused function
'IO_APIC_irq_trigger' [-Werror,-Wunused-function]
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170522232035.187985-1-mka@chromium.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/apic/io_apic.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 347bb9f..247880f 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1200,28 +1200,6 @@ EXPORT_SYMBOL(IO_APIC_get_PCI_irq_vector);
static struct irq_chip ioapic_chip, ioapic_ir_chip;
-#ifdef CONFIG_X86_32
-static inline int IO_APIC_irq_trigger(int irq)
-{
- int apic, idx, pin;
-
- for_each_ioapic_pin(apic, pin) {
- idx = find_irq_entry(apic, pin, mp_INT);
- if ((idx != -1) && (irq == pin_2_irq(idx, apic, pin, 0)))
- return irq_trigger(idx);
- }
- /*
- * nonexistent IRQs are edge default
- */
- return 0;
-}
-#else
-static inline int IO_APIC_irq_trigger(int irq)
-{
- return 1;
-}
-#endif
-
static void __init setup_IO_APIC_irqs(void)
{
unsigned int ioapic, pin;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-26 13:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-22 23:20 [PATCH] x86/ioapic: Remove unused function IO_APIC_irq_trigger() Matthias Kaehlcke
2017-05-23 8:40 ` [tip:irq/core] x86/ioapic: Remove unused IO_APIC_irq_trigger() function tip-bot for Matthias Kaehlcke
2017-05-26 12:57 ` [tip:x86/apic] " tip-bot for Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).