From: Jeff Moyer <jmoyer@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <jaxboe@fusionio.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm\@kvack.org" <linux-mm@kvack.org>,
Zach Brown <zab@redhat.com>, Peter Zijlstra <pzijlstr@redhat.com>,
Ingo <mingo@redhat.com>
Subject: Re: [patch,v2] bdi: add a user-tunable cpu_list for the bdi flusher threads
Date: Thu, 06 Dec 2012 13:08:18 -0500 [thread overview]
Message-ID: <x494njzxdd9.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20121206180150.GQ19802@htj.dyndns.org> (Tejun Heo's message of "Thu, 6 Dec 2012 10:01:50 -0800")
Tejun Heo <tj@kernel.org> writes:
> Hmmm... cpu binding usually is done by kthread_bind() or explicit
> set_cpus_allowed_ptr() by the kthread itself. The node part of the
> API was added later because there was no way to control where the
> stack is allocated and we often ended up with kthreads which are bound
> to a CPU with stack on a remote node.
>
> I don't know. @node usually controls memory allocation and it could
> be surprising for it to control cpu binding, especially because most
> kthreads which are bound to CPU[s] require explicit affinity
> management as CPUs go up and down. I don't know. Maybe I'm just too
> used to the existing interface.
OK, I can understand this line of reasoning.
> As for the original patch, I think it's a bit too much to expose to
> userland. It's probably a good idea to bind the flusher to the local
> node but do we really need to expose an interface to let userland
> control the affinity directly? Do we actually have a use case at
> hand?
Yeah, folks pinning realtime processes to a particular cpu don't want
the flusher threads interfering with their latency. I don't have any
performance numbers on hand to convince you of the benefit, though.
Cheers,
Jeff
next prev parent reply other threads:[~2012-12-06 18:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 18:53 [patch,v2] bdi: add a user-tunable cpu_list for the bdi flusher threads Jeff Moyer
2012-12-04 2:34 ` Dave Chinner
2012-12-04 14:42 ` Jeff Moyer
2012-12-04 20:35 ` Dave Chinner
2012-12-04 20:14 ` Jens Axboe
2012-12-04 20:23 ` Jeff Moyer
2012-12-04 20:27 ` Jens Axboe
2012-12-04 22:26 ` Jeff Moyer
2012-12-05 7:43 ` Jens Axboe
2012-12-06 18:01 ` Tejun Heo
2012-12-06 18:08 ` Jeff Moyer [this message]
2012-12-06 18:13 ` Tejun Heo
2012-12-06 18:19 ` Jens Axboe
2012-12-06 18:22 ` Tejun Heo
2012-12-06 18:33 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x494njzxdd9.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=pzijlstr@redhat.com \
--cc=tj@kernel.org \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).