From: Jeff Moyer <jmoyer@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <jaxboe@fusionio.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm\@kvack.org" <linux-mm@kvack.org>,
Zach Brown <zab@redhat.com>, Peter Zijlstra <pzijlstr@redhat.com>,
Ingo <mingo@redhat.com>
Subject: Re: [patch,v2] bdi: add a user-tunable cpu_list for the bdi flusher threads
Date: Thu, 06 Dec 2012 13:33:57 -0500 [thread overview]
Message-ID: <x49zk1rvxm2.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20121206182239.GS19802@htj.dyndns.org> (Tejun Heo's message of "Thu, 6 Dec 2012 10:22:39 -0800")
Tejun Heo <tj@kernel.org> writes:
> Hello, Jens.
>
> On Thu, Dec 06, 2012 at 07:19:34PM +0100, Jens Axboe wrote:
>> We need to expose it. Once the binding is set from the kernel side on a
>> kernel thread, it can't be modified.
>
> That's only if kthread_bind() is used. Caling set_cpus_allowed_ptr()
> doesn't set PF_THREAD_BOUND and userland can adjust affinity like any
> other tasks.
>
>> Binding either for performance reasons or for ensuring that we
>> explicitly don't run in some places is a very useful feature.
>
> Sure, but I think this is too specific. Something more generic would
> be much better. It can be as simple as generating a uevent.
I'm in favor of a more general approach. For now, I'm still going to
push a patch that at least binds to the proper numa node. I'll post
that after I've tested it.
Cheers,
Jeff
prev parent reply other threads:[~2012-12-06 18:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 18:53 [patch,v2] bdi: add a user-tunable cpu_list for the bdi flusher threads Jeff Moyer
2012-12-04 2:34 ` Dave Chinner
2012-12-04 14:42 ` Jeff Moyer
2012-12-04 20:35 ` Dave Chinner
2012-12-04 20:14 ` Jens Axboe
2012-12-04 20:23 ` Jeff Moyer
2012-12-04 20:27 ` Jens Axboe
2012-12-04 22:26 ` Jeff Moyer
2012-12-05 7:43 ` Jens Axboe
2012-12-06 18:01 ` Tejun Heo
2012-12-06 18:08 ` Jeff Moyer
2012-12-06 18:13 ` Tejun Heo
2012-12-06 18:19 ` Jens Axboe
2012-12-06 18:22 ` Tejun Heo
2012-12-06 18:33 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49zk1rvxm2.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=pzijlstr@redhat.com \
--cc=tj@kernel.org \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).