[PATCH] scsi:ufs: remove duplicate include in ufshcd

[PATCH] scsi:ufs: remove duplicate include in ufshcd

[menglong8.dong]

From: Zhang Yunkai <zhang.yunkai@zte.com.cn>

'blkdev.h' included in 'ufshcd.c' is duplicated.
It is also included in the 18th line.

Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
 drivers/scsi/ufs/ufshcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 77161750c9fb..9a564b6fd092 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -24,7 +24,6 @@
 #include "ufs_bsg.h"
 #include "ufshcd-crypto.h"
 #include <asm/unaligned.h>
-#include <linux/blkdev.h>
 
 #define CREATE_TRACE_POINTS
 #include <trace/events/ufs.h>
-- 
2.25.1

Re: [PATCH] scsi:ufs: remove duplicate include in ufshcd

[Bean Huo]

On Sat, 2021-03-06 at 03:47 -0800, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> 
> 
> 
> 'blkdev.h' included in 'ufshcd.c' is duplicated.
> 
> It is also included in the 18th line.
> 
> 
> 
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
Reviewed-by: Bean Huo <beanhuo@micron.com>

Re: [PATCH] scsi:ufs: remove duplicate include in ufshcd

[Martin K. Petersen]

> 'blkdev.h' included in 'ufshcd.c' is duplicated.  It is also included
> in the 18th line.

Applied to 5.13/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi:ufs: remove duplicate include in ufshcd

[Martin K. Petersen]

On Sat, 6 Mar 2021 03:47:06 -0800, menglong8.dong@gmail.com wrote:

> 'blkdev.h' included in 'ufshcd.c' is duplicated.
> It is also included in the 18th line.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi:ufs: remove duplicate include in ufshcd
      https://git.kernel.org/mkp/scsi/c/b4388e3db56a

-- 
Martin K. Petersen	Oracle Linux Engineering

[PATCH] scsi: ufs: Remove duplicate include in ufshcd

[Wan Jiabing]

Fix following checkincludes warning:
drivers/scsi/ufs/ufshcd.c: linux/nls.h is included more than once.

The include is in line 14. Remove the duplicated here.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/scsi/ufs/ufshcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1b87f26b5193..73b3dfffabaa 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -20,7 +20,6 @@
 #include <linux/delay.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
-#include <linux/nls.h>
 #include <linux/regulator/consumer.h>
 #include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_dbg.h>
-- 
2.35.3

RE: [PATCH] scsi: ufs: Remove duplicate include in ufshcd

[Avri Altman]

 
> Fix following checkincludes warning:
> drivers/scsi/ufs/ufshcd.c: linux/nls.h is included more than once.
> 
> The include is in line 14. Remove the duplicated here.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

Re: [PATCH] scsi: ufs: Remove duplicate include in ufshcd

[Martin K. Petersen]

Wan,

> Fix following checkincludes warning:
> drivers/scsi/ufs/ufshcd.c: linux/nls.h is included more than once.
>
> The include is in line 14. Remove the duplicated here.

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Remove duplicate include in ufshcd

[Martin K. Petersen]

On Tue, 26 Apr 2022 18:45:07 +0800, Wan Jiabing wrote:

> Fix following checkincludes warning:
> drivers/scsi/ufs/ufshcd.c: linux/nls.h is included more than once.
> 
> The include is in line 14. Remove the duplicated here.
> 
> 

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: ufs: Remove duplicate include in ufshcd
      https://git.kernel.org/mkp/scsi/c/8ad8edd2fbae

-- 
Martin K. Petersen	Oracle Linux Engineering