[PATCH] scsi: aacraid: Fix missing break in switch statement

[PATCH] scsi: aacraid: Fix missing break in switch statement

[Gustavo A. R. Silva]

Add missing break statement and fix identation issue.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: 9cb62fa24e0d ("aacraid: Log firmware AIF messages")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/scsi/aacraid/commsup.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 0bdc6b0f725f..e67e032936ef 100644
--- a/drivers/scsi/aacraid/commsup.c
+++ b/drivers/scsi/aacraid/commsup.c
@@ -1303,8 +1303,9 @@ static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr)
 				  ADD : DELETE;
 				break;
 			}
-			case AifBuManagerEvent:
-				aac_handle_aif_bu(dev, aifcmd);
+			break;
+		case AifBuManagerEvent:
+			aac_handle_aif_bu(dev, aifcmd);
 			break;
 		}
 
-- 
2.20.1

Re: [PATCH] scsi: aacraid: Fix missing break in switch statement

[Martin K. Petersen]

Gustavo,

> Add missing break statement and fix identation issue.

So much bad indentation in this driver. Tried various tab widths and it
is still all over the place.

Anyway. After staring at the firmware header I have convinced myself
that your fix is correct. Applied to 5.1/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: aacraid: Fix missing break in switch statement

[Gustavo A. R. Silva]

On 2/27/19 8:33 AM, Martin K. Petersen wrote:
> 
> Gustavo,
> 
>> Add missing break statement and fix identation issue.
> 
> So much bad indentation in this driver. Tried various tab widths and it
> is still all over the place.
> 
> Anyway. After staring at the firmware header I have convinced myself
> that your fix is correct. Applied to 5.1/scsi-queue.
> 

That's great.

Thanks, Martin.

--
Gustavo