[PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default

[PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default

[Geert Uytterhoeven]

The default was changed, but the help text was not updated.

Fix grammar (s/the option/this option/) while at it.

Fixes: d5038a13eca72fb2 ("scsi: core: switch to scsi-mq by default")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/scsi/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 8fc851a9e1162a56..a0491e11bd359499 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -53,11 +53,11 @@ config SCSI_MQ_DEFAULT
 	depends on SCSI
 	---help---
 	  This option enables the new blk-mq based I/O path for SCSI
-	  devices by default.  With the option the scsi_mod.use_blk_mq
+	  devices by default.  With this option the scsi_mod.use_blk_mq
 	  module/boot option defaults to Y, without it to N, but it can
 	  still be overridden either way.
 
-	  If unsure say N.
+	  If unsure say Y.
 
 config SCSI_PROC_FS
 	bool "legacy /proc/scsi/ support"
-- 
2.17.1

Re: [PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default

[John Garry]

On 21/08/2018 12:44, Geert Uytterhoeven wrote:
> The default was changed, but the help text was not updated.
>
> Fix grammar (s/the option/this option/) while at it.
>
> Fixes: d5038a13eca72fb2 ("scsi: core: switch to scsi-mq by default")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/scsi/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 8fc851a9e1162a56..a0491e11bd359499 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -53,11 +53,11 @@ config SCSI_MQ_DEFAULT
>  	depends on SCSI
>  	---help---
>  	  This option enables the new blk-mq based I/O path for SCSI

It's arguably not 'new' either :)

> -	  devices by default.  With the option the scsi_mod.use_blk_mq
> +	  devices by default.  With this option the scsi_mod.use_blk_mq
>  	  module/boot option defaults to Y, without it to N, but it can
>  	  still be overridden either way.
>
> -	  If unsure say N.
> +	  If unsure say Y.
>
>  config SCSI_PROC_FS
>  	bool "legacy /proc/scsi/ support"
>

Re: [PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default

[Ming Lei]

On Tue, Aug 21, 2018 at 01:44:07PM +0200, Geert Uytterhoeven wrote:
> The default was changed, but the help text was not updated.
> 
> Fix grammar (s/the option/this option/) while at it.
> 
> Fixes: d5038a13eca72fb2 ("scsi: core: switch to scsi-mq by default")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/scsi/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 8fc851a9e1162a56..a0491e11bd359499 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -53,11 +53,11 @@ config SCSI_MQ_DEFAULT
>  	depends on SCSI
>  	---help---
>  	  This option enables the new blk-mq based I/O path for SCSI
> -	  devices by default.  With the option the scsi_mod.use_blk_mq
> +	  devices by default.  With this option the scsi_mod.use_blk_mq
>  	  module/boot option defaults to Y, without it to N, but it can
>  	  still be overridden either way.
>  
> -	  If unsure say N.
> +	  If unsure say Y.
>  
>  config SCSI_PROC_FS
>  	bool "legacy /proc/scsi/ support"
> -- 
> 2.17.1
> 

Looks fine,

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming

Re: [PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default

[Martin K. Petersen]

Geert,

> The default was changed, but the help text was not updated.

Applied to 4.19/scsi-fixes, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering