Re: [PATCH 05/15] nfc: pn533: drop unneeded debug prints

Re: [PATCH 05/15] nfc: pn533: drop unneeded debug prints

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4315 bytes --]

Hi Krzysztof,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on next-20210907]
[cannot apply to v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Krzysztof-Kozlowski/nfc-minor-printk-cleanup/20210907-202109
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4b93c544e90e2b28326182d31ee008eb80e02074
config: hexagon-buildonly-randconfig-r002-20210906 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9c476172b93367d2cb88d7d3f4b1b5b456fa6020)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b50b554a6d58be6064a8ea94dd852ca55f8433ee
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Krzysztof-Kozlowski/nfc-minor-printk-cleanup/20210907-202109
        git checkout b50b554a6d58be6064a8ea94dd852ca55f8433ee
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/nfc/pn533/i2c.c:131:21: error: variable 'client' set but not used [-Werror,-Wunused-but-set-variable]
           struct i2c_client *client;
                              ^
   1 error generated.


vim +/client +131 drivers/nfc/pn533/i2c.c

dd7bedcd2673e4 Michael Thalmeier 2016-03-25  127  
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  128  static irqreturn_t pn533_i2c_irq_thread_fn(int irq, void *data)
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  129  {
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  130  	struct pn533_i2c_phy *phy = data;
dd7bedcd2673e4 Michael Thalmeier 2016-03-25 @131  	struct i2c_client *client;
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  132  	struct sk_buff *skb = NULL;
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  133  	int r;
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  134  
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  135  	if (!phy || irq != phy->i2c_dev->irq) {
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  136  		WARN_ON_ONCE(1);
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  137  		return IRQ_NONE;
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  138  	}
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  139  
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  140  	client = phy->i2c_dev;
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  141  
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  142  	if (phy->hard_fault != 0)
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  143  		return IRQ_HANDLED;
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  144  
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  145  	r = pn533_i2c_read(phy, &skb);
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  146  	if (r == -EREMOTEIO) {
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  147  		phy->hard_fault = r;
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  148  
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  149  		pn533_recv_frame(phy->priv, NULL, -EREMOTEIO);
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  150  
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  151  		return IRQ_HANDLED;
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  152  	} else if ((r == -ENOMEM) || (r == -EBADMSG) || (r == -EBUSY)) {
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  153  		return IRQ_HANDLED;
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  154  	}
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  155  
30f98489f54e02 Michael Thalmeier 2016-04-21  156  	if (!phy->aborted)
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  157  		pn533_recv_frame(phy->priv, skb, 0);
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  158  
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  159  	return IRQ_HANDLED;
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  160  }
dd7bedcd2673e4 Michael Thalmeier 2016-03-25  161  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33675 bytes --]