Re: [PATCH v4 3/6] uapi: futex: Add a futex syscall

Re: [PATCH v4 3/6] uapi: futex: Add a futex syscall

[kernel test robot]

Hi Alistair,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/locking/core]
[also build test ERROR on linux/master soc/for-next linus/master v5.16-rc3 next-20211202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alistair-Francis/perf-bench-futex-Add-support-for-32-bit-systems-with-64-bit-time_t/20211202-192015
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 4e0d84634445ed550498d613a49ea8f6cfa5e66c
config: x86_64-randconfig-a002-20211202 (https://download.01.org/0day-ci/archive/20211203/202112030822.dtjQPM06-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b553297ef3ee4dc2119d5429adf3072e90fac38)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/710fc0b1a255e93e04efbaccf76f6445db51ff1f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alistair-Francis/perf-bench-futex-Add-support-for-32-bit-systems-with-64-bit-time_t/20211202-192015
        git checkout 710fc0b1a255e93e04efbaccf76f6445db51ff1f
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from <built-in>:1:
   ./usr/include/linux/futex_syscall.h:33:16: warning: declaration of 'struct timespec' will not be visible outside of this function [-Wvisibility]
                         struct timespec *timeout, __volatile__ uint32_t *uaddr2, int val3)
                                ^
>> ./usr/include/linux/futex_syscall.h:45:12: error: invalid application of 'sizeof' to an incomplete type 'struct timespec'
           if (sizeof(*timeout) == sizeof(struct __kernel_old_timespec))
                     ^~~~~~~~~~
   ./usr/include/linux/futex_syscall.h:33:16: note: forward declaration of 'struct timespec'
                         struct timespec *timeout, __volatile__ uint32_t *uaddr2, int val3)
                                ^
>> ./usr/include/linux/futex_syscall.h:46:10: error: implicit declaration of function 'syscall' [-Werror,-Wimplicit-function-declaration]
                   return syscall(__NR_futex, uaddr, op, val, timeout, uaddr2, val3);
                          ^
>> ./usr/include/linux/futex_syscall.h:48:24: error: incomplete definition of type 'struct timespec'
           if (timeout && timeout->tv_sec == (long)timeout->tv_sec) {
                          ~~~~~~~^
   ./usr/include/linux/futex_syscall.h:33:16: note: forward declaration of 'struct timespec'
                         struct timespec *timeout, __volatile__ uint32_t *uaddr2, int val3)
                                ^
   ./usr/include/linux/futex_syscall.h:48:49: error: incomplete definition of type 'struct timespec'
           if (timeout && timeout->tv_sec == (long)timeout->tv_sec) {
                                                   ~~~~~~~^
   ./usr/include/linux/futex_syscall.h:33:16: note: forward declaration of 'struct timespec'
                         struct timespec *timeout, __volatile__ uint32_t *uaddr2, int val3)
                                ^
   ./usr/include/linux/futex_syscall.h:51:44: error: incomplete definition of type 'struct timespec'
                   ts_old.tv_sec = (__kernel_long_t) timeout->tv_sec;
                                                     ~~~~~~~^
   ./usr/include/linux/futex_syscall.h:33:16: note: forward declaration of 'struct timespec'
                         struct timespec *timeout, __volatile__ uint32_t *uaddr2, int val3)
                                ^
   ./usr/include/linux/futex_syscall.h:52:45: error: incomplete definition of type 'struct timespec'
                   ts_old.tv_nsec = (__kernel_long_t) timeout->tv_nsec;
                                                      ~~~~~~~^
   ./usr/include/linux/futex_syscall.h:33:16: note: forward declaration of 'struct timespec'
                         struct timespec *timeout, __volatile__ uint32_t *uaddr2, int val3)
                                ^
   ./usr/include/linux/futex_syscall.h:85:9: error: implicit declaration of function 'syscall' [-Werror,-Wimplicit-function-declaration]
           return syscall(__NR_futex, uaddr, op, val, nr_requeue, uaddr2, val3);
                  ^
   1 warning and 7 errors generated.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org