Re: [Intel-gfx] [RFC PATCH v2 2/2] Fix per client busyness locking

Re: [Intel-gfx] [RFC PATCH v2 2/2] Fix per client busyness locking

[kernel test robot]

Hi Ashutosh,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on drm-tip/drm-tip]

url:    https://github.com/intel-lab-lkp/linux/commits/Ashutosh-Dixit/i915-pmu-Wire-GuC-backend-to-per-client-busyness/20220902-075534
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-randconfig-a004 (https://download.01.org/0day-ci/archive/20220902/202209021008.CdocRSC0-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b1db15edb2416229fdde749425de6a6ae7a4b94a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ashutosh-Dixit/i915-pmu-Wire-GuC-backend-to-per-client-busyness/20220902-075534
        git checkout b1db15edb2416229fdde749425de6a6ae7a4b94a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:1512:5: warning: no previous prototype for function 'guc_context_update_stats' [-Wmissing-prototypes]
   u64 guc_context_update_stats(struct intel_context *ce, bool pin)
       ^
   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:1512:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   u64 guc_context_update_stats(struct intel_context *ce, bool pin)
   ^
   static 
   1 warning generated.


vim +/guc_context_update_stats +1512 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

  1511	
> 1512	u64 guc_context_update_stats(struct intel_context *ce, bool pin)
  1513	{
  1514		struct intel_guc *guc = ce_to_guc(ce);
  1515		unsigned long flags;
  1516		u64 ret;
  1517	
  1518		if (pin) {
  1519			intel_context_pin(ce);
  1520		} else {
  1521			/* Return previously computed value */
  1522			spin_lock_irqsave(&guc->timestamp.lock, flags);
  1523			ret = ce->stats.runtime.total + ce->stats.active;
  1524			spin_unlock_irqrestore(&guc->timestamp.lock, flags);
  1525			return ret;
  1526		}
  1527	
  1528		spin_lock_irqsave(&guc->timestamp.lock, flags);
  1529		ret = __guc_context_update_stats(ce);
  1530		spin_unlock_irqrestore(&guc->timestamp.lock, flags);
  1531	
  1532		intel_context_unpin(ce);
  1533		return ret;
  1534	}
  1535	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp