Re: [RFC] proc: report open files as size in stat() for /proc/pid/fd

Re: [RFC] proc: report open files as size in stat() for /proc/pid/fd

[kernel test robot]

Hi Ivan,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on linus/master v6.0-rc5 next-20220916]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ivan-Babrou/proc-report-open-files-as-size-in-stat-for-proc-pid-fd/20220917-071056
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: hexagon-randconfig-r041-20220916 (https://download.01.org/0day-ci/archive/20220917/202209171129.dnkI0XiE-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/58f6f7e4082a88ddcb4b732d386f9a4b0e1b03b4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ivan-Babrou/proc-report-open-files-as-size-in-stat-for-proc-pid-fd/20220917-071056
        git checkout 58f6f7e4082a88ddcb4b732d386f9a4b0e1b03b4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/proc/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/proc/fd.c:345:5: warning: no previous prototype for function 'proc_fd_getattr' [-Wmissing-prototypes]
   int proc_fd_getattr(struct user_namespace *mnt_userns,
       ^
   fs/proc/fd.c:345:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int proc_fd_getattr(struct user_namespace *mnt_userns,
   ^
   static 
   1 warning generated.


vim +/proc_fd_getattr +345 fs/proc/fd.c

   344	
 > 345	int proc_fd_getattr(struct user_namespace *mnt_userns,
   346				const struct path *path, struct kstat *stat,
   347				u32 request_mask, unsigned int query_flags)
   348	{
   349		struct inode *inode = d_inode(path->dentry);
   350		struct proc_dir_entry *de = PDE(inode);
   351	
   352		if (de) {
   353			nlink_t nlink = READ_ONCE(de->nlink);
   354	
   355			if (nlink > 0)
   356				set_nlink(inode, nlink);
   357		}
   358	
   359		generic_fillattr(&init_user_ns, inode, stat);
   360	
   361		/* If it's a directory, put the number of open fds there */
   362		if (S_ISDIR(inode->i_mode))
   363			stat->size = proc_readfd_count(inode);
   364	
   365		return 0;
   366	}
   367	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp