Re: [RFCv8 PATCH net-next 54/55] treewide: use netdev_features_copy helpers

Re: [RFCv8 PATCH net-next 54/55] treewide: use netdev_features_copy helpers

[kernel test robot]

Hi Jian,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Jian-Shen/net-extend-the-type-of-netdev_features_t-to-bitmap/20220918-175512
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 44a8535fb87c5503ce01121278ac3058eef701ec
config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20220918/202209181949.aWxvqPnW-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/ffa4c285bdcbd69824e5b38b1d3e98b905fc17d8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jian-Shen/net-extend-the-type-of-netdev_features_t-to-bitmap/20220918-175512
        git checkout ffa4c285bdcbd69824e5b38b1d3e98b905fc17d8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/bonding/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/net/bonding/bond_main.c:38:
   In file included from include/linux/filter.h:20:
   In file included from include/linux/if_vlan.h:10:
   include/linux/netdevice.h:4949:6: warning: variable 'feature' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
           if (classic_gso_type)
               ^~~~~~~~~~~~~~~~
   include/linux/netdevice.h:4955:22: note: uninitialized use occurs here
           return (*features & feature) == feature;
                               ^~~~~~~
   include/linux/netdevice.h:4949:2: note: remove the 'if' if its condition is always true
           if (classic_gso_type)
           ^~~~~~~~~~~~~~~~~~~~~
   include/linux/netdevice.h:4927:27: note: initialize the variable 'feature' to silence this warning
           netdev_features_t feature;
                                    ^
                                     = 0
>> drivers/net/bonding/bond_main.c:1453:23: error: use of undeclared identifier 'xfrm_features'
           netdev_features_copy(xfrm_features, BOND_XFRM_FEATURES);
                                ^
   1 warning and 1 error generated.


vim +/xfrm_features +1453 drivers/net/bonding/bond_main.c

  1431	
  1432	static void bond_compute_features(struct bonding *bond)
  1433	{
  1434		unsigned int dst_release_flag = IFF_XMIT_DST_RELEASE |
  1435						IFF_XMIT_DST_RELEASE_PERM;
  1436		netdev_features_t vlan_features;
  1437		netdev_features_t enc_features;
  1438	#ifdef CONFIG_XFRM_OFFLOAD
  1439		netdev_features_t xfrm_features;
  1440	#endif /* CONFIG_XFRM_OFFLOAD */
  1441		netdev_features_t mpls_features;
  1442		struct net_device *bond_dev = bond->dev;
  1443		struct list_head *iter;
  1444		struct slave *slave;
  1445		unsigned short max_hard_header_len = ETH_HLEN;
  1446		unsigned int tso_max_size = TSO_MAX_SIZE;
  1447		u16 tso_max_segs = TSO_MAX_SEGS;
  1448	
  1449		if (!bond_has_slaves(bond))
  1450			goto done;
  1451		netdev_features_copy(vlan_features, BOND_VLAN_FEATURES);
  1452		netdev_features_copy(enc_features, BOND_ENC_FEATURES);
> 1453		netdev_features_copy(xfrm_features, BOND_XFRM_FEATURES);
  1454		netdev_features_copy(mpls_features, BOND_MPLS_FEATURES);
  1455		netdev_features_mask(vlan_features, NETIF_F_ALL_FOR_ALL);
  1456		netdev_features_mask(mpls_features, NETIF_F_ALL_FOR_ALL);
  1457	
  1458		bond_for_each_slave(bond, slave, iter) {
  1459			netdev_increment_features(&vlan_features, &vlan_features,
  1460						  &slave->dev->vlan_features,
  1461						  &BOND_VLAN_FEATURES);
  1462	
  1463			netdev_increment_features(&enc_features, &enc_features,
  1464						  &slave->dev->hw_enc_features,
  1465						  &BOND_ENC_FEATURES);
  1466	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp