* [PATCH] dmaengine: ti: edma: remove unused edma_and function
@ 2023-03-20 23:12 Tom Rix
2023-03-31 12:28 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-20 23:12 UTC (permalink / raw)
To: peter.ujfalusi, vkoul, nathan, ndesaulniers
Cc: dmaengine, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/dma/ti/edma.c:321:20: error: unused function
'edma_and' [-Werror,-Wunused-function]
static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and)
^
This function is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/dma/ti/edma.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
index fa06d7e6d8e3..9ea91c640c32 100644
--- a/drivers/dma/ti/edma.c
+++ b/drivers/dma/ti/edma.c
@@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and,
edma_write(ecc, offset, val);
}
-static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and)
-{
- unsigned val = edma_read(ecc, offset);
-
- val &= and;
- edma_write(ecc, offset, val);
-}
-
static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or)
{
unsigned val = edma_read(ecc, offset);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: ti: edma: remove unused edma_and function
2023-03-20 23:12 [PATCH] dmaengine: ti: edma: remove unused edma_and function Tom Rix
@ 2023-03-31 12:28 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2023-03-31 12:28 UTC (permalink / raw)
To: Tom Rix
Cc: peter.ujfalusi, nathan, ndesaulniers, dmaengine, linux-kernel, llvm
On 20-03-23, 19:12, Tom Rix wrote:
> clang with W=1 reports
> drivers/dma/ti/edma.c:321:20: error: unused function
> 'edma_and' [-Werror,-Wunused-function]
> static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and)
> ^
> This function is not used, so remove it.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-31 12:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 23:12 [PATCH] dmaengine: ti: edma: remove unused edma_and function Tom Rix
2023-03-31 12:28 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).