* Re: [PATCH v2] Jitter RNG - Permanent and Intermittent health errors
[not found] <2671913.mvXUDI8C0e@positron.chronox.de>
@ 2023-03-24 16:03 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-03-24 16:03 UTC (permalink / raw)
To: Stephan Müller, linux-crypto, herbert; +Cc: llvm, oe-kbuild-all
Hi Stephan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on herbert-cryptodev-2.6/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Stephan-M-ller/Jitter-RNG-Permanent-and-Intermittent-health-errors/20230324-203251
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link: https://lore.kernel.org/r/2671913.mvXUDI8C0e%40positron.chronox.de
patch subject: [PATCH v2] Jitter RNG - Permanent and Intermittent health errors
config: hexagon-randconfig-r045-20230322 (https://download.01.org/0day-ci/archive/20230324/202303242344.goIWq8zw-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/ce362096eea814a823f7bf4aef00f8680aab9056
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Stephan-M-ller/Jitter-RNG-Permanent-and-Intermittent-health-errors/20230324-203251
git checkout ce362096eea814a823f7bf4aef00f8680aab9056
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303242344.goIWq8zw-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> crypto/jitterentropy-kcapi.c:165:1: warning: unused label 'out' [-Wunused-label]
out:
^~~~
1 warning generated.
vim +/out +165 crypto/jitterentropy-kcapi.c
dfc9fa91938bd0 Stephan Mueller 2015-06-23 131
dfc9fa91938bd0 Stephan Mueller 2015-06-23 132 static int jent_kcapi_random(struct crypto_rng *tfm,
dfc9fa91938bd0 Stephan Mueller 2015-06-23 133 const u8 *src, unsigned int slen,
dfc9fa91938bd0 Stephan Mueller 2015-06-23 134 u8 *rdata, unsigned int dlen)
dfc9fa91938bd0 Stephan Mueller 2015-06-23 135 {
dfc9fa91938bd0 Stephan Mueller 2015-06-23 136 struct jitterentropy *rng = crypto_rng_ctx(tfm);
dfc9fa91938bd0 Stephan Mueller 2015-06-23 137 int ret = 0;
dfc9fa91938bd0 Stephan Mueller 2015-06-23 138
dfc9fa91938bd0 Stephan Mueller 2015-06-23 139 spin_lock(&rng->jent_lock);
764428fe99e82c Stephan Müller 2020-04-17 140
dfc9fa91938bd0 Stephan Mueller 2015-06-23 141 ret = jent_read_entropy(rng->entropy_collector, rdata, dlen);
764428fe99e82c Stephan Müller 2020-04-17 142
ce362096eea814 Stephan Müller 2023-03-24 143 if (ret == -3) {
ce362096eea814 Stephan Müller 2023-03-24 144 /* Handle permanent health test error */
ce362096eea814 Stephan Müller 2023-03-24 145 /*
ce362096eea814 Stephan Müller 2023-03-24 146 * If the kernel was booted with fips=2, it implies that
ce362096eea814 Stephan Müller 2023-03-24 147 * the entire kernel acts as a FIPS 140 module. In this case
ce362096eea814 Stephan Müller 2023-03-24 148 * an SP800-90B permanent health test error is treated as
ce362096eea814 Stephan Müller 2023-03-24 149 * a FIPS module error.
ce362096eea814 Stephan Müller 2023-03-24 150 */
ce362096eea814 Stephan Müller 2023-03-24 151 if (fips_enabled)
ce362096eea814 Stephan Müller 2023-03-24 152 panic("Jitter RNG permanent health test failure\n");
764428fe99e82c Stephan Müller 2020-04-17 153
ce362096eea814 Stephan Müller 2023-03-24 154 pr_err("Jitter RNG permanent health test failure\n");
ce362096eea814 Stephan Müller 2023-03-24 155 ret = -EFAULT;
ce362096eea814 Stephan Müller 2023-03-24 156 } else if (ret == -2) {
ce362096eea814 Stephan Müller 2023-03-24 157 /* Handle intermittent health test error */
ce362096eea814 Stephan Müller 2023-03-24 158 pr_warn_ratelimited("Reset Jitter RNG due to intermittent health test failure\n");
764428fe99e82c Stephan Müller 2020-04-17 159 ret = -EAGAIN;
ce362096eea814 Stephan Müller 2023-03-24 160 } else if (ret == -1) {
ce362096eea814 Stephan Müller 2023-03-24 161 /* Handle other errors */
764428fe99e82c Stephan Müller 2020-04-17 162 ret = -EINVAL;
764428fe99e82c Stephan Müller 2020-04-17 163 }
764428fe99e82c Stephan Müller 2020-04-17 164
764428fe99e82c Stephan Müller 2020-04-17 @165 out:
dfc9fa91938bd0 Stephan Mueller 2015-06-23 166 spin_unlock(&rng->jent_lock);
dfc9fa91938bd0 Stephan Mueller 2015-06-23 167
dfc9fa91938bd0 Stephan Mueller 2015-06-23 168 return ret;
dfc9fa91938bd0 Stephan Mueller 2015-06-23 169 }
dfc9fa91938bd0 Stephan Mueller 2015-06-23 170
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-24 16:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <2671913.mvXUDI8C0e@positron.chronox.de>
2023-03-24 16:03 ` [PATCH v2] Jitter RNG - Permanent and Intermittent health errors kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).