* [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable
@ 2023-03-26 0:32 Tom Rix
2023-03-27 18:02 ` Himanshu Madhani
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Tom Rix @ 2023-03-26 0:32 UTC (permalink / raw)
To: jejb, martin.petersen, nathan, ndesaulniers
Cc: linux-scsi, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/scsi/scsi_transport_fc.c:908:6: error: variable
'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]
u32 desc_cnt = 0, bytes_remain;
^
This variable is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/scsi/scsi_transport_fc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index f12e9467ebb4..64ff2629eaf9 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -905,7 +905,7 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_len, char *fpin_buf,
{
struct fc_els_fpin *fpin = (struct fc_els_fpin *)fpin_buf;
struct fc_tlv_desc *tlv;
- u32 desc_cnt = 0, bytes_remain;
+ u32 bytes_remain;
u32 dtag;
enum fc_host_event_code event_code =
event_acknowledge ? FCH_EVT_LINK_FPIN_ACK : FCH_EVT_LINK_FPIN;
@@ -932,7 +932,6 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_len, char *fpin_buf,
fc_fpin_congn_stats_update(shost, tlv);
}
- desc_cnt++;
bytes_remain -= FC_TLV_DESC_SZ_FROM_LENGTH(tlv);
tlv = fc_tlv_next_desc(tlv);
}
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable
2023-03-26 0:32 [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable Tom Rix
@ 2023-03-27 18:02 ` Himanshu Madhani
2023-03-30 14:29 ` Benjamin Block
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Himanshu Madhani @ 2023-03-27 18:02 UTC (permalink / raw)
To: Tom Rix
Cc: James E.J. Bottomley, Martin Petersen, Nathan Chancellor,
Nick Desaulniers, linux-scsi, open list, llvm
> On Mar 25, 2023, at 5:32 PM, Tom Rix <trix@redhat.com> wrote:
>
> clang with W=1 reports
> drivers/scsi/scsi_transport_fc.c:908:6: error: variable
> 'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]
> u32 desc_cnt = 0, bytes_remain;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/scsi/scsi_transport_fc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
> index f12e9467ebb4..64ff2629eaf9 100644
> --- a/drivers/scsi/scsi_transport_fc.c
> +++ b/drivers/scsi/scsi_transport_fc.c
> @@ -905,7 +905,7 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_len, char *fpin_buf,
> {
> struct fc_els_fpin *fpin = (struct fc_els_fpin *)fpin_buf;
> struct fc_tlv_desc *tlv;
> - u32 desc_cnt = 0, bytes_remain;
> + u32 bytes_remain;
> u32 dtag;
> enum fc_host_event_code event_code =
> event_acknowledge ? FCH_EVT_LINK_FPIN_ACK : FCH_EVT_LINK_FPIN;
> @@ -932,7 +932,6 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_len, char *fpin_buf,
> fc_fpin_congn_stats_update(shost, tlv);
> }
>
> - desc_cnt++;
> bytes_remain -= FC_TLV_DESC_SZ_FROM_LENGTH(tlv);
> tlv = fc_tlv_next_desc(tlv);
> }
> --
> 2.27.0
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable
2023-03-26 0:32 [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable Tom Rix
2023-03-27 18:02 ` Himanshu Madhani
@ 2023-03-30 14:29 ` Benjamin Block
2023-04-03 1:38 ` Martin K. Petersen
2023-04-12 2:04 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Benjamin Block @ 2023-03-30 14:29 UTC (permalink / raw)
To: Tom Rix
Cc: jejb, martin.petersen, nathan, ndesaulniers, linux-scsi,
linux-kernel, llvm
On Sat, Mar 25, 2023 at 08:32:22PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/scsi/scsi_transport_fc.c:908:6: error: variable
> 'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]
> u32 desc_cnt = 0, bytes_remain;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/scsi/scsi_transport_fc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Looks good to me.
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
--
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development
IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy
Vors. Aufs.-R.: Gregor Pillen / Geschäftsführung: David Faller
Sitz der Ges.: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable
2023-03-26 0:32 [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable Tom Rix
2023-03-27 18:02 ` Himanshu Madhani
2023-03-30 14:29 ` Benjamin Block
@ 2023-04-03 1:38 ` Martin K. Petersen
2023-04-12 2:04 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2023-04-03 1:38 UTC (permalink / raw)
To: Tom Rix
Cc: jejb, martin.petersen, nathan, ndesaulniers, linux-scsi,
linux-kernel, llvm
Tom,
> clang with W=1 reports
> drivers/scsi/scsi_transport_fc.c:908:6: error: variable
> 'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]
> u32 desc_cnt = 0, bytes_remain;
> ^
> This variable is not used so remove it.
Applied to 6.4/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable
2023-03-26 0:32 [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable Tom Rix
` (2 preceding siblings ...)
2023-04-03 1:38 ` Martin K. Petersen
@ 2023-04-12 2:04 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2023-04-12 2:04 UTC (permalink / raw)
To: jejb, nathan, ndesaulniers, Tom Rix
Cc: Martin K . Petersen, linux-scsi, linux-kernel, llvm
On Sat, 25 Mar 2023 20:32:22 -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/scsi/scsi_transport_fc.c:908:6: error: variable
> 'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]
> u32 desc_cnt = 0, bytes_remain;
> ^
> This variable is not used so remove it.
>
> [...]
Applied to 6.4/scsi-queue, thanks!
[1/1] scsi: scsi_transport_fc: remove unused desc_cnt variable
https://git.kernel.org/mkp/scsi/c/e324dd00fd17
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-04-12 2:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-26 0:32 [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable Tom Rix
2023-03-27 18:02 ` Himanshu Madhani
2023-03-30 14:29 ` Benjamin Block
2023-04-03 1:38 ` Martin K. Petersen
2023-04-12 2:04 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).