Re: [Intel-wired-lan] [PATCH net-next v12 3/4] ice: add ability to read FW log data and configure the number of log buffers

Re: [Intel-wired-lan] [PATCH net-next v12 3/4] ice: add ability to read FW log data and configure the number of log buffers

[kernel test robot]

Hi Paul,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Paul-M-Stillwell-Jr/ice-remove-FW-logging-code/20230608-062658
base:   net-next/main
patch link:    https://lore.kernel.org/r/20230607222443.119-4-paul.m.stillwell.jr%40intel.com
patch subject: [Intel-wired-lan] [PATCH net-next v12 3/4] ice: add ability to read FW log data and configure the number of log buffers
config: x86_64-randconfig-a006-20230607 (https://download.01.org/0day-ci/archive/20230608/202306081116.lKcH4bg6-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add net-next https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
        git fetch net-next main
        git checkout net-next/main
        b4 shazam https://lore.kernel.org/r/20230607222443.119-4-paul.m.stillwell.jr@intel.com
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/ethernet/intel/ice/

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306081116.lKcH4bg6-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/intel/ice/ice_debugfs.c:638:6: warning: variable 'debug_count' set but not used [-Wunused-but-set-variable]
           int debug_count;
               ^
   1 warning generated.


vim +/debug_count +638 drivers/net/ethernet/intel/ice/ice_debugfs.c

   623	
   624	/**
   625	 * ice_debugfs_data_read - read from 'data' file
   626	 * @filp: the opened file
   627	 * @buffer: where to write the data for the user to read
   628	 * @count: the size of the user's buffer
   629	 * @ppos: file position offset
   630	 */
   631	static ssize_t ice_debugfs_data_read(struct file *filp, char __user *buffer,
   632					     size_t count, loff_t *ppos)
   633	{
   634		struct ice_pf *pf = filp->private_data;
   635		struct ice_hw *hw = &pf->hw;
   636		int data_copied = 0;
   637		bool done = false;
 > 638		int debug_count;
   639	
   640		/* don't allow commands if the FW doesn't support it */
   641		if (!ice_fwlog_supported(&pf->hw))
   642			return -EOPNOTSUPP;
   643	
   644		if (ice_fwlog_ring_empty(&hw->fwlog_ring))
   645			return 0;
   646	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki