* [linux-next:master 7313/12815] drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c:1888:5: warning: stack frame size (2208) exceeds limit (2048) in 'rockchip_vpu981_av1_dec_run'
@ 2023-06-30 19:45 kernel test robot
2023-07-04 7:25 ` Benjamin Gaignard
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2023-06-30 19:45 UTC (permalink / raw)
To: Benjamin Gaignard
Cc: llvm, oe-kbuild-all, Linux Memory Management List,
Mauro Carvalho Chehab, linux-media, Nicolas Dufresne,
Hans Verkuil
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 6352a698ca5bf26a9199202666b16cf741f579f6
commit: 727a400686a2c0d25015c9e44916a59b72882f83 [7313/12815] media: verisilicon: Add Rockchip AV1 decoder
config: riscv-randconfig-r021-20230701 (https://download.01.org/0day-ci/archive/20230701/202307010357.sY3iLanr-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230701/202307010357.sY3iLanr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307010357.sY3iLanr-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c:1888:5: warning: stack frame size (2208) exceeds limit (2048) in 'rockchip_vpu981_av1_dec_run' [-Wframe-larger-than]
int rockchip_vpu981_av1_dec_run(struct hantro_ctx *ctx)
^
375/2208 (16.98%) spills, 1833/2208 (83.02%) variables
1 warning generated.
vim +/rockchip_vpu981_av1_dec_run +1888 drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c
1887
> 1888 int rockchip_vpu981_av1_dec_run(struct hantro_ctx *ctx)
1889 {
1890 struct hantro_dev *vpu = ctx->dev;
1891 struct vb2_v4l2_buffer *vb2_src;
1892 int ret;
1893
1894 hantro_start_prepare_run(ctx);
1895
1896 ret = rockchip_vpu981_av1_dec_prepare_run(ctx);
1897 if (ret)
1898 goto prepare_error;
1899
1900 vb2_src = hantro_get_src_buf(ctx);
1901 if (!vb2_src) {
1902 ret = -EINVAL;
1903 goto prepare_error;
1904 }
1905
1906 rockchip_vpu981_av1_dec_clean_refs(ctx);
1907 rockchip_vpu981_av1_dec_frame_ref(ctx, vb2_src->vb2_buf.timestamp);
1908
1909 rockchip_vpu981_av1_dec_set_parameters(ctx);
1910 rockchip_vpu981_av1_dec_set_global_model(ctx);
1911 rockchip_vpu981_av1_dec_set_tile_info(ctx);
1912 rockchip_vpu981_av1_dec_set_reference_frames(ctx);
1913 rockchip_vpu981_av1_dec_set_segmentation(ctx);
1914 rockchip_vpu981_av1_dec_set_loopfilter(ctx);
1915 rockchip_vpu981_av1_dec_set_picture_dimensions(ctx);
1916 rockchip_vpu981_av1_dec_set_cdef(ctx);
1917 rockchip_vpu981_av1_dec_set_lr(ctx);
1918 rockchip_vpu981_av1_dec_set_prob(ctx);
1919
1920 hantro_reg_write(vpu, &av1_dec_mode, AV1_DEC_MODE);
1921 hantro_reg_write(vpu, &av1_dec_out_ec_byte_word, 0);
1922 hantro_reg_write(vpu, &av1_write_mvs_e, 1);
1923 hantro_reg_write(vpu, &av1_dec_out_ec_bypass, 1);
1924 hantro_reg_write(vpu, &av1_dec_clk_gate_e, 1);
1925
1926 hantro_reg_write(vpu, &av1_dec_abort_e, 0);
1927 hantro_reg_write(vpu, &av1_dec_tile_int_e, 0);
1928
1929 hantro_reg_write(vpu, &av1_dec_alignment, 64);
1930 hantro_reg_write(vpu, &av1_apf_disable, 0);
1931 hantro_reg_write(vpu, &av1_apf_threshold, 8);
1932 hantro_reg_write(vpu, &av1_dec_buswidth, 2);
1933 hantro_reg_write(vpu, &av1_dec_max_burst, 16);
1934 hantro_reg_write(vpu, &av1_error_conceal_e, 0);
1935 hantro_reg_write(vpu, &av1_axi_rd_ostd_threshold, 64);
1936 hantro_reg_write(vpu, &av1_axi_wr_ostd_threshold, 64);
1937
1938 hantro_reg_write(vpu, &av1_ext_timeout_cycles, 0xfffffff);
1939 hantro_reg_write(vpu, &av1_ext_timeout_override_e, 1);
1940 hantro_reg_write(vpu, &av1_timeout_cycles, 0xfffffff);
1941 hantro_reg_write(vpu, &av1_timeout_override_e, 1);
1942
1943 rockchip_vpu981_av1_dec_set_output_buffer(ctx);
1944 rockchip_vpu981_av1_dec_set_input_buffer(ctx, vb2_src);
1945
1946 hantro_end_prepare_run(ctx);
1947
1948 hantro_reg_write(vpu, &av1_dec_e, 1);
1949
1950 return 0;
1951
1952 prepare_error:
1953 hantro_end_prepare_run(ctx);
1954 hantro_irq_done(vpu, VB2_BUF_STATE_ERROR);
1955 return ret;
1956 }
1957
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [linux-next:master 7313/12815] drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c:1888:5: warning: stack frame size (2208) exceeds limit (2048) in 'rockchip_vpu981_av1_dec_run'
2023-06-30 19:45 [linux-next:master 7313/12815] drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c:1888:5: warning: stack frame size (2208) exceeds limit (2048) in 'rockchip_vpu981_av1_dec_run' kernel test robot
@ 2023-07-04 7:25 ` Benjamin Gaignard
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Gaignard @ 2023-07-04 7:25 UTC (permalink / raw)
To: kernel test robot
Cc: llvm, oe-kbuild-all, Linux Memory Management List,
Mauro Carvalho Chehab, linux-media, Nicolas Dufresne,
Hans Verkuil
Le 30/06/2023 à 21:45, kernel test robot a écrit :
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 6352a698ca5bf26a9199202666b16cf741f579f6
> commit: 727a400686a2c0d25015c9e44916a59b72882f83 [7313/12815] media: verisilicon: Add Rockchip AV1 decoder
> config: riscv-randconfig-r021-20230701 (https://download.01.org/0day-ci/archive/20230701/202307010357.sY3iLanr-lkp@intel.com/config)
> compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
> reproduce: (https://download.01.org/0day-ci/archive/20230701/202307010357.sY3iLanr-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202307010357.sY3iLanr-lkp@intel.com/
Arnd have already send a patch to fix this kind of problem:
https://lore.kernel.org/lkml/20230616144854.3818934-2-arnd@kernel.org/T/
Regards,
Benjamin
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c:1888:5: warning: stack frame size (2208) exceeds limit (2048) in 'rockchip_vpu981_av1_dec_run' [-Wframe-larger-than]
> int rockchip_vpu981_av1_dec_run(struct hantro_ctx *ctx)
> ^
> 375/2208 (16.98%) spills, 1833/2208 (83.02%) variables
> 1 warning generated.
>
>
> vim +/rockchip_vpu981_av1_dec_run +1888 drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c
>
> 1887
>> 1888 int rockchip_vpu981_av1_dec_run(struct hantro_ctx *ctx)
> 1889 {
> 1890 struct hantro_dev *vpu = ctx->dev;
> 1891 struct vb2_v4l2_buffer *vb2_src;
> 1892 int ret;
> 1893
> 1894 hantro_start_prepare_run(ctx);
> 1895
> 1896 ret = rockchip_vpu981_av1_dec_prepare_run(ctx);
> 1897 if (ret)
> 1898 goto prepare_error;
> 1899
> 1900 vb2_src = hantro_get_src_buf(ctx);
> 1901 if (!vb2_src) {
> 1902 ret = -EINVAL;
> 1903 goto prepare_error;
> 1904 }
> 1905
> 1906 rockchip_vpu981_av1_dec_clean_refs(ctx);
> 1907 rockchip_vpu981_av1_dec_frame_ref(ctx, vb2_src->vb2_buf.timestamp);
> 1908
> 1909 rockchip_vpu981_av1_dec_set_parameters(ctx);
> 1910 rockchip_vpu981_av1_dec_set_global_model(ctx);
> 1911 rockchip_vpu981_av1_dec_set_tile_info(ctx);
> 1912 rockchip_vpu981_av1_dec_set_reference_frames(ctx);
> 1913 rockchip_vpu981_av1_dec_set_segmentation(ctx);
> 1914 rockchip_vpu981_av1_dec_set_loopfilter(ctx);
> 1915 rockchip_vpu981_av1_dec_set_picture_dimensions(ctx);
> 1916 rockchip_vpu981_av1_dec_set_cdef(ctx);
> 1917 rockchip_vpu981_av1_dec_set_lr(ctx);
> 1918 rockchip_vpu981_av1_dec_set_prob(ctx);
> 1919
> 1920 hantro_reg_write(vpu, &av1_dec_mode, AV1_DEC_MODE);
> 1921 hantro_reg_write(vpu, &av1_dec_out_ec_byte_word, 0);
> 1922 hantro_reg_write(vpu, &av1_write_mvs_e, 1);
> 1923 hantro_reg_write(vpu, &av1_dec_out_ec_bypass, 1);
> 1924 hantro_reg_write(vpu, &av1_dec_clk_gate_e, 1);
> 1925
> 1926 hantro_reg_write(vpu, &av1_dec_abort_e, 0);
> 1927 hantro_reg_write(vpu, &av1_dec_tile_int_e, 0);
> 1928
> 1929 hantro_reg_write(vpu, &av1_dec_alignment, 64);
> 1930 hantro_reg_write(vpu, &av1_apf_disable, 0);
> 1931 hantro_reg_write(vpu, &av1_apf_threshold, 8);
> 1932 hantro_reg_write(vpu, &av1_dec_buswidth, 2);
> 1933 hantro_reg_write(vpu, &av1_dec_max_burst, 16);
> 1934 hantro_reg_write(vpu, &av1_error_conceal_e, 0);
> 1935 hantro_reg_write(vpu, &av1_axi_rd_ostd_threshold, 64);
> 1936 hantro_reg_write(vpu, &av1_axi_wr_ostd_threshold, 64);
> 1937
> 1938 hantro_reg_write(vpu, &av1_ext_timeout_cycles, 0xfffffff);
> 1939 hantro_reg_write(vpu, &av1_ext_timeout_override_e, 1);
> 1940 hantro_reg_write(vpu, &av1_timeout_cycles, 0xfffffff);
> 1941 hantro_reg_write(vpu, &av1_timeout_override_e, 1);
> 1942
> 1943 rockchip_vpu981_av1_dec_set_output_buffer(ctx);
> 1944 rockchip_vpu981_av1_dec_set_input_buffer(ctx, vb2_src);
> 1945
> 1946 hantro_end_prepare_run(ctx);
> 1947
> 1948 hantro_reg_write(vpu, &av1_dec_e, 1);
> 1949
> 1950 return 0;
> 1951
> 1952 prepare_error:
> 1953 hantro_end_prepare_run(ctx);
> 1954 hantro_irq_done(vpu, VB2_BUF_STATE_ERROR);
> 1955 return ret;
> 1956 }
> 1957
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-04 7:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-30 19:45 [linux-next:master 7313/12815] drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c:1888:5: warning: stack frame size (2208) exceeds limit (2048) in 'rockchip_vpu981_av1_dec_run' kernel test robot
2023-07-04 7:25 ` Benjamin Gaignard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).