* [PATCH] ALSA: portman2x4: remove unused portman_read_command,data functions
@ 2023-03-18 13:52 Tom Rix
2023-03-19 8:11 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-18 13:52 UTC (permalink / raw)
To: perex, tiwai, nathan, ndesaulniers
Cc: alsa-devel, linux-kernel, llvm, Tom Rix
clang with W=1 reports
sound/drivers/portman2x4.c:185:18: error: unused function
'portman_read_command' [-Werror,-Wunused-function]
static inline u8 portman_read_command(struct portman *pm)
^
sound/drivers/portman2x4.c:195:18: error: unused function
'portman_read_data' [-Werror,-Wunused-function]
static inline u8 portman_read_data(struct portman *pm)
^
These static functions are not used, so remove them.
Signed-off-by: Tom Rix <trix@redhat.com>
---
sound/drivers/portman2x4.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c
index 52a656735365..4cdf56a0eb65 100644
--- a/sound/drivers/portman2x4.c
+++ b/sound/drivers/portman2x4.c
@@ -182,21 +182,11 @@ static inline void portman_write_command(struct portman *pm, u8 value)
parport_write_control(pm->pardev->port, value);
}
-static inline u8 portman_read_command(struct portman *pm)
-{
- return parport_read_control(pm->pardev->port);
-}
-
static inline u8 portman_read_status(struct portman *pm)
{
return parport_read_status(pm->pardev->port);
}
-static inline u8 portman_read_data(struct portman *pm)
-{
- return parport_read_data(pm->pardev->port);
-}
-
static inline void portman_write_data(struct portman *pm, u8 value)
{
parport_write_data(pm->pardev->port, value);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: portman2x4: remove unused portman_read_command,data functions
2023-03-18 13:52 [PATCH] ALSA: portman2x4: remove unused portman_read_command,data functions Tom Rix
@ 2023-03-19 8:11 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2023-03-19 8:11 UTC (permalink / raw)
To: Tom Rix
Cc: perex, tiwai, nathan, ndesaulniers, alsa-devel, linux-kernel, llvm
On Sat, 18 Mar 2023 14:52:29 +0100,
Tom Rix wrote:
>
> clang with W=1 reports
> sound/drivers/portman2x4.c:185:18: error: unused function
> 'portman_read_command' [-Werror,-Wunused-function]
> static inline u8 portman_read_command(struct portman *pm)
> ^
> sound/drivers/portman2x4.c:195:18: error: unused function
> 'portman_read_data' [-Werror,-Wunused-function]
> static inline u8 portman_read_data(struct portman *pm)
> ^
> These static functions are not used, so remove them.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied now, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-19 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-18 13:52 [PATCH] ALSA: portman2x4: remove unused portman_read_command,data functions Tom Rix
2023-03-19 8:11 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).