[PATCH -next] fpga: region: fix kernel-doc

[PATCH -next] fpga: region: fix kernel-doc

[Yang Li]

Fix function name in of-fpga-region.c kernel-doc comment
to remove a warning found by clang(make W=1 LLVM=1).

drivers/fpga/of-fpga-region.c:451: warning: expecting prototype for
fpga_region_init(). Prototype was for of_fpga_region_init() instead.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/fpga/of-fpga-region.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
index 9c662db..50b8305 100644
--- a/drivers/fpga/of-fpga-region.c
+++ b/drivers/fpga/of-fpga-region.c
@@ -444,7 +444,7 @@ static int of_fpga_region_remove(struct platform_device *pdev)
 };
 
 /**
- * fpga_region_init - init function for fpga_region class
+ * of_fpga_region_init - init function for fpga_region class
  * Creates the fpga_region class and registers a reconfig notifier.
  */
 static int __init of_fpga_region_init(void)
-- 
1.8.3.1

Re: [PATCH -next] fpga: region: fix kernel-doc

[Randy Dunlap]

Hi--

On 12/2/21 18:44, Yang Li wrote:
> Fix function name in of-fpga-region.c kernel-doc comment
> to remove a warning found by clang(make W=1 LLVM=1).

The patch below looks good, but the commit message about
"found by clang" is not correct. Using 'make W=1' causes
scripts/kernel-doc to run, and this warning message is from kernel-doc,
not from clang.

> drivers/fpga/of-fpga-region.c:451: warning: expecting prototype for
> fpga_region_init(). Prototype was for of_fpga_region_init() instead.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/fpga/of-fpga-region.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
> index 9c662db..50b8305 100644
> --- a/drivers/fpga/of-fpga-region.c
> +++ b/drivers/fpga/of-fpga-region.c
> @@ -444,7 +444,7 @@ static int of_fpga_region_remove(struct platform_device *pdev)
>  };
>  
>  /**
> - * fpga_region_init - init function for fpga_region class
> + * of_fpga_region_init - init function for fpga_region class
>   * Creates the fpga_region class and registers a reconfig notifier.
>   */
>  static int __init of_fpga_region_init(void)
> 

thanks.
-- 
~Randy

Re: [PATCH -next] fpga: region: fix kernel-doc

[Moritz Fischer]

Hi Yang,

On Thu, Dec 02, 2021 at 07:02:16PM -0800, Randy Dunlap wrote:

> Hi--
> 
> On 12/2/21 18:44, Yang Li wrote:
> > Fix function name in of-fpga-region.c kernel-doc comment
> > to remove a warning found by clang(make W=1 LLVM=1).
> 
> The patch below looks good, but the commit message about
> "found by clang" is not correct. Using 'make W=1' causes
> scripts/kernel-doc to run, and this warning message is from kernel-doc,
> not from clang.
> 
> > drivers/fpga/of-fpga-region.c:451: warning: expecting prototype for
> > fpga_region_init(). Prototype was for of_fpga_region_init() instead.
> > 
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> >  drivers/fpga/of-fpga-region.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
> > index 9c662db..50b8305 100644
> > --- a/drivers/fpga/of-fpga-region.c
> > +++ b/drivers/fpga/of-fpga-region.c
> > @@ -444,7 +444,7 @@ static int of_fpga_region_remove(struct platform_device *pdev)
> >  };
> >  
> >  /**
> > - * fpga_region_init - init function for fpga_region class
> > + * of_fpga_region_init - init function for fpga_region class
> >   * Creates the fpga_region class and registers a reconfig notifier.
> >   */
> >  static int __init of_fpga_region_init(void)
> > 
> 
> thanks.
> -- 
> ~Randy

Can you resend with these addressed?

Thanks