* [LTP] [PATCH v4 1/1] creat09: Run on all_filesystems
@ 2021-10-15 8:38 Petr Vorel
2021-10-15 8:45 ` xuyang2018.jy
2021-10-15 9:06 ` Martin Doucha
0 siblings, 2 replies; 5+ messages in thread
From: Petr Vorel @ 2021-10-15 8:38 UTC (permalink / raw)
To: ltp
To make sure bug on XFS is detected on systems which use it.
Due setgid is test problematic on Microsoft filesystems:
creat09.c:81: TBROK: ntfs: Setgid bit not set
creat09.c:76: TBROK: chown(exfat,65533,4) failed: EPERM (1)
creat09.c:76: TBROK: chown(vfat,65533,4) failed: EPERM (1)
thus they're disabled.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
changes v3->v4:
* remove useless .needs_tmpdir
changes v2->v3:
* add missing dir separator /
* remove unused SAFE_CHDIR() (was needed due missing /)
* remove unused <stdio.h>
testcases/kernel/syscalls/creat/creat09.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/creat/creat09.c b/testcases/kernel/syscalls/creat/creat09.c
index 681b80c7d..bed7bddb0 100644
--- a/testcases/kernel/syscalls/creat/creat09.c
+++ b/testcases/kernel/syscalls/creat/creat09.c
@@ -39,7 +39,8 @@
#define MODE_RWX 0777
#define MODE_SGID (S_ISGID|0777)
-#define WORKDIR "testdir"
+#define MNTPOINT "mntpoint"
+#define WORKDIR MNTPOINT "/testdir"
#define CREAT_FILE WORKDIR "/creat.tmp"
#define OPEN_FILE WORKDIR "/open.tmp"
@@ -118,7 +119,15 @@ static struct tst_test test = {
.setup = setup,
.cleanup = cleanup,
.needs_root = 1,
- .needs_tmpdir = 1,
+ .all_filesystems = 1,
+ .mount_device = 1,
+ .mntpoint = MNTPOINT,
+ .skip_filesystems = (const char*[]) {
+ "exfat",
+ "ntfs",
+ "vfat",
+ NULL
+ },
.tags = (const struct tst_tag[]) {
{"linux-git", "0fa3ecd87848"},
{"CVE", "2018-13405"},
--
2.33.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [LTP] [PATCH v4 1/1] creat09: Run on all_filesystems
2021-10-15 8:38 [LTP] [PATCH v4 1/1] creat09: Run on all_filesystems Petr Vorel
@ 2021-10-15 8:45 ` xuyang2018.jy
2021-10-15 9:01 ` Jan Stancek
2021-10-15 9:06 ` Martin Doucha
1 sibling, 1 reply; 5+ messages in thread
From: xuyang2018.jy @ 2021-10-15 8:45 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi Petr
Looks good to me,
Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
Best Regards
Yang Xu
> To make sure bug on XFS is detected on systems which use it.
>
> Due setgid is test problematic on Microsoft filesystems:
>
> creat09.c:81: TBROK: ntfs: Setgid bit not set
> creat09.c:76: TBROK: chown(exfat,65533,4) failed: EPERM (1)
> creat09.c:76: TBROK: chown(vfat,65533,4) failed: EPERM (1)
>
> thus they're disabled.
>
> Signed-off-by: Petr Vorel<pvorel@suse.cz>
> ---
> changes v3->v4:
> * remove useless .needs_tmpdir
>
> changes v2->v3:
> * add missing dir separator /
> * remove unused SAFE_CHDIR() (was needed due missing /)
> * remove unused<stdio.h>
>
> testcases/kernel/syscalls/creat/creat09.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/creat/creat09.c b/testcases/kernel/syscalls/creat/creat09.c
> index 681b80c7d..bed7bddb0 100644
> --- a/testcases/kernel/syscalls/creat/creat09.c
> +++ b/testcases/kernel/syscalls/creat/creat09.c
> @@ -39,7 +39,8 @@
> #define MODE_RWX 0777
> #define MODE_SGID (S_ISGID|0777)
>
> -#define WORKDIR "testdir"
> +#define MNTPOINT "mntpoint"
> +#define WORKDIR MNTPOINT "/testdir"
> #define CREAT_FILE WORKDIR "/creat.tmp"
> #define OPEN_FILE WORKDIR "/open.tmp"
>
> @@ -118,7 +119,15 @@ static struct tst_test test = {
> .setup = setup,
> .cleanup = cleanup,
> .needs_root = 1,
> - .needs_tmpdir = 1,
> + .all_filesystems = 1,
> + .mount_device = 1,
> + .mntpoint = MNTPOINT,
> + .skip_filesystems = (const char*[]) {
> + "exfat",
> + "ntfs",
> + "vfat",
> + NULL
> + },
> .tags = (const struct tst_tag[]) {
> {"linux-git", "0fa3ecd87848"},
> {"CVE", "2018-13405"},
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [LTP] [PATCH v4 1/1] creat09: Run on all_filesystems
2021-10-15 8:45 ` xuyang2018.jy
@ 2021-10-15 9:01 ` Jan Stancek
2021-10-15 9:35 ` Petr Vorel
0 siblings, 1 reply; 5+ messages in thread
From: Jan Stancek @ 2021-10-15 9:01 UTC (permalink / raw)
To: xuyang2018.jy; +Cc: ltp
On Fri, Oct 15, 2021 at 10:45 AM xuyang2018.jy@fujitsu.com
<xuyang2018.jy@fujitsu.com> wrote:
>
> Hi Petr
>
> Looks good to me,
> Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
Acked-by: Jan Stancek <jstancek@redhat.com>
>
> Best Regards
> Yang Xu
> > To make sure bug on XFS is detected on systems which use it.
> >
> > Due setgid is test problematic on Microsoft filesystems:
> >
> > creat09.c:81: TBROK: ntfs: Setgid bit not set
> > creat09.c:76: TBROK: chown(exfat,65533,4) failed: EPERM (1)
> > creat09.c:76: TBROK: chown(vfat,65533,4) failed: EPERM (1)
> >
> > thus they're disabled.
> >
> > Signed-off-by: Petr Vorel<pvorel@suse.cz>
> > ---
> > changes v3->v4:
> > * remove useless .needs_tmpdir
> >
> > changes v2->v3:
> > * add missing dir separator /
> > * remove unused SAFE_CHDIR() (was needed due missing /)
> > * remove unused<stdio.h>
> >
> > testcases/kernel/syscalls/creat/creat09.c | 13 +++++++++++--
> > 1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/testcases/kernel/syscalls/creat/creat09.c b/testcases/kernel/syscalls/creat/creat09.c
> > index 681b80c7d..bed7bddb0 100644
> > --- a/testcases/kernel/syscalls/creat/creat09.c
> > +++ b/testcases/kernel/syscalls/creat/creat09.c
> > @@ -39,7 +39,8 @@
> > #define MODE_RWX 0777
> > #define MODE_SGID (S_ISGID|0777)
> >
> > -#define WORKDIR "testdir"
> > +#define MNTPOINT "mntpoint"
> > +#define WORKDIR MNTPOINT "/testdir"
> > #define CREAT_FILE WORKDIR "/creat.tmp"
> > #define OPEN_FILE WORKDIR "/open.tmp"
> >
> > @@ -118,7 +119,15 @@ static struct tst_test test = {
> > .setup = setup,
> > .cleanup = cleanup,
> > .needs_root = 1,
> > - .needs_tmpdir = 1,
> > + .all_filesystems = 1,
> > + .mount_device = 1,
> > + .mntpoint = MNTPOINT,
> > + .skip_filesystems = (const char*[]) {
> > + "exfat",
> > + "ntfs",
> > + "vfat",
> > + NULL
> > + },
> > .tags = (const struct tst_tag[]) {
> > {"linux-git", "0fa3ecd87848"},
> > {"CVE", "2018-13405"},
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH v4 1/1] creat09: Run on all_filesystems
2021-10-15 8:38 [LTP] [PATCH v4 1/1] creat09: Run on all_filesystems Petr Vorel
2021-10-15 8:45 ` xuyang2018.jy
@ 2021-10-15 9:06 ` Martin Doucha
1 sibling, 0 replies; 5+ messages in thread
From: Martin Doucha @ 2021-10-15 9:06 UTC (permalink / raw)
To: Petr Vorel, ltp
Hello,
looks good to me.
Reviewed-by: Martin Doucha <mdoucha@suse.cz>
On 15. 10. 21 10:38, Petr Vorel wrote:
> To make sure bug on XFS is detected on systems which use it.
>
> Due setgid is test problematic on Microsoft filesystems:
>
> creat09.c:81: TBROK: ntfs: Setgid bit not set
> creat09.c:76: TBROK: chown(exfat,65533,4) failed: EPERM (1)
> creat09.c:76: TBROK: chown(vfat,65533,4) failed: EPERM (1)
>
> thus they're disabled.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> changes v3->v4:
> * remove useless .needs_tmpdir
>
> changes v2->v3:
> * add missing dir separator /
> * remove unused SAFE_CHDIR() (was needed due missing /)
> * remove unused <stdio.h>
>
> testcases/kernel/syscalls/creat/creat09.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/creat/creat09.c b/testcases/kernel/syscalls/creat/creat09.c
> index 681b80c7d..bed7bddb0 100644
> --- a/testcases/kernel/syscalls/creat/creat09.c
> +++ b/testcases/kernel/syscalls/creat/creat09.c
> @@ -39,7 +39,8 @@
> #define MODE_RWX 0777
> #define MODE_SGID (S_ISGID|0777)
>
> -#define WORKDIR "testdir"
> +#define MNTPOINT "mntpoint"
> +#define WORKDIR MNTPOINT "/testdir"
> #define CREAT_FILE WORKDIR "/creat.tmp"
> #define OPEN_FILE WORKDIR "/open.tmp"
>
> @@ -118,7 +119,15 @@ static struct tst_test test = {
> .setup = setup,
> .cleanup = cleanup,
> .needs_root = 1,
> - .needs_tmpdir = 1,
> + .all_filesystems = 1,
> + .mount_device = 1,
> + .mntpoint = MNTPOINT,
> + .skip_filesystems = (const char*[]) {
> + "exfat",
> + "ntfs",
> + "vfat",
> + NULL
> + },
> .tags = (const struct tst_tag[]) {
> {"linux-git", "0fa3ecd87848"},
> {"CVE", "2018-13405"},
>
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-15 9:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 8:38 [LTP] [PATCH v4 1/1] creat09: Run on all_filesystems Petr Vorel
2021-10-15 8:45 ` xuyang2018.jy
2021-10-15 9:01 ` Jan Stancek
2021-10-15 9:35 ` Petr Vorel
2021-10-15 9:06 ` Martin Doucha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).