* [LTP] [PATCH] mkfs: relax size check
@ 2021-04-23 11:16 Jan Stancek
2021-04-23 15:06 ` Petr Vorel
2021-04-26 13:11 ` Li Wang
0 siblings, 2 replies; 9+ messages in thread
From: Jan Stancek @ 2021-04-23 11:16 UTC (permalink / raw)
To: ltp
Number of total data blocks in filesystem reported by statfs
may be less than current formula of 90%. For example ext4 will
subtract "s_first_data_block plus internal journal blocks".
With recent change to e2fsprogs, overhead calculated in user-space
increased slightly and LTP test started failing:
https://github.com/tytso/e2fsprogs/commit/59037c5357d39c6d0f14a0aff70e67dc13eafc84
Since there's no strict rule how much the overhead will be,
as rule of thumb relax the condition to 80%.
Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
I haven't found better way to set the test expectation,
so to address immediate failures I propose to relax the check.
testcases/commands/mkfs/mkfs01.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/testcases/commands/mkfs/mkfs01.sh b/testcases/commands/mkfs/mkfs01.sh
index 13491c9685ae..3e3e56719cf3 100755
--- a/testcases/commands/mkfs/mkfs01.sh
+++ b/testcases/commands/mkfs/mkfs01.sh
@@ -69,11 +69,11 @@ mkfs_verify_size()
# 1k-block size should be devided by this argument for ntfs verification.
if [ "$1" = "ntfs" ]; then
local rate=1024/512
- if [ $blocknum -lt "$(($2/$rate*9/10))" ]; then
+ if [ $blocknum -lt "$(($2/$rate*8/10))" ]; then
return 1
fi
else
- if [ $blocknum -lt "$(($2*9/10))" ]; then
+ if [ $blocknum -lt "$(($2*8/10))" ]; then
return 1
fi
fi
--
2.18.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [LTP] [PATCH] mkfs: relax size check
2021-04-23 11:16 [LTP] [PATCH] mkfs: relax size check Jan Stancek
@ 2021-04-23 15:06 ` Petr Vorel
2021-04-23 15:28 ` Petr Vorel
2021-04-26 13:11 ` Li Wang
1 sibling, 1 reply; 9+ messages in thread
From: Petr Vorel @ 2021-04-23 15:06 UTC (permalink / raw)
To: ltp
Hi Jan,
Yes, I also noticed mkfs01_ext3_sh and mkfs01_ext4_sh on mainline, this could
help. Thanks!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
^ permalink raw reply [flat|nested] 9+ messages in thread
* [LTP] [PATCH] mkfs: relax size check
2021-04-23 11:16 [LTP] [PATCH] mkfs: relax size check Jan Stancek
2021-04-23 15:06 ` Petr Vorel
@ 2021-04-26 13:11 ` Li Wang
2021-04-26 19:28 ` Petr Vorel
1 sibling, 1 reply; 9+ messages in thread
From: Li Wang @ 2021-04-26 13:11 UTC (permalink / raw)
To: ltp
On Fri, Apr 23, 2021 at 7:16 PM Jan Stancek <jstancek@redhat.com> wrote:
>
> Number of total data blocks in filesystem reported by statfs
> may be less than current formula of 90%. For example ext4 will
> subtract "s_first_data_block plus internal journal blocks".
>
> With recent change to e2fsprogs, overhead calculated in user-space
> increased slightly and LTP test started failing:
> https://github.com/tytso/e2fsprogs/commit/59037c5357d39c6d0f14a0aff70e67dc13eafc84
>
> Since there's no strict rule how much the overhead will be,
> as rule of thumb relax the condition to 80%.
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Reviewed-by: Li Wang <liwang@redhat.com>
--
Regards,
Li Wang
^ permalink raw reply [flat|nested] 9+ messages in thread
* [LTP] [PATCH] mkfs: relax size check
2021-04-26 13:11 ` Li Wang
@ 2021-04-26 19:28 ` Petr Vorel
0 siblings, 0 replies; 9+ messages in thread
From: Petr Vorel @ 2021-04-26 19:28 UTC (permalink / raw)
To: ltp
Hi Jan, Li,
> On Fri, Apr 23, 2021 at 7:16 PM Jan Stancek <jstancek@redhat.com> wrote:
> > Number of total data blocks in filesystem reported by statfs
> > may be less than current formula of 90%. For example ext4 will
> > subtract "s_first_data_block plus internal journal blocks".
> > With recent change to e2fsprogs, overhead calculated in user-space
> > increased slightly and LTP test started failing:
> > https://github.com/tytso/e2fsprogs/commit/59037c5357d39c6d0f14a0aff70e67dc13eafc84
> > Since there's no strict rule how much the overhead will be,
> > as rule of thumb relax the condition to 80%.
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
> Reviewed-by: Li Wang <liwang@redhat.com>
I dared to merge your fix. Thanks!
Kind regards,
Petr
^ permalink raw reply [flat|nested] 9+ messages in thread
* [LTP] [PATCH] mkfs: relax size check
@ 2022-11-29 3:17 zenghongling
2022-11-29 10:24 ` Petr Vorel
0 siblings, 1 reply; 9+ messages in thread
From: zenghongling @ 2022-11-29 3:17 UTC (permalink / raw)
To: ltp, zenghongling
Number of total data blocks in filesystem reported by statfs
may be less than current formula of 90%. For example ext4 will
subtract "s_first_data_block plus internal journal blocks".
With recent change to e2fsprogs, overhead calculated in user-space
increased slightly and LTP test started failing:
tytso/e2fsprogs
mkfs01 1 TPASS: 'mkfs -t ext4 /dev/loop0 ' passed.
mkfs01 2 TFAIL: 'mkfs -t ext4 /dev/loop0 16000' failed, not expected.
Since there's no strict rule how much the overhead will be,
as rule of thumb relax the condition to 70%.
Signed-off-by: zenghongling <zenghongling@kylinos.cn>
---
testcases/commands/mkfs/mkfs01.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/testcases/commands/mkfs/mkfs01.sh b/testcases/commands/mkfs/mkfs01.sh
index 263aa47..a964774 100755
--- a/testcases/commands/mkfs/mkfs01.sh
+++ b/testcases/commands/mkfs/mkfs01.sh
@@ -66,11 +66,11 @@ mkfs_verify_size()
# 1k-block size should be devided by this argument for ntfs verification.
if [ "$1" = "ntfs" ]; then
local rate=1024/512
- if [ $blocknum -lt "$(($2/$rate*8/10))" ]; then
+ if [ $blocknum -lt "$(($2/$rate*7/10))" ]; then
return 1
fi
else
- if [ $blocknum -lt "$(($2*8/10))" ]; then
+ if [ $blocknum -lt "$(($2*7/10))" ]; then
return 1
fi
fi
--
2.1.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] mkfs: relax size check
2022-11-29 3:17 zenghongling
@ 2022-11-29 10:24 ` Petr Vorel
2022-11-30 8:06 ` Petr Vorel
0 siblings, 1 reply; 9+ messages in thread
From: Petr Vorel @ 2022-11-29 10:24 UTC (permalink / raw)
To: zenghongling; +Cc: ltp
Hi zenghongling,
> Number of total data blocks in filesystem reported by statfs
> may be less than current formula of 90%. For example ext4 will
> subtract "s_first_data_block plus internal journal blocks".
> With recent change to e2fsprogs, overhead calculated in user-space increased
Do you know in which version it got changed?
Maybe it'd be worth to mention that to ext4 maintainers,
just to be sure it's not a regression.
> slightly and LTP test started failing: tytso/e2fsprogs
A bit cryptic description :(. You mean probably https://github.com/tytso/e2fsprogs
which is also on
https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/
Kind regards,
Petr
> mkfs01 1 TPASS: 'mkfs -t ext4 /dev/loop0 ' passed.
> mkfs01 2 TFAIL: 'mkfs -t ext4 /dev/loop0 16000' failed, not expected.
> Since there's no strict rule how much the overhead will be,
> as rule of thumb relax the condition to 70%.
> Signed-off-by: zenghongling <zenghongling@kylinos.cn>
> ---
> testcases/commands/mkfs/mkfs01.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/testcases/commands/mkfs/mkfs01.sh b/testcases/commands/mkfs/mkfs01.sh
> index 263aa47..a964774 100755
> --- a/testcases/commands/mkfs/mkfs01.sh
> +++ b/testcases/commands/mkfs/mkfs01.sh
> @@ -66,11 +66,11 @@ mkfs_verify_size()
> # 1k-block size should be devided by this argument for ntfs verification.
> if [ "$1" = "ntfs" ]; then
> local rate=1024/512
> - if [ $blocknum -lt "$(($2/$rate*8/10))" ]; then
> + if [ $blocknum -lt "$(($2/$rate*7/10))" ]; then
> return 1
> fi
> else
> - if [ $blocknum -lt "$(($2*8/10))" ]; then
> + if [ $blocknum -lt "$(($2*7/10))" ]; then
> return 1
> fi
> fi
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-12-12 15:05 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 11:16 [LTP] [PATCH] mkfs: relax size check Jan Stancek
2021-04-23 15:06 ` Petr Vorel
2021-04-23 15:28 ` Petr Vorel
2021-04-26 13:11 ` Li Wang
2021-04-26 19:28 ` Petr Vorel
2022-11-29 3:17 zenghongling
2022-11-29 10:24 ` Petr Vorel
2022-11-30 8:06 ` Petr Vorel
2022-12-12 15:03 ` Richard Palethorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).