[lttng-dev] 2.13-rc2 fails to build with buildroot crosscompiler

[lttng-dev] 2.13-rc2 fails to build with buildroot crosscompiler

[Norbert Lange via lttng-dev]

Hello,

many tests fail to build, apparently because transitive dependencies
are not found.
I managed to patch out building the test sub-directory, at which
points the errors are gone,
I dont know how to fix it with automake, seems like
/tmp/ZBuild/build/lttng-libust-2.13.0-rc2/src/lib/lttng-ust/.libs
should be added to library search paths.

Norbert

bin/bash ../../../../libtool  --tag=CC   --mode=link
/tmp/ZBuild/host/bin/x86_64-linux-gnu-gcc -Werror=old-style-definition
-DLTTNG_UST_COMPAT_API_VERSION=1 -fno-strict-aliasing -Wall -Wextra
-Wmissing-prototypes -Wmissing-declarations -Wnull-dereference -Wundef
-Wshadow -Wjump-misses-init -Wsuggest-attribute=format
-Wnested-externs -Wwrite-strings -Wformat=2 -Wstrict-aliasing
-Wmissing-noreturn -Winit-self -Wduplicated-cond -Wduplicated-branches
-Wlogical-op -Wno-sign-compare -Wno-missing-field-initializers
-Wno-null-dereference -Wold-style-definition -Wstrict-prototypes
-pthread -D_FILE_OFFSET_BITS=64  -Os  -D_FORTIFY_SOURCE=1    -o
ust-fields-compatapi1 ust_fields_compatapi1-ust-fields.o
ust_fields_compatapi1-tp.o
../../../../src/lib/lttng-ust/liblttng-ust.la -ldl
libtool: link: /tmp/ZBuild/host/bin/x86_64-linux-gnu-gcc
-Werror=old-style-definition -DLTTNG_UST_COMPAT_API_VERSION=1
-fno-strict-aliasing -Wall -Wextra -Wmissing-prototypes
-Wmissing-declarations -Wnull-dereference -Wundef -Wshadow
-Wjump-misses-init -Wsuggest-attribute=format -Wnested-externs
-Wwrite-strings -Wformat=2 -Wstrict-aliasing -Wmissing-noreturn
-Winit-self -Wduplicated-cond -Wduplicated-branches -Wlogical-op
-Wno-sign-compare -Wno-missing-field-initializers
-Wno-null-dereference -Wold-style-definition -Wstrict-prototypes
-pthread -D_FILE_OFFSET_BITS=64 -Os -D_FORTIFY_SOURCE=1 -o
ust-fields-compatapi1 ust_fields_compatapi1-ust-fields.o
ust_fields_compatapi1-tp.o
../../../../src/lib/lttng-ust/.libs/liblttng-ust.so -ldl -pthread
-Wl,-rpath -Wl,/tmp/ZBuild/build/lttng-libust-2.13.0-rc2/src/lib/lttng-ust/.libs

x86_64-linux-gnu/bin/ld: warning: liblttng-ust-common.so.1, needed by
../../../src/lib/lttng-ust/.libs/liblttng-ust.so, not found (try using
-rpath or -rpath-link)
x86_64-linux-gnu/bin/ld: warning: liblttng-ust-tracepoint.so.1, needed
by ../../../src/lib/lttng-ust/.libs/liblttng-ust.so, not found (try
using -rpath or -rpath-link)
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [lttng-dev] 2.13-rc2 fails to build with buildroot crosscompiler

[Michael Jeanson via lttng-dev]

On 2021-05-20 9:52 a.m., Norbert Lange via lttng-dev wrote:
> Hello,
> 
> many tests fail to build, apparently because transitive dependencies
> are not found.
> I managed to patch out building the test sub-directory, at which
> points the errors are gone,
> I dont know how to fix it with automake, seems like
> /tmp/ZBuild/build/lttng-libust-2.13.0-rc2/src/lib/lttng-ust/.libs
> should be added to library search paths.
> 
> Norbert

The libtool integration with autotools should be handling these transitive
dependencies but somehow doesn't seem to work in your environment. A
workaround could be to add the liblttng-ust-common.la file to all the test
binaries _LDADD where liblttng-ust.la is already present, for example:

ust_fields_compatapi1_LDADD = \
        $(top_builddir)/src/lib/lttng-ust/liblttng-ust.la \
        $(top_builddir)/src/lib/lttng-ust-common/liblttng-ust-common.la \
        $(DL_LIBS)

Can you check if this works?

Michael
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [lttng-dev] 2.13-rc2 fails to build with buildroot crosscompiler

[Norbert Lange via lttng-dev]

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

Am Do., 20. Mai 2021 um 16:37 Uhr schrieb Michael Jeanson
<mjeanson@efficios.com>:
>
> On 2021-05-20 9:52 a.m., Norbert Lange via lttng-dev wrote:
> > Hello,
> >
> > many tests fail to build, apparently because transitive dependencies
> > are not found.
> > I managed to patch out building the test sub-directory, at which
> > points the errors are gone,
> > I dont know how to fix it with automake, seems like
> > /tmp/ZBuild/build/lttng-libust-2.13.0-rc2/src/lib/lttng-ust/.libs
> > should be added to library search paths.
> >
> > Norbert
>
> The libtool integration with autotools should be handling these transitive
> dependencies but somehow doesn't seem to work in your environment. A
> workaround could be to add the liblttng-ust-common.la file to all the test file:///home/noppl/git/buildroot/0001-package-lttng-bump-to-2.13rc2-WIP.patch

 > binaries _LDADD where liblttng-ust.la is already present, for example:
>
> ust_fields_compatapi1_LDADD = \
>         $(top_builddir)/src/lib/lttng-ust/liblttng-ust.la \
>         $(top_builddir)/src/lib/lttng-ust-common/liblttng-ust-common.la \
>         $(DL_LIBS)
>
> Can you check if this works?

I suppose it would, but there are many many of these errors also by
linking libraries build in the test directory, would cost some time
and I am not able to triage automake/libtool issues.
Is that the solution upstream wants to use?

I attached a patch for https://buildroot.org/ to pick the current
lttng rc2. using buildroot is easy (but timeconsuming if you build the
cross-compiler aswell):

make O=/tmp/build defconfig
make O=/tmp/build menuconfig

Pick your hosts/prefered architecture in Target options
In toolchain menu pick kernel headers + c library type (glibc for me)

Enable:
Target packages -> Libraries -> Other -> lttng-libust
Target packages -> Debugging, profiling and benchmark -> lttng-tools

Then
make O=/tmp/build

Norbert

[-- Attachment #2: 0001-package-lttng-bump-to-2.13rc2-WIP.patch --]
[-- Type: text/x-patch, Size: 3041 bytes --]

From 0e5266d826e7fcbdd3e09977f58bfff82e8d7476 Mon Sep 17 00:00:00 2001
From: Norbert Lange <nolange79@gmail.com>
Date: Thu, 20 May 2021 18:11:44 +0200
Subject: [PATCH] package/lttng: bump to 2.13rc2 (WIP)

---
 package/lttng-libust/lttng-libust.hash | 4 ++--
 package/lttng-libust/lttng-libust.mk   | 2 +-
 package/lttng-tools/lttng-tools.hash   | 4 ++--
 package/lttng-tools/lttng-tools.mk     | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/package/lttng-libust/lttng-libust.hash b/package/lttng-libust/lttng-libust.hash
index 40bd870e86..2f58db2bf5 100644
--- a/package/lttng-libust/lttng-libust.hash
+++ b/package/lttng-libust/lttng-libust.hash
@@ -1,5 +1,5 @@
-# From https://lttng.org/files/lttng-ust/lttng-ust-2.12.1.tar.bz2.sha256
-sha256  48a3948b168195123a749d22818809bd25127bb5f1a66458c3c012b210d2a051  lttng-ust-2.12.1.tar.bz2
+# From https://lttng.org/files/lttng-ust/lttng-ust-2.13.0-rc2.tar.bz2.sha256
+sha256  51a2bd2e7cb15b4fb110fc6ceeb118256688c4b1da1dadfabdb1de9f079fd8cf  lttng-ust-2.13.0-rc2.tar.bz2
 
 # Hash for license file
 sha256  74125a84c2166300776980166e29de40d5f98d1a75e487f0bbc0c03b4cd2342e  COPYING
diff --git a/package/lttng-libust/lttng-libust.mk b/package/lttng-libust/lttng-libust.mk
index 608e8781b1..d99577504a 100644
--- a/package/lttng-libust/lttng-libust.mk
+++ b/package/lttng-libust/lttng-libust.mk
@@ -5,7 +5,7 @@
 ################################################################################
 
 LTTNG_LIBUST_SITE = http://lttng.org/files/lttng-ust
-LTTNG_LIBUST_VERSION = 2.12.1
+LTTNG_LIBUST_VERSION = 2.13.0-rc2
 LTTNG_LIBUST_SOURCE = lttng-ust-$(LTTNG_LIBUST_VERSION).tar.bz2
 LTTNG_LIBUST_LICENSE = LGPL-2.1, MIT (system headers), GPL-2.0 (liblttng-ust-ctl/ustctl.c used by lttng-sessiond)
 LTTNG_LIBUST_LICENSE_FILES = COPYING
diff --git a/package/lttng-tools/lttng-tools.hash b/package/lttng-tools/lttng-tools.hash
index a94ecc4a35..d00ab133c7 100644
--- a/package/lttng-tools/lttng-tools.hash
+++ b/package/lttng-tools/lttng-tools.hash
@@ -1,5 +1,5 @@
-# From https://lttng.org/files/lttng-tools/lttng-tools-2.12.3.tar.bz2.sha256
-sha256  2890da230edd523fcf497e9eb28133b7606d64fa01bcbffadbfcba42104db153  lttng-tools-2.12.3.tar.bz2
+# From https://lttng.org/files/lttng-tools/lttng-tools-2.13.0-rc2.tar.bz2.sha256
+sha256  5c26d39634adb00e8e953c3caf4dfcb9ba31c510cf21395629b741fa338e1b08  lttng-tools-2.13.0-rc2.tar.bz2
 
 # Locally computed
 sha256  068e55c7dbe597400199aee75ac5e71bdb2ca88c4c9a4cfa8e1fbc61f933eda5  LICENSE
diff --git a/package/lttng-tools/lttng-tools.mk b/package/lttng-tools/lttng-tools.mk
index 8789ded333..f1b1c7217b 100644
--- a/package/lttng-tools/lttng-tools.mk
+++ b/package/lttng-tools/lttng-tools.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LTTNG_TOOLS_VERSION = 2.12.3
+LTTNG_TOOLS_VERSION = 2.13.0-rc2
 LTTNG_TOOLS_SITE = https://lttng.org/files/lttng-tools
 LTTNG_TOOLS_SOURCE = lttng-tools-$(LTTNG_TOOLS_VERSION).tar.bz2
 LTTNG_TOOLS_INSTALL_STAGING = YES
-- 
2.30.2


[-- Attachment #3: Type: text/plain, Size: 156 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev