* [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of register write
@ 2022-09-27 9:48 Qiang Yu
2022-09-27 10:04 ` Loic Poulain
2022-09-27 13:57 ` Jeffrey Hugo
0 siblings, 2 replies; 6+ messages in thread
From: Qiang Yu @ 2022-09-27 9:48 UTC (permalink / raw)
To: mani, quic_hemantk, loic.poulain
Cc: mhi, linux-arm-msm, linux-kernel, quic_cang, mrana, Qiang Yu
Currently, a direct register write is used when ramdump collection
in panic path occurs. Replace that with new mhi_soc_reset() API
such that a controller defined reset() function is exercised if
one is present and the regular SOC reset is done if it is not.
Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
---
drivers/bus/mhi/host/boot.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
index 5bed8b51..79a0eec 100644
--- a/drivers/bus/mhi/host/boot.c
+++ b/drivers/bus/mhi/host/boot.c
@@ -118,9 +118,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
/* Hardware reset so force device to enter RDDM */
dev_dbg(dev,
"Did not enter RDDM, do a host req reset\n");
- mhi_write_reg(mhi_cntrl, mhi_cntrl->regs,
- MHI_SOC_RESET_REQ_OFFSET,
- MHI_SOC_RESET_REQ);
+ mhi_soc_reset(mhi_cntrl);
udelay(delayus);
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of register write
2022-09-27 9:48 [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of register write Qiang Yu
@ 2022-09-27 10:04 ` Loic Poulain
2022-09-27 13:57 ` Jeffrey Hugo
1 sibling, 0 replies; 6+ messages in thread
From: Loic Poulain @ 2022-09-27 10:04 UTC (permalink / raw)
To: Qiang Yu
Cc: mani, quic_hemantk, mhi, linux-arm-msm, linux-kernel, quic_cang, mrana
On Tue, 27 Sept 2022 at 11:49, Qiang Yu <quic_qianyu@quicinc.com> wrote:
>
> Currently, a direct register write is used when ramdump collection
> in panic path occurs. Replace that with new mhi_soc_reset() API
> such that a controller defined reset() function is exercised if
> one is present and the regular SOC reset is done if it is not.
>
> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> drivers/bus/mhi/host/boot.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
> index 5bed8b51..79a0eec 100644
> --- a/drivers/bus/mhi/host/boot.c
> +++ b/drivers/bus/mhi/host/boot.c
> @@ -118,9 +118,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
> /* Hardware reset so force device to enter RDDM */
> dev_dbg(dev,
> "Did not enter RDDM, do a host req reset\n");
> - mhi_write_reg(mhi_cntrl, mhi_cntrl->regs,
> - MHI_SOC_RESET_REQ_OFFSET,
> - MHI_SOC_RESET_REQ);
> + mhi_soc_reset(mhi_cntrl);
> udelay(delayus);
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of register write
2022-09-27 9:48 [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of register write Qiang Yu
2022-09-27 10:04 ` Loic Poulain
@ 2022-09-27 13:57 ` Jeffrey Hugo
1 sibling, 0 replies; 6+ messages in thread
From: Jeffrey Hugo @ 2022-09-27 13:57 UTC (permalink / raw)
To: Qiang Yu, mani, quic_hemantk, loic.poulain
Cc: mhi, linux-arm-msm, linux-kernel, quic_cang, mrana
On 9/27/2022 3:48 AM, Qiang Yu wrote:
> Currently, a direct register write is used when ramdump collection
> in panic path occurs. Replace that with new mhi_soc_reset() API
> such that a controller defined reset() function is exercised if
> one is present and the regular SOC reset is done if it is not.
>
> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
> ---
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of register write
@ 2022-10-10 4:32 Qiang Yu
2022-10-28 17:22 ` Manivannan Sadhasivam
2022-10-28 17:28 ` Manivannan Sadhasivam
0 siblings, 2 replies; 6+ messages in thread
From: Qiang Yu @ 2022-10-10 4:32 UTC (permalink / raw)
To: mani, quic_hemantk, loic.poulain
Cc: mhi, linux-arm-msm, linux-kernel, quic_cang, mrana, Qiang Yu
Currently, a direct register write is used when ramdump collection
in panic path occurs. Replace that with new mhi_soc_reset() API
such that a controller defined reset() function is exercised if
one is present and the regular SOC reset is done if it is not.
Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
---
drivers/bus/mhi/host/boot.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
index 26d0edd..1c69fee 100644
--- a/drivers/bus/mhi/host/boot.c
+++ b/drivers/bus/mhi/host/boot.c
@@ -118,9 +118,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
/* Hardware reset so force device to enter RDDM */
dev_dbg(dev,
"Did not enter RDDM, do a host req reset\n");
- mhi_write_reg(mhi_cntrl, mhi_cntrl->regs,
- MHI_SOC_RESET_REQ_OFFSET,
- MHI_SOC_RESET_REQ);
+ mhi_soc_reset(mhi_cntrl);
udelay(delayus);
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of register write
2022-10-10 4:32 Qiang Yu
@ 2022-10-28 17:22 ` Manivannan Sadhasivam
2022-10-28 17:28 ` Manivannan Sadhasivam
1 sibling, 0 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2022-10-28 17:22 UTC (permalink / raw)
To: Qiang Yu
Cc: quic_hemantk, loic.poulain, mhi, linux-arm-msm, linux-kernel,
quic_cang, mrana
On Mon, Oct 10, 2022 at 12:32:04PM +0800, Qiang Yu wrote:
> Currently, a direct register write is used when ramdump collection
> in panic path occurs. Replace that with new mhi_soc_reset() API
> such that a controller defined reset() function is exercised if
> one is present and the regular SOC reset is done if it is not.
>
> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
> Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Btw, this patch is supposed to be v2... Please keep the version info and also
add the changelog for future patches.
Thanks,
Mani
> ---
> drivers/bus/mhi/host/boot.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
> index 26d0edd..1c69fee 100644
> --- a/drivers/bus/mhi/host/boot.c
> +++ b/drivers/bus/mhi/host/boot.c
> @@ -118,9 +118,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
> /* Hardware reset so force device to enter RDDM */
> dev_dbg(dev,
> "Did not enter RDDM, do a host req reset\n");
> - mhi_write_reg(mhi_cntrl, mhi_cntrl->regs,
> - MHI_SOC_RESET_REQ_OFFSET,
> - MHI_SOC_RESET_REQ);
> + mhi_soc_reset(mhi_cntrl);
> udelay(delayus);
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of register write
2022-10-10 4:32 Qiang Yu
2022-10-28 17:22 ` Manivannan Sadhasivam
@ 2022-10-28 17:28 ` Manivannan Sadhasivam
1 sibling, 0 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2022-10-28 17:28 UTC (permalink / raw)
To: Qiang Yu
Cc: quic_hemantk, loic.poulain, mhi, linux-arm-msm, linux-kernel,
quic_cang, mrana
On Mon, Oct 10, 2022 at 12:32:04PM +0800, Qiang Yu wrote:
> Currently, a direct register write is used when ramdump collection
> in panic path occurs. Replace that with new mhi_soc_reset() API
> such that a controller defined reset() function is exercised if
> one is present and the regular SOC reset is done if it is not.
>
> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
> Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Applied to mhi-next!
Thanks,
Mani
> ---
> drivers/bus/mhi/host/boot.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
> index 26d0edd..1c69fee 100644
> --- a/drivers/bus/mhi/host/boot.c
> +++ b/drivers/bus/mhi/host/boot.c
> @@ -118,9 +118,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
> /* Hardware reset so force device to enter RDDM */
> dev_dbg(dev,
> "Did not enter RDDM, do a host req reset\n");
> - mhi_write_reg(mhi_cntrl, mhi_cntrl->regs,
> - MHI_SOC_RESET_REQ_OFFSET,
> - MHI_SOC_RESET_REQ);
> + mhi_soc_reset(mhi_cntrl);
> udelay(delayus);
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-28 17:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 9:48 [PATCH] bus: mhi: host: Use mhi_soc_reset() API in place of register write Qiang Yu
2022-09-27 10:04 ` Loic Poulain
2022-09-27 13:57 ` Jeffrey Hugo
2022-10-10 4:32 Qiang Yu
2022-10-28 17:22 ` Manivannan Sadhasivam
2022-10-28 17:28 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).