mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch added to -mm tree
@ 2021-05-14 22:09 akpm
  2021-05-17  5:57 ` Aneesh Kumar K.V
  2021-05-17 22:41 ` Stephen Rothwell
  0 siblings, 2 replies; 3+ messages in thread
From: akpm @ 2021-05-14 22:09 UTC (permalink / raw)
  To: akpm, aneesh.kumar, christophe.leroy, joel, kaleshsingh,
	mm-commits, mpe, naresh.kamboju, npiggin, sfr


The patch titled
     Subject: mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix
has been added to the -mm tree.  Its filename is
     mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix

fix build

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Joel Fernandes <joel@joelfernandes.org>
Cc: Kalesh Singh <kaleshsingh@google.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/mremap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/mremap.c~mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix
+++ a/mm/mremap.c
@@ -216,7 +216,7 @@ static inline void flush_pte_tlb_pwc_ran
 					   unsigned long start,
 					   unsigned long end)
 {
-	return flush_tlb_range(vma, start, end);
+	flush_tlb_range(vma, start, end);
 }
 #endif
 
_

Patches currently in -mm which might be from akpm@linux-foundation.org are

mm.patch
mm-slub-kunit-add-a-kunit-test-for-slub-debugging-functionality-fix-2.patch
mm-gup-pack-has_pinned-in-mmf_has_pinned-checkpatch-fixes.patch
mm-memcg-optimize-user-context-object-stock-access-checkpatch-fixes.patch
mm-memcg-slab-create-a-new-set-of-kmalloc-cg-n-caches-v5-fix.patch
mm-improve-mprotectrw-efficiency-on-pages-referenced-once-fix.patch
binfmt-remove-in-tree-usage-of-map_executable-fix.patch
mm-mmap-introduce-unlock_range-for-code-cleanup-fix.patch
mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch
mm-memory_hotplug-disable-memmap_on_memory-when-hugetlb_free_vmemmap-enabled-fix.patch
nommu-remove-__gfp_highmem-in-vmalloc-vzalloc-checkpatch-fixes.patch
mm-madvise-introduce-madv_populate_readwrite-to-prefault-page-tables-checkpatch-fixes.patch
kernelh-split-out-panic-and-oops-helpers-fix.patch
module-add-printk-formats-to-add-module-build-id-to-stacktraces-fix.patch
kernel-forkc-export-kernel_thread-to-modules.patch


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: + mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch added to -mm tree
  2021-05-14 22:09 + mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch added to -mm tree akpm
@ 2021-05-17  5:57 ` Aneesh Kumar K.V
  2021-05-17 22:41 ` Stephen Rothwell
  1 sibling, 0 replies; 3+ messages in thread
From: Aneesh Kumar K.V @ 2021-05-17  5:57 UTC (permalink / raw)
  To: akpm, christophe.leroy, joel, kaleshsingh, mm-commits, mpe,
	naresh.kamboju, npiggin, sfr

On 5/15/21 3:39 AM, akpm@linux-foundation.org wrote:
> The patch titled
>       Subject: mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix
> has been added to the -mm tree.  Its filename is
>       mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch
> 
> This patch should soon appear at
>      https://ozlabs.org/~akpm/mmots/broken-out/mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch
> and later at
>      https://ozlabs.org/~akpm/mmotm/broken-out/mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch
> 
> Before you just go and hit "reply", please:
>     a) Consider who else should be cc'ed
>     b) Prefer to cc a suitable mailing list as well
>     c) Ideally: find the original patch on the mailing list and do a
>        reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
> 
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix
> 
> fix build
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Joel Fernandes <joel@joelfernandes.org>
> Cc: Kalesh Singh <kaleshsingh@google.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>   mm/mremap.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/mm/mremap.c~mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix
> +++ a/mm/mremap.c
> @@ -216,7 +216,7 @@ static inline void flush_pte_tlb_pwc_ran
>   					   unsigned long start,
>   					   unsigned long end)
>   {
> -	return flush_tlb_range(vma, start, end);
> +	flush_tlb_range(vma, start, end);
>   }
>   #endif
>   
> _


Thanks for catching this. This is required because on some 
architectures, flush_tlb_range have non void returns. For example on 
parisc we have

int __flush_tlb_range(unsigned long sid,
	unsigned long start, unsigned long end);

#define flush_tlb_range(vma, start, end) \
	__flush_tlb_range((vma)->vm_mm->context, start, end)



-aneesh

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: + mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch added to -mm tree
  2021-05-14 22:09 + mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch added to -mm tree akpm
  2021-05-17  5:57 ` Aneesh Kumar K.V
@ 2021-05-17 22:41 ` Stephen Rothwell
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2021-05-17 22:41 UTC (permalink / raw)
  To: akpm
  Cc: aneesh.kumar, christophe.leroy, joel, kaleshsingh, mm-commits,
	mpe, naresh.kamboju, npiggin, sfr

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Hi Andrew,

On Fri, 14 May 2021 15:09:59 -0700 akpm@linux-foundation.org wrote:
>
> The patch titled
>      Subject: mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix
> has been added to the -mm tree.  Its filename is
>      mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch

Added to linux-next today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-17 22:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 22:09 + mm-mremap-use-range-flush-that-does-tlb-and-page-walk-cache-flush-fix.patch added to -mm tree akpm
2021-05-17  5:57 ` Aneesh Kumar K.V
2021-05-17 22:41 ` Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).