mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + checkpatch-add-missing-bindings-license-check.patch added to mm-nonmm-unstable branch
@ 2023-03-21 21:29 Andrew Morton
  2023-03-21 21:40 ` Rob Herring
  2023-03-29  9:21 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 6+ messages in thread
From: Andrew Morton @ 2023-03-21 21:29 UTC (permalink / raw)
  To: mm-commits, robh, lukas.bulwahn, krzysztof.kozlowski, joe,
	dwaipayanray1, apw, ddrokosov, akpm


The patch titled
     Subject: checkpatch: add missing bindings license check
has been added to the -mm mm-nonmm-unstable branch.  Its filename is
     checkpatch-add-missing-bindings-license-check.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/checkpatch-add-missing-bindings-license-check.patch

This patch will later appear in the mm-nonmm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Subject: checkpatch: add missing bindings license check
Date: Mon, 20 Mar 2023 23:33:50 +0300

All headers from 'include/dt-bindings/' must be verified by checkpatch
together with Documentation bindings, because all of them are part of the
whole DT bindings system.

The requirement is dual licensed and matching pattern:
    /GPL-2\.0(?:-only|-or-later|\+)? (?:OR|or) BSD-2-Clause/

The issue was found during patch review:
https://lore.kernel.org/all/20230313201259.19998-4-ddrokosov@sberdevices.ru/

Link: https://lkml.kernel.org/r/20230320203350.13696-1-ddrokosov@sberdevices.ru
Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Acked-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 scripts/checkpatch.pl |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--- a/scripts/checkpatch.pl~checkpatch-add-missing-bindings-license-check
+++ a/scripts/checkpatch.pl
@@ -3735,8 +3735,9 @@ sub process {
 						WARN("SPDX_LICENSE_TAG",
 						     "'$spdx_license' is not supported in LICENSES/...\n" . $herecurr);
 					}
-					if ($realfile =~ m@^Documentation/devicetree/bindings/@ &&
-					    not $spdx_license =~ /GPL-2\.0.*BSD-2-Clause/) {
+					if (($realfile =~ m@^Documentation/devicetree/bindings/@ ||
+					     $realfile =~ m@^include/dt-bindings/@) &&
+					    $spdx_license !~ /GPL-2\.0(?:-only|-or-later|\+)? (?:OR|or) BSD-2-Clause/) {
 						my $msg_level = \&WARN;
 						$msg_level = \&CHK if ($file);
 						if (&{$msg_level}("SPDX_LICENSE_TAG",
_

Patches currently in -mm which might be from ddrokosov@sberdevices.ru are

checkpatch-add-missing-bindings-license-check.patch


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: + checkpatch-add-missing-bindings-license-check.patch added to mm-nonmm-unstable branch
  2023-03-21 21:29 + checkpatch-add-missing-bindings-license-check.patch added to mm-nonmm-unstable branch Andrew Morton
@ 2023-03-21 21:40 ` Rob Herring
  2023-03-21 21:44   ` Andrew Morton
  2023-03-29  9:21 ` Krzysztof Kozlowski
  1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2023-03-21 21:40 UTC (permalink / raw)
  To: Andrew Morton
  Cc: mm-commits, lukas.bulwahn, krzysztof.kozlowski, joe,
	dwaipayanray1, apw, ddrokosov

On Tue, Mar 21, 2023 at 4:29 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
>
> The patch titled
>      Subject: checkpatch: add missing bindings license check
> has been added to the -mm mm-nonmm-unstable branch.  Its filename is
>      checkpatch-add-missing-bindings-license-check.patch
>
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/checkpatch-add-missing-bindings-license-check.patch
>
> This patch will later appear in the mm-nonmm-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
>
> ------------------------------------------------------
> From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> Subject: checkpatch: add missing bindings license check
> Date: Mon, 20 Mar 2023 23:33:50 +0300
>
> All headers from 'include/dt-bindings/' must be verified by checkpatch
> together with Documentation bindings, because all of them are part of the
> whole DT bindings system.
>
> The requirement is dual licensed and matching pattern:
>     /GPL-2\.0(?:-only|-or-later|\+)? (?:OR|or) BSD-2-Clause/
>
> The issue was found during patch review:
> https://lore.kernel.org/all/20230313201259.19998-4-ddrokosov@sberdevices.ru/
>
> Link: https://lkml.kernel.org/r/20230320203350.13696-1-ddrokosov@sberdevices.ru

Not a correct link.

> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> Acked-by: Joe Perches <joe@perches.com>
> Cc: Andy Whitcroft <apw@canonical.com>
> Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>  scripts/checkpatch.pl |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- a/scripts/checkpatch.pl~checkpatch-add-missing-bindings-license-check
> +++ a/scripts/checkpatch.pl
> @@ -3735,8 +3735,9 @@ sub process {
>                                                 WARN("SPDX_LICENSE_TAG",
>                                                      "'$spdx_license' is not supported in LICENSES/...\n" . $herecurr);
>                                         }
> -                                       if ($realfile =~ m@^Documentation/devicetree/bindings/@ &&
> -                                           not $spdx_license =~ /GPL-2\.0.*BSD-2-Clause/) {
> +                                       if (($realfile =~ m@^Documentation/devicetree/bindings/@ ||
> +                                            $realfile =~ m@^include/dt-bindings/@) &&
> +                                           $spdx_license !~ /GPL-2\.0(?:-only|-or-later|\+)? (?:OR|or) BSD-2-Clause/) {
>                                                 my $msg_level = \&WARN;
>                                                 $msg_level = \&CHK if ($file);
>                                                 if (&{$msg_level}("SPDX_LICENSE_TAG",
> _
>
> Patches currently in -mm which might be from ddrokosov@sberdevices.ru are
>
> checkpatch-add-missing-bindings-license-check.patch
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: + checkpatch-add-missing-bindings-license-check.patch added to mm-nonmm-unstable branch
  2023-03-21 21:40 ` Rob Herring
@ 2023-03-21 21:44   ` Andrew Morton
  2023-03-21 21:48     ` Rob Herring
  0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2023-03-21 21:44 UTC (permalink / raw)
  To: Rob Herring
  Cc: mm-commits, lukas.bulwahn, krzysztof.kozlowski, joe,
	dwaipayanray1, apw, ddrokosov

On Tue, 21 Mar 2023 16:40:29 -0500 Rob Herring <robh@kernel.org> wrote:

> > Link: https://lkml.kernel.org/r/20230320203350.13696-1-ddrokosov@sberdevices.ru
> 
> Not a correct link.

Not a helpful comment.

What's wrong with it?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: + checkpatch-add-missing-bindings-license-check.patch added to mm-nonmm-unstable branch
  2023-03-21 21:44   ` Andrew Morton
@ 2023-03-21 21:48     ` Rob Herring
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-03-21 21:48 UTC (permalink / raw)
  To: Andrew Morton
  Cc: mm-commits, lukas.bulwahn, krzysztof.kozlowski, joe,
	dwaipayanray1, apw, ddrokosov

On Tue, Mar 21, 2023 at 4:44 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Tue, 21 Mar 2023 16:40:29 -0500 Rob Herring <robh@kernel.org> wrote:
>
> > > Link: https://lkml.kernel.org/r/20230320203350.13696-1-ddrokosov@sberdevices.ru
> >
> > Not a correct link.
>
> Not a helpful comment.
>
> What's wrong with it?

NM, it seems to be Gmail doing something weird. It sends me to:

https://lore.kernel.org/all/20230320203350.13696-1-ddrokosov@sberdevices.ruSigned-off-by/T/#u

In any case, this patch is wrong. I'll comment on it directly.

Rob

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: + checkpatch-add-missing-bindings-license-check.patch added to mm-nonmm-unstable branch
  2023-03-21 21:29 + checkpatch-add-missing-bindings-license-check.patch added to mm-nonmm-unstable branch Andrew Morton
  2023-03-21 21:40 ` Rob Herring
@ 2023-03-29  9:21 ` Krzysztof Kozlowski
  2023-03-29  9:56   ` Dmitry Rokosov
  1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-29  9:21 UTC (permalink / raw)
  To: Andrew Morton, mm-commits, robh, lukas.bulwahn, joe,
	dwaipayanray1, apw, ddrokosov

On 21/03/2023 22:29, Andrew Morton wrote:
> The patch titled
>      Subject: checkpatch: add missing bindings license check
> has been added to the -mm mm-nonmm-unstable branch.  Its filename is
>      checkpatch-add-missing-bindings-license-check.patch
> 
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/checkpatch-add-missing-bindings-license-check.patch
> 
> This patch will later appear in the mm-nonmm-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
> 
> ------------------------------------------------------
> From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> Subject: checkpatch: add missing bindings license check
> Date: Mon, 20 Mar 2023 23:33:50 +0300
> 
> All headers from 'include/dt-bindings/' must be verified by checkpatch
> together with Documentation bindings, because all of them are part of the
> whole DT bindings system.
> 
> The requirement is dual licensed and matching pattern:
>     /GPL-2\.0(?:-only|-or-later|\+)? (?:OR|or) BSD-2-Clause/
> 
> The issue was found during patch review:
> https://lore.kernel.org/all/20230313201259.19998-4-ddrokosov@sberdevices.ru/
> 
> Link: https://lkml.kernel.org/r/20230320203350.13696-1-ddrokosov@sberdevices.ru
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> Acked-by: Joe Perches <joe@perches.com>
> Cc: Andy Whitcroft <apw@canonical.com>
> Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Hi Andrew,

Can you drop this patch? Rob raised few concerns and it should be reworked.

Rob's arguments/comments:
https://lore.kernel.org/all/20230321215337.GA1656483-robh@kernel.org/
https://lore.kernel.org/all/CAL_Jsq+-YJsBO+LuPJ=ZQ=eb-monrwzuCppvReH+af7hYZzNaQ@mail.gmail.com/
https://lore.kernel.org/all/CAL_JsqJa-McFEorLr6ZWNqaEtjG8Oi2rNJ3hGwb2Xk3jvqMZgQ@mail.gmail.com/

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: + checkpatch-add-missing-bindings-license-check.patch added to mm-nonmm-unstable branch
  2023-03-29  9:21 ` Krzysztof Kozlowski
@ 2023-03-29  9:56   ` Dmitry Rokosov
  0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Rokosov @ 2023-03-29  9:56 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Andrew Morton, mm-commits, robh, lukas.bulwahn, joe, dwaipayanray1, apw

On Wed, Mar 29, 2023 at 11:21:06AM +0200, Krzysztof Kozlowski wrote:
> On 21/03/2023 22:29, Andrew Morton wrote:
> > The patch titled
> >      Subject: checkpatch: add missing bindings license check
> > has been added to the -mm mm-nonmm-unstable branch.  Its filename is
> >      checkpatch-add-missing-bindings-license-check.patch
> > 
> > This patch will shortly appear at
> >      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/checkpatch-add-missing-bindings-license-check.patch
> > 
> > This patch will later appear in the mm-nonmm-unstable branch at
> >     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > 
> > Before you just go and hit "reply", please:
> >    a) Consider who else should be cc'ed
> >    b) Prefer to cc a suitable mailing list as well
> >    c) Ideally: find the original patch on the mailing list and do a
> >       reply-to-all to that, adding suitable additional cc's
> > 
> > *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> > 
> > The -mm tree is included into linux-next via the mm-everything
> > branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > and is updated there every 2-3 working days
> > 
> > ------------------------------------------------------
> > From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> > Subject: checkpatch: add missing bindings license check
> > Date: Mon, 20 Mar 2023 23:33:50 +0300
> > 
> > All headers from 'include/dt-bindings/' must be verified by checkpatch
> > together with Documentation bindings, because all of them are part of the
> > whole DT bindings system.
> > 
> > The requirement is dual licensed and matching pattern:
> >     /GPL-2\.0(?:-only|-or-later|\+)? (?:OR|or) BSD-2-Clause/
> > 
> > The issue was found during patch review:
> > https://lore.kernel.org/all/20230313201259.19998-4-ddrokosov@sberdevices.ru/
> > 
> > Link: https://lkml.kernel.org/r/20230320203350.13696-1-ddrokosov@sberdevices.ru
> > Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> > Acked-by: Joe Perches <joe@perches.com>
> > Cc: Andy Whitcroft <apw@canonical.com>
> > Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> 
> Hi Andrew,
> 
> Can you drop this patch? Rob raised few concerns and it should be reworked.
> 
> Rob's arguments/comments:
> https://lore.kernel.org/all/20230321215337.GA1656483-robh@kernel.org/
> https://lore.kernel.org/all/CAL_Jsq+-YJsBO+LuPJ=ZQ=eb-monrwzuCppvReH+af7hYZzNaQ@mail.gmail.com/
> https://lore.kernel.org/all/CAL_JsqJa-McFEorLr6ZWNqaEtjG8Oi2rNJ3hGwb2Xk3jvqMZgQ@mail.gmail.com/

Yes, Andrew, please drop this version. I'll send the next one today or
tomorrow.

-- 
Thank you,
Dmitry

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-03-29  9:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-21 21:29 + checkpatch-add-missing-bindings-license-check.patch added to mm-nonmm-unstable branch Andrew Morton
2023-03-21 21:40 ` Rob Herring
2023-03-21 21:44   ` Andrew Morton
2023-03-21 21:48     ` Rob Herring
2023-03-29  9:21 ` Krzysztof Kozlowski
2023-03-29  9:56   ` Dmitry Rokosov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).