[MPTCP] Re: [PATCH net] mptcp: fix ADD_ADDR HMAC in case port is specified

[MPTCP] Re: [PATCH net] mptcp: fix ADD_ADDR HMAC in case port is specified

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

Hi Davide, Geliang, Mat,

On 12/03/2021 22:32, Davide Caratti wrote:
> Currently, Linux computes the HMAC contained in ADD_ADDR sub-option using
> the Address Id and the IP Address, and hardcodes a destination port equal
> to zero. This is not ok for ADD_ADDR with port: ensure to account for the
> endpoint port when computing the HMAC, in compliance with RFC8684 §3.4.1.

Thank you for the patch and the reviews!

Now in our tree with Mat's RvB and Geliang's ACK:

- 442a009d990c: mptcp: fix ADD_ADDR HMAC in case port is specified
- Results: f1ac0c54f494..0f8f3b7b5e58

Tests + export have been queued!

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

[MPTCP] Re: [PATCH net] mptcp: fix ADD_ADDR HMAC in case port is specified

[Geliang Tang]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

Hi Davide, Mat,

Mat Martineau <mathew.j.martineau(a)linux.intel.com> 于2021年3月13日周六 上午8:35写道：
>
> On Fri, 12 Mar 2021, Davide Caratti wrote:
>
> > Currently, Linux computes the HMAC contained in ADD_ADDR sub-option using
> > the Address Id and the IP Address, and hardcodes a destination port equal
> > to zero. This is not ok for ADD_ADDR with port: ensure to account for the
> > endpoint port when computing the HMAC, in compliance with RFC8684 §3.4.1.
> >
> > Fixes: 22fb85ffaefb ("mptcp: add port support for ADD_ADDR suboption writing")
> > Signed-off-by: Davide Caratti <dcaratti(a)redhat.com>
> > ---
> > net/mptcp/options.c | 24 ++++++++++++++----------
> > 1 file changed, 14 insertions(+), 10 deletions(-)
> >
>
> Hi Davide -
>
> Thanks for catching this. Fix looks good to me.
>
> Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

Acked-by: Geliang Tang <geliangtang(a)gmail.com>

-Geliang

>
> --
> Mat Martineau
> Intel

[MPTCP] Re: [PATCH net] mptcp: fix ADD_ADDR HMAC in case port is specified

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

On Fri, 12 Mar 2021, Davide Caratti wrote:

> Currently, Linux computes the HMAC contained in ADD_ADDR sub-option using
> the Address Id and the IP Address, and hardcodes a destination port equal
> to zero. This is not ok for ADD_ADDR with port: ensure to account for the
> endpoint port when computing the HMAC, in compliance with RFC8684 §3.4.1.
>
> Fixes: 22fb85ffaefb ("mptcp: add port support for ADD_ADDR suboption writing")
> Signed-off-by: Davide Caratti <dcaratti(a)redhat.com>
> ---
> net/mptcp/options.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>

Hi Davide -

Thanks for catching this. Fix looks good to me.

Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

--
Mat Martineau
Intel