Re: [PATCH net-next 5/5] sunvnet: Use kmap_local_page() instead of kmap_atomic()

[Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>]

On 11/18/2022 12:45 PM, Fabio M. De Francesco wrote:
> On venerdì 18 novembre 2022 10:11:12 CET Fabio M. De Francesco wrote:
> 
> Now that we are at 5/5 again. I'd like to point again to what worries me:
> 
> "Converting the former to the latter is safe only if there isn't an implicit
> dependency on preemption and page-fault handling being disabled, ...".
> 
> If I was able to convey my thoughts this is what you should get from my long
> email:
> 
> "Converting the former to the latter is _always_ safe if there isn't an
> implicit dependency on preemption and page-fault handling being disabled and
> also when the above-mentioned implicit dependency is present, but in the
> latter case only if calling pagefault_disable() and/or preempt_disable() with
> kmap_local_page(). These disables are not required here because...".
> 
> As you demonstrated none of your nine patches need any explicit disable along
> with kmap_local_page().
> 
> Do my two emails make any sense to you?
> However, your patches are good. If you decide to make them perfect use those
> helpers we've been talking about.

Hi Fabio,

I'll be posting v2 next week. I've incorporated feedback from our 
discussion, and hopefully the things I've added make sense. If not, 
let's continue talking.

Ani