From: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
<netdev@vger.kernel.org>
Cc: Ira Weiny <ira.weiny@intel.com>,
Edward Cree <ecree.xilinx@gmail.com>,
Martin Habets <habetsm.xilinx@gmail.com>
Subject: Re: [PATCH net-next 2/5] sfc: Use kmap_local_page() instead of kmap_atomic()
Date: Fri, 18 Nov 2022 09:47:52 -0800 [thread overview]
Message-ID: <164778f1-f2a6-1e82-8924-a4d7ba073e23@intel.com> (raw)
In-Reply-To: <8192948.T7Z3S40VBb@suse>
On 11/18/2022 12:23 AM, Fabio M. De Francesco wrote:
> On giovedì 17 novembre 2022 23:25:54 CET Anirudh Venkataramanan wrote:
>> kmap_atomic() is being deprecated in favor of kmap_local_page().
>> Replace kmap_atomic() and kunmap_atomic() with kmap_local_page()
>> and kunmap_local() respectively.
>>
>> Note that kmap_atomic() disables preemption and page-fault processing, but
>> kmap_local_page() doesn't. Converting the former to the latter is safe only
>> if there isn't an implicit dependency on preemption and page-fault handling
>> being disabled, which does appear to be the case here.
>
> NIT: It is always possible to disable explicitly along with the conversion.
Fair enough. I suppose "convert" is broader than "replace". How about this:
"Replacing the former with the latter is safe only if there isn't an
implicit dependency on preemption and page-fault handling being
disabled, which does appear to be the case here."
Ani
next prev parent reply other threads:[~2022-11-18 17:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 22:25 [PATCH net-next 0/5] Remove uses of kmap_atomic() Anirudh Venkataramanan
2022-11-17 22:25 ` [PATCH net-next 1/5] ch_ktls: Use kmap_local_page() instead " Anirudh Venkataramanan
2022-11-18 8:14 ` Fabio M. De Francesco
2022-11-18 18:27 ` Anirudh Venkataramanan
2022-11-18 20:18 ` Fabio M. De Francesco
2022-11-18 20:38 ` Anirudh Venkataramanan
2022-11-19 1:22 ` Ira Weiny
2022-11-17 22:25 ` [PATCH net-next 2/5] sfc: " Anirudh Venkataramanan
2022-11-18 8:23 ` Fabio M. De Francesco
2022-11-18 17:47 ` Anirudh Venkataramanan [this message]
2022-11-18 19:26 ` Fabio M. De Francesco
2022-11-18 20:34 ` Anirudh Venkataramanan
2022-11-19 1:25 ` Ira Weiny
2022-11-17 22:25 ` [PATCH net-next 3/5] cassini: Remove unnecessary use " Anirudh Venkataramanan
2022-11-18 8:35 ` Fabio M. De Francesco
2022-11-18 17:55 ` Anirudh Venkataramanan
2022-11-18 20:30 ` Fabio M. De Francesco
2022-11-17 22:25 ` [PATCH net-next 4/5] cassini: Use kmap_local_page() instead " Anirudh Venkataramanan
2022-11-18 8:53 ` Fabio M. De Francesco
2022-11-17 22:25 ` [PATCH net-next 5/5] sunvnet: " Anirudh Venkataramanan
2022-11-18 9:11 ` Fabio M. De Francesco
2022-11-18 20:45 ` Fabio M. De Francesco
2022-11-19 0:47 ` Anirudh Venkataramanan
2022-11-22 11:29 ` [PATCH net-next 0/5] Remove uses " Leon Romanovsky
2022-11-22 18:50 ` Jakub Kicinski
2022-11-22 21:06 ` Anirudh Venkataramanan
2022-11-23 7:34 ` Leon Romanovsky
2022-11-23 18:38 ` Anirudh Venkataramanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164778f1-f2a6-1e82-8924-a4d7ba073e23@intel.com \
--to=anirudh.venkataramanan@intel.com \
--cc=ecree.xilinx@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=habetsm.xilinx@gmail.com \
--cc=ira.weiny@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).