netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
To: netdev@vger.kernel.org
Cc: Ira Weiny <ira.weiny@intel.com>,
	"Fabio M . De Francesco" <fmdefrancesco@gmail.com>,
	Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>,
	Ayush Sawal <ayush.sawal@chelsio.com>,
	Vinay Kumar Yadav <vinay.yadav@chelsio.com>,
	Rohit Maheshwari <rohitm@chelsio.com>
Subject: [PATCH net-next 1/5] ch_ktls: Use kmap_local_page() instead of kmap_atomic()
Date: Thu, 17 Nov 2022 14:25:53 -0800	[thread overview]
Message-ID: <20221117222557.2196195-2-anirudh.venkataramanan@intel.com> (raw)
In-Reply-To: <20221117222557.2196195-1-anirudh.venkataramanan@intel.com>

kmap_atomic() is being deprecated in favor of kmap_local_page().
Replace kmap_atomic() and kunmap_atomic() with kmap_local_page()
and kunmap_local() respectively.

Note that kmap_atomic() disables preemption and page-fault processing,
but kmap_local_page() doesn't. Converting the former to the latter is safe
only if there isn't an implicit dependency on preemption and page-fault
handling being disabled, which does appear to be the case here.

Also note that the page being mapped is not allocated by the driver,
and so the driver doesn't know if the page is in normal memory. This is the
reason kmap_local_page() is used as opposed to page_address().

I don't have hardware, so this change has only been compile tested.

Cc: Ayush Sawal <ayush.sawal@chelsio.com>
Cc: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
Cc: Rohit Maheshwari <rohitm@chelsio.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
---
 .../ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c b/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
index da9973b..d95f230 100644
--- a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
+++ b/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
@@ -1853,24 +1853,24 @@ static int chcr_short_record_handler(struct chcr_ktls_info *tx_info,
 				i++;
 			}
 			f = &record->frags[i];
-			vaddr = kmap_atomic(skb_frag_page(f));
+			vaddr = kmap_local_page(skb_frag_page(f));
 
 			data = vaddr + skb_frag_off(f)  + remaining;
 			frag_delta = skb_frag_size(f) - remaining;
 
 			if (frag_delta >= prior_data_len) {
 				memcpy(prior_data, data, prior_data_len);
-				kunmap_atomic(vaddr);
+				kunmap_local(vaddr);
 			} else {
 				memcpy(prior_data, data, frag_delta);
-				kunmap_atomic(vaddr);
+				kunmap_local(vaddr);
 				/* get the next page */
 				f = &record->frags[i + 1];
-				vaddr = kmap_atomic(skb_frag_page(f));
+				vaddr = kmap_local_page(skb_frag_page(f));
 				data = vaddr + skb_frag_off(f);
 				memcpy(prior_data + frag_delta,
 				       data, (prior_data_len - frag_delta));
-				kunmap_atomic(vaddr);
+				kunmap_local(vaddr);
 			}
 			/* reset tcp_seq as per the prior_data_required len */
 			tcp_seq -= prior_data_len;
-- 
2.37.2


  reply	other threads:[~2022-11-17 22:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 22:25 [PATCH net-next 0/5] Remove uses of kmap_atomic() Anirudh Venkataramanan
2022-11-17 22:25 ` Anirudh Venkataramanan [this message]
2022-11-18  8:14   ` [PATCH net-next 1/5] ch_ktls: Use kmap_local_page() instead " Fabio M. De Francesco
2022-11-18 18:27     ` Anirudh Venkataramanan
2022-11-18 20:18       ` Fabio M. De Francesco
2022-11-18 20:38         ` Anirudh Venkataramanan
2022-11-19  1:22   ` Ira Weiny
2022-11-17 22:25 ` [PATCH net-next 2/5] sfc: " Anirudh Venkataramanan
2022-11-18  8:23   ` Fabio M. De Francesco
2022-11-18 17:47     ` Anirudh Venkataramanan
2022-11-18 19:26       ` Fabio M. De Francesco
2022-11-18 20:34         ` Anirudh Venkataramanan
2022-11-19  1:25   ` Ira Weiny
2022-11-17 22:25 ` [PATCH net-next 3/5] cassini: Remove unnecessary use " Anirudh Venkataramanan
2022-11-18  8:35   ` Fabio M. De Francesco
2022-11-18 17:55     ` Anirudh Venkataramanan
2022-11-18 20:30       ` Fabio M. De Francesco
2022-11-17 22:25 ` [PATCH net-next 4/5] cassini: Use kmap_local_page() instead " Anirudh Venkataramanan
2022-11-18  8:53   ` Fabio M. De Francesco
2022-11-17 22:25 ` [PATCH net-next 5/5] sunvnet: " Anirudh Venkataramanan
2022-11-18  9:11   ` Fabio M. De Francesco
2022-11-18 20:45     ` Fabio M. De Francesco
2022-11-19  0:47       ` Anirudh Venkataramanan
2022-11-22 11:29 ` [PATCH net-next 0/5] Remove uses " Leon Romanovsky
2022-11-22 18:50   ` Jakub Kicinski
2022-11-22 21:06     ` Anirudh Venkataramanan
2022-11-23  7:34       ` Leon Romanovsky
2022-11-23 18:38         ` Anirudh Venkataramanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221117222557.2196195-2-anirudh.venkataramanan@intel.com \
    --to=anirudh.venkataramanan@intel.com \
    --cc=ayush.sawal@chelsio.com \
    --cc=fmdefrancesco@gmail.com \
    --cc=ira.weiny@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=rohitm@chelsio.com \
    --cc=vinay.yadav@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).