netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yunsheng Lin <linyunsheng@huawei.com>
To: "Li,Rongqing" <lirongqing@baidu.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"saeedm@mellanox.com" <saeedm@mellanox.com>
Subject: Re: 答复: 答复: 答复: 答复: [PATCH] page_pool: mark unbound node page as reusable pages
Date: Thu, 5 Dec 2019 11:03:31 +0800	[thread overview]
Message-ID: <0c5b19c3-b639-b990-73a1-a1300d417221@huawei.com> (raw)
In-Reply-To: <504bf0958f424a2c9add3a84543c45c6@baidu.com>

On 2019/12/5 10:47, Li,Rongqing wrote:
>>
>> [1] https://lore.kernel.org/patchwork/patch/1125789/
> 
> 
> What is status of this patch? I think you should fix your firmware or bios

Have not reached a conclusion yet.

> 
> Consider the below condition:
> 
> there is two numa node, and NIC sites on node 2, but NUMA_NO_NODE is used, recycle will fail due to page_to_nid(page) == numa_mem_id(), 
> and reallocated pages maybe always from node 1, then the recycle will never success.

For page pool:

1. if the pool->p.nid != NUMA_NO_NODE, the recycle is always decided by
checking page_to_nid(page) == pool->p.nid.

2. only when the pool->p.nid == NUMA_NO_NODE, the numa_mem_id() is checked
   to decide the recycle.

Yes, If pool->p.nid == NUMA_NO_NODE, and the cpu that is doing recycling
is changing each time, the recycle may never success, but it is not common,
and have its own performance penalty when changing the recycling cpu so
often.


> 
> -RongQing
> 
> 


  reply	other threads:[~2019-12-05  3:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 10:14 [PATCH] page_pool: mark unbound node page as reusable pages Li RongQing
2019-12-05  0:55 ` Yunsheng Lin
2019-12-05  1:08   ` 答复: " Li,Rongqing
2019-12-05  1:43     ` Yunsheng Lin
2019-12-05  1:55       ` 答复: " Li,Rongqing
2019-12-05  2:06         ` Yunsheng Lin
2019-12-05  2:17           ` 答复: " Li,Rongqing
2019-12-05  2:30             ` Yunsheng Lin
2019-12-05  2:47               ` 答复: " Li,Rongqing
2019-12-05  3:03                 ` Yunsheng Lin [this message]
2019-12-05  3:18                   ` 答复: " Li,Rongqing
2019-12-05  3:33                     ` Yunsheng Lin
2019-12-06  8:05                       ` 答复: " Li,Rongqing
2019-12-05  1:22   ` Li,Rongqing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c5b19c3-b639-b990-73a1-a1300d417221@huawei.com \
    --to=linyunsheng@huawei.com \
    --cc=lirongqing@baidu.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).