* Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add multicast-to-unicast support for multiple targets [not found] ` <20190214134452.GA1602@otheros> @ 2019-02-14 14:04 ` Sven Eckelmann 2019-02-15 17:20 ` Linus Lüssing 0 siblings, 1 reply; 2+ messages in thread From: Sven Eckelmann @ 2019-02-14 14:04 UTC (permalink / raw) To: Linus Lüssing; +Cc: b.a.t.m.a.n, David Bauer, Jiri Pirko, netdev [-- Attachment #1: Type: text/plain, Size: 1018 bytes --] On Thursday, 14 February 2019 14:44:52 CET Linus Lüssing wrote: [...] > > No new sysfs config files. > > Why? The bridge for instance does the same. https://patchwork.open-mesh.org/patch/16763/ - here the quote On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote: > I strongly believe it is a huge mistake to use sysfs for things like > this. This should be done via generic netlink api. We don't need to configuration interfaces - we only need the preferred one. If this is sysfs for you guys then we should not have started with generic netlink at all. And why wasn't this brought up now *after* the stuff was merged by David. It isn't the first time that I've stated clearly that there should be no new sysfs configuration files when we switch to genl. If it now preferred to have sysfs again for configuration then please discuss it with the netdev folks and find out how the new generic netlink interface can be removed again before the next release. Kind regards, Sven [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add multicast-to-unicast support for multiple targets 2019-02-14 14:04 ` [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add multicast-to-unicast support for multiple targets Sven Eckelmann @ 2019-02-15 17:20 ` Linus Lüssing 0 siblings, 0 replies; 2+ messages in thread From: Linus Lüssing @ 2019-02-15 17:20 UTC (permalink / raw) To: The list for a Better Approach To Mobile Ad-hoc Networking Cc: netdev, Jiri Pirko, David Bauer On Thu, Feb 14, 2019 at 03:04:54PM +0100, Sven Eckelmann wrote: > On Thursday, 14 February 2019 14:44:52 CET Linus Lüssing wrote: > [...] > > > No new sysfs config files. > > > > Why? The bridge for instance does the same. > > https://patchwork.open-mesh.org/patch/16763/ - here the quote > > On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote: > > I strongly believe it is a huge mistake to use sysfs for things like > > this. This should be done via generic netlink api. > > We don't need to configuration interfaces - we only need the preferred one. If > this is sysfs for you guys then we should not have started with generic > netlink at all. And why wasn't this brought up now *after* the stuff was > merged by David. It isn't the first time that I've stated clearly that there > should be no new sysfs configuration files when we switch to genl. > > If it now preferred to have sysfs again for configuration then please discuss > it with the netdev folks and find out how the new generic netlink interface > can be removed again before the next release. > > Kind regards, > Sven Sorry, then this is all my misunderstanding. I have no issue with removing the sysfs part from this patch (I liked sysfs for prototyping/testing/scripting, but as we have all configuration options available in batctl that works for me, too). Thanks for the clarifications. Regards, Linus ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-15 17:20 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20190214124301.6222-1-linus.luessing@c0d3.blue> [not found] ` <1687264.beubBEU3KB@bentobox> [not found] ` <20190214134452.GA1602@otheros> 2019-02-14 14:04 ` [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add multicast-to-unicast support for multiple targets Sven Eckelmann 2019-02-15 17:20 ` Linus Lüssing
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).