From: Huy Nguyen <huyn@mellanox.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
Saeed Mahameed <saeedm@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute
Date: Thu, 24 May 2018 09:11:43 -0500 [thread overview]
Message-ID: <130570f4-25ca-9214-79fa-88ef9b208e32@mellanox.com> (raw)
In-Reply-To: <20180523131944.3498fd10@cakuba>
On 5/23/2018 3:19 PM, Jakub Kicinski wrote:
> On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote:
>> diff --git a/include/uapi/linux/dcbnl.h b/include/uapi/linux/dcbnl.h
>> index 2c0c6453c3f4..1ddc0a44c172 100644
>> --- a/include/uapi/linux/dcbnl.h
>> +++ b/include/uapi/linux/dcbnl.h
>> @@ -163,6 +163,15 @@ struct ieee_pfc {
>> __u64 indications[IEEE_8021QAZ_MAX_TCS];
>> };
>>
>> +#define IEEE_8021Q_MAX_PRIORITIES 8
>> +#define DCBX_MAX_BUFFERS 8
>> +struct dcbnl_buffer {
>> + /* priority to buffer mapping */
>> + __u8 prio2buffer[IEEE_8021Q_MAX_PRIORITIES];
>> + /* buffer size in Bytes */
>> + __u32 buffer_size[DCBX_MAX_BUFFERS];
> Could you use IEEE_8021Q_MAX_PRIORITIES to size this array? The DCBX in
> the define name sort of implies this is coming from the standard which
> it isn't.
>
I agree with your standard comment. But since priority is mapped to
buffer, I think it is okay to reuse
#define. Let's not have a duplicate #define with the same meaning.
next prev parent reply other threads:[~2018-05-24 14:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 21:04 [pull request][net-next 0/6] Mellanox, mlx5e updates 2018-05-19 Saeed Mahameed
2018-05-21 21:04 ` [net-next 1/6] net/dcb: Add dcbnl buffer attribute Saeed Mahameed
2018-05-22 5:20 ` Jakub Kicinski
2018-05-22 15:36 ` Huy Nguyen
2018-05-22 18:32 ` Jakub Kicinski
2018-05-23 1:01 ` Huy Nguyen
2018-05-23 6:15 ` Or Gerlitz
2018-05-23 9:23 ` Jakub Kicinski
2018-05-23 9:33 ` Jiri Pirko
2018-05-23 15:08 ` Huy Nguyen
2018-05-23 15:27 ` Huy Nguyen
2018-05-24 17:13 ` Ido Schimmel
2018-05-23 9:43 ` Jiri Pirko
2018-05-23 13:52 ` John Fastabend
2018-05-23 15:37 ` Huy Nguyen
2018-05-23 16:03 ` John Fastabend
2018-05-23 20:28 ` Jakub Kicinski
2018-05-24 14:37 ` Huy Nguyen
2018-05-23 20:13 ` Jakub Kicinski
2018-05-23 20:19 ` Jakub Kicinski
2018-05-24 14:11 ` Huy Nguyen [this message]
2018-05-21 21:04 ` [net-next 2/6] net/mlx5: Add pbmc and pptb in the port_access_reg_cap_mask Saeed Mahameed
2018-05-22 10:19 ` Or Gerlitz
2018-05-22 10:21 ` Or Gerlitz
2018-05-22 16:01 ` Saeed Mahameed
2018-05-24 21:21 ` Or Gerlitz
2018-05-24 21:28 ` Saeed Mahameed
2018-05-21 21:04 ` [net-next 3/6] net/mlx5e: Move port speed code from en_ethtool.c to en/port.c Saeed Mahameed
2018-05-21 21:05 ` [net-next 4/6] net/mlx5e: PPTB and PBMC register firmware command support Saeed Mahameed
2018-05-21 21:05 ` [net-next 5/6] net/mlx5e: Receive buffer configuration Saeed Mahameed
2018-05-21 21:05 ` [net-next 6/6] net/mlx5e: Receive buffer support for DCBX Saeed Mahameed
2018-05-22 19:38 ` [pull request][net-next 0/6] Mellanox, mlx5e updates 2018-05-19 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=130570f4-25ca-9214-79fa-88ef9b208e32@mellanox.com \
--to=huyn@mellanox.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).