Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, Huy Nguyen <huyn@mellanox.com>
Subject: Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute
Date: Wed, 23 May 2018 13:19:44 -0700	[thread overview]
Message-ID: <20180523131944.3498fd10@cakuba> (raw)
In-Reply-To: <20180521210502.11082-2-saeedm@mellanox.com>

On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote:
> diff --git a/include/uapi/linux/dcbnl.h b/include/uapi/linux/dcbnl.h
> index 2c0c6453c3f4..1ddc0a44c172 100644
> --- a/include/uapi/linux/dcbnl.h
> +++ b/include/uapi/linux/dcbnl.h
> @@ -163,6 +163,15 @@ struct ieee_pfc {
>  	__u64	indications[IEEE_8021QAZ_MAX_TCS];
>  };
>  
> +#define IEEE_8021Q_MAX_PRIORITIES 8
> +#define DCBX_MAX_BUFFERS  8
> +struct dcbnl_buffer {
> +	/* priority to buffer mapping */
> +	__u8    prio2buffer[IEEE_8021Q_MAX_PRIORITIES];
> +	/* buffer size in Bytes */
> +	__u32   buffer_size[DCBX_MAX_BUFFERS];

Could you use IEEE_8021Q_MAX_PRIORITIES to size this array?  The DCBX in
the define name sort of implies this is coming from the standard which
it isn't.

> +};
> +
>  /* CEE DCBX std supported values */
>  #define CEE_DCBX_MAX_PGS	8
>  #define CEE_DCBX_MAX_PRIO	8