From: Huy Nguyen <huyn@mellanox.com>
To: John Fastabend <john.fastabend@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Or Gerlitz <gerlitz.or@gmail.com>
Subject: Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute
Date: Thu, 24 May 2018 09:37:39 -0500 [thread overview]
Message-ID: <79cf2934-1671-8216-5f6a-2611168846a4@mellanox.com> (raw)
In-Reply-To: <653806e9-8416-d1e9-8666-abeea8eb7f15@gmail.com>
On 5/23/2018 11:03 AM, John Fastabend wrote:
> On 05/23/2018 08:37 AM, Huy Nguyen wrote:
>>
>> On 5/23/2018 8:52 AM, John Fastabend wrote:
>>> It would be nice though if the API gave us some hint on max/min/stride
>>> of allowed values. Could the get API return these along with current
>>> value? Presumably the allowed max size could change with devlink buffer
>>> changes in how the global buffer is divided up as well.
>> Acked. I will add Max. Let's skip min/stride since it is too hardware specific.
> At minimum then we need to document for driver writers what to do
> with a value that falls between strides. Round-up or round-down.
>
> .John
V2 still under internal review. But here are the changes in patch #1 and
patch #6.
patch #1
Changes in V2:
Add total_size in dcbnl_buffer to report the total available buffer
size of the netdev.
Code changes are in patch #1 and #6.
patch #6 commit message
Changes in V2:
Report total available buffer size of the netdev.
Comment on buffer stride:
Mellanox HCA buffer stride is 128 Bytes. If the
buffer size is not multiple of 128, the buffer size will be rounded
down
to the nearest multiple of 128.
next prev parent reply other threads:[~2018-05-24 14:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 21:04 [pull request][net-next 0/6] Mellanox, mlx5e updates 2018-05-19 Saeed Mahameed
2018-05-21 21:04 ` [net-next 1/6] net/dcb: Add dcbnl buffer attribute Saeed Mahameed
2018-05-22 5:20 ` Jakub Kicinski
2018-05-22 15:36 ` Huy Nguyen
2018-05-22 18:32 ` Jakub Kicinski
2018-05-23 1:01 ` Huy Nguyen
2018-05-23 6:15 ` Or Gerlitz
2018-05-23 9:23 ` Jakub Kicinski
2018-05-23 9:33 ` Jiri Pirko
2018-05-23 15:08 ` Huy Nguyen
2018-05-23 15:27 ` Huy Nguyen
2018-05-24 17:13 ` Ido Schimmel
2018-05-23 9:43 ` Jiri Pirko
2018-05-23 13:52 ` John Fastabend
2018-05-23 15:37 ` Huy Nguyen
2018-05-23 16:03 ` John Fastabend
2018-05-23 20:28 ` Jakub Kicinski
2018-05-24 14:37 ` Huy Nguyen [this message]
2018-05-23 20:13 ` Jakub Kicinski
2018-05-23 20:19 ` Jakub Kicinski
2018-05-24 14:11 ` Huy Nguyen
2018-05-21 21:04 ` [net-next 2/6] net/mlx5: Add pbmc and pptb in the port_access_reg_cap_mask Saeed Mahameed
2018-05-22 10:19 ` Or Gerlitz
2018-05-22 10:21 ` Or Gerlitz
2018-05-22 16:01 ` Saeed Mahameed
2018-05-24 21:21 ` Or Gerlitz
2018-05-24 21:28 ` Saeed Mahameed
2018-05-21 21:04 ` [net-next 3/6] net/mlx5e: Move port speed code from en_ethtool.c to en/port.c Saeed Mahameed
2018-05-21 21:05 ` [net-next 4/6] net/mlx5e: PPTB and PBMC register firmware command support Saeed Mahameed
2018-05-21 21:05 ` [net-next 5/6] net/mlx5e: Receive buffer configuration Saeed Mahameed
2018-05-21 21:05 ` [net-next 6/6] net/mlx5e: Receive buffer support for DCBX Saeed Mahameed
2018-05-22 19:38 ` [pull request][net-next 0/6] Mellanox, mlx5e updates 2018-05-19 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79cf2934-1671-8216-5f6a-2611168846a4@mellanox.com \
--to=huyn@mellanox.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).