From: Ben Hutchings <bhutchings@solarflare.com>
To: Peter Wu <lekensteyn@gmail.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/2] realtek: convert to per-chip mask
Date: Tue, 23 Jul 2013 18:56:52 +0100 [thread overview]
Message-ID: <1374602212.2072.1.camel@bwh-desktop.uk.level5networks.com> (raw)
In-Reply-To: <6657153.nK7z8HGonh@al>
On Tue, 2013-07-23 at 10:51 +0200, Peter Wu wrote:
> The previous HW_REVID macro did not make identifiers more readable
> (compared to hex values like 0x12345678) and only allowed for one static
> mask. To make it easier to update the chips list, let's use similar
> structures as r8169 and remove HW_REVID.
>
> Names are removed and separated from the table and separated because the
> mac_version does not have to be unique.
>
> There are no functional changes for the output, except that the output
> now mentions "TxConfig" instead of "mask" when a chip is not found.
> Since the mask can be anything, the word is not masked either.
>
> Signed-off-by: Peter Wu <lekensteyn@gmail.com>
> ---
> realtek.c | 106
> ++++++++++++++++++++++++++++++++++++--------------------------
> 1 file changed, 62 insertions(+), 44 deletions(-)
[...]
This patch has been corrupted by your mailer (specifically, it has been
word-wrapped). See Documentation/email-clients.txt in the Linux source
tree.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-07-23 17:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 8:51 [ethtool] Add new Realtek devices Peter Wu
2013-07-23 8:51 ` [PATCH 1/2] realtek: convert to per-chip mask Peter Wu
2013-07-23 17:56 ` Ben Hutchings [this message]
2013-07-23 8:51 ` [PATCH 2/2] realtek: update devices to 3.11 Peter Wu
2013-07-23 18:04 ` [PATCH v2 " Peter Wu
2013-07-23 18:05 ` [PATCH v2 1/2] realtek: convert to per-chip mask Peter Wu
2013-07-23 20:24 ` Francois Romieu
2013-07-23 21:03 ` Peter Wu
2013-07-23 20:25 ` [ethtool] Add new Realtek devices Francois Romieu
2013-07-23 21:08 ` Peter Wu
2013-08-13 21:25 [PATCH v4 ethtool 0/2] " Peter Wu
2013-08-13 21:25 ` [PATCH 1/2] realtek: convert to per-chip mask Peter Wu
2013-08-29 20:51 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374602212.2072.1.camel@bwh-desktop.uk.level5networks.com \
--to=bhutchings@solarflare.com \
--cc=lekensteyn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).