* [PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups
@ 2020-11-21 11:44 Kurt Kanzenbach
2020-11-21 11:44 ` [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes Kurt Kanzenbach
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Kurt Kanzenbach @ 2020-11-21 11:44 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean
Cc: David S. Miller, Jakub Kicinski, netdev, Kurt Kanzenbach
Hi,
fix two minor issues in the hellcreek driver.
Thanks,
Kurt
Kurt Kanzenbach (2):
net: dsa: tag_hellcreek: Cleanup includes
net: dsa: hellcreek: Don't print error message on defer
drivers/net/dsa/hirschmann/hellcreek.c | 2 +-
net/dsa/tag_hellcreek.c | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes
2020-11-21 11:44 [PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups Kurt Kanzenbach
@ 2020-11-21 11:44 ` Kurt Kanzenbach
2020-11-21 15:00 ` Florian Fainelli
2020-11-22 23:09 ` Vladimir Oltean
2020-11-21 11:44 ` [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer Kurt Kanzenbach
2020-11-24 1:00 ` [PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups patchwork-bot+netdevbpf
2 siblings, 2 replies; 8+ messages in thread
From: Kurt Kanzenbach @ 2020-11-21 11:44 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean
Cc: David S. Miller, Jakub Kicinski, netdev, Kurt Kanzenbach
Remove unused and add needed includes. No functional change.
Suggested-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
net/dsa/tag_hellcreek.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/dsa/tag_hellcreek.c b/net/dsa/tag_hellcreek.c
index 2061de06eafb..a09805c8e1ab 100644
--- a/net/dsa/tag_hellcreek.c
+++ b/net/dsa/tag_hellcreek.c
@@ -8,9 +8,7 @@
* Based on tag_ksz.c.
*/
-#include <linux/etherdevice.h>
-#include <linux/list.h>
-#include <linux/slab.h>
+#include <linux/skbuff.h>
#include <net/dsa.h>
#include "dsa_priv.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer
2020-11-21 11:44 [PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups Kurt Kanzenbach
2020-11-21 11:44 ` [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes Kurt Kanzenbach
@ 2020-11-21 11:44 ` Kurt Kanzenbach
2020-11-21 15:01 ` Florian Fainelli
2020-11-22 23:10 ` Vladimir Oltean
2020-11-24 1:00 ` [PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups patchwork-bot+netdevbpf
2 siblings, 2 replies; 8+ messages in thread
From: Kurt Kanzenbach @ 2020-11-21 11:44 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean
Cc: David S. Miller, Jakub Kicinski, netdev, Kurt Kanzenbach
When DSA is not loaded when the driver is probed an error message is
printed. But, that's not really an error, just a defer. Use dev_err_probe()
instead.
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
drivers/net/dsa/hirschmann/hellcreek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
index d42f40c76ba5..6420b76ea37c 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.c
+++ b/drivers/net/dsa/hirschmann/hellcreek.c
@@ -1266,7 +1266,7 @@ static int hellcreek_probe(struct platform_device *pdev)
ret = dsa_register_switch(hellcreek->ds);
if (ret) {
- dev_err(dev, "Unable to register switch\n");
+ dev_err_probe(dev, ret, "Unable to register switch\n");
return ret;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes
2020-11-21 11:44 ` [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes Kurt Kanzenbach
@ 2020-11-21 15:00 ` Florian Fainelli
2020-11-22 23:09 ` Vladimir Oltean
1 sibling, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2020-11-21 15:00 UTC (permalink / raw)
To: Kurt Kanzenbach, Andrew Lunn, Vivien Didelot, Vladimir Oltean
Cc: David S. Miller, Jakub Kicinski, netdev
On 11/21/2020 3:44 AM, Kurt Kanzenbach wrote:
> Remove unused and add needed includes. No functional change.
>
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer
2020-11-21 11:44 ` [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer Kurt Kanzenbach
@ 2020-11-21 15:01 ` Florian Fainelli
2020-11-22 23:10 ` Vladimir Oltean
1 sibling, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2020-11-21 15:01 UTC (permalink / raw)
To: Kurt Kanzenbach, Andrew Lunn, Vivien Didelot, Vladimir Oltean
Cc: David S. Miller, Jakub Kicinski, netdev
On 11/21/2020 3:44 AM, Kurt Kanzenbach wrote:
> When DSA is not loaded when the driver is probed an error message is
> printed. But, that's not really an error, just a defer. Use dev_err_probe()
> instead.
>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes
2020-11-21 11:44 ` [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes Kurt Kanzenbach
2020-11-21 15:00 ` Florian Fainelli
@ 2020-11-22 23:09 ` Vladimir Oltean
1 sibling, 0 replies; 8+ messages in thread
From: Vladimir Oltean @ 2020-11-22 23:09 UTC (permalink / raw)
To: Kurt Kanzenbach
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, David S. Miller,
Jakub Kicinski, netdev
On Sat, Nov 21, 2020 at 12:44:54PM +0100, Kurt Kanzenbach wrote:
> Remove unused and add needed includes. No functional change.
>
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer
2020-11-21 11:44 ` [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer Kurt Kanzenbach
2020-11-21 15:01 ` Florian Fainelli
@ 2020-11-22 23:10 ` Vladimir Oltean
1 sibling, 0 replies; 8+ messages in thread
From: Vladimir Oltean @ 2020-11-22 23:10 UTC (permalink / raw)
To: Kurt Kanzenbach
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, David S. Miller,
Jakub Kicinski, netdev
On Sat, Nov 21, 2020 at 12:44:55PM +0100, Kurt Kanzenbach wrote:
> When DSA is not loaded when the driver is probed an error message is
> printed. But, that's not really an error, just a defer. Use dev_err_probe()
> instead.
>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups
2020-11-21 11:44 [PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups Kurt Kanzenbach
2020-11-21 11:44 ` [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes Kurt Kanzenbach
2020-11-21 11:44 ` [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer Kurt Kanzenbach
@ 2020-11-24 1:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-11-24 1:00 UTC (permalink / raw)
To: Kurt Kanzenbach
Cc: andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba, netdev
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Sat, 21 Nov 2020 12:44:53 +0100 you wrote:
> Hi,
>
> fix two minor issues in the hellcreek driver.
>
> Thanks,
> Kurt
>
> [...]
Here is the summary with links:
- [net-next,1/2] net: dsa: tag_hellcreek: Cleanup includes
https://git.kernel.org/netdev/net-next/c/8551fad63cd3
- [net-next,2/2] net: dsa: hellcreek: Don't print error message on defer
https://git.kernel.org/netdev/net-next/c/ed5ef9fb2023
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-11-24 1:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-21 11:44 [PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups Kurt Kanzenbach
2020-11-21 11:44 ` [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes Kurt Kanzenbach
2020-11-21 15:00 ` Florian Fainelli
2020-11-22 23:09 ` Vladimir Oltean
2020-11-21 11:44 ` [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer Kurt Kanzenbach
2020-11-21 15:01 ` Florian Fainelli
2020-11-22 23:10 ` Vladimir Oltean
2020-11-24 1:00 ` [PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).