[PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups

[PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups

[Kurt Kanzenbach]

Hi,

fix two minor issues in the hellcreek driver.

Thanks,
Kurt

Kurt Kanzenbach (2):
  net: dsa: tag_hellcreek: Cleanup includes
  net: dsa: hellcreek: Don't print error message on defer

 drivers/net/dsa/hirschmann/hellcreek.c | 2 +-
 net/dsa/tag_hellcreek.c                | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

-- 
2.20.1

[PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes

[Kurt Kanzenbach]

Remove unused and add needed includes. No functional change.

Suggested-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
 net/dsa/tag_hellcreek.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/dsa/tag_hellcreek.c b/net/dsa/tag_hellcreek.c
index 2061de06eafb..a09805c8e1ab 100644
--- a/net/dsa/tag_hellcreek.c
+++ b/net/dsa/tag_hellcreek.c
@@ -8,9 +8,7 @@
  * Based on tag_ksz.c.
  */
 
-#include <linux/etherdevice.h>
-#include <linux/list.h>
-#include <linux/slab.h>
+#include <linux/skbuff.h>
 #include <net/dsa.h>
 
 #include "dsa_priv.h"
-- 
2.20.1

Re: [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes

[Florian Fainelli]

On 11/21/2020 3:44 AM, Kurt Kanzenbach wrote:
> Remove unused and add needed includes. No functional change.
> 
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes

[Vladimir Oltean]

On Sat, Nov 21, 2020 at 12:44:54PM +0100, Kurt Kanzenbach wrote:
> Remove unused and add needed includes. No functional change.
> 
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

[PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer

[Kurt Kanzenbach]

When DSA is not loaded when the driver is probed an error message is
printed. But, that's not really an error, just a defer. Use dev_err_probe()
instead.

Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
 drivers/net/dsa/hirschmann/hellcreek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
index d42f40c76ba5..6420b76ea37c 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.c
+++ b/drivers/net/dsa/hirschmann/hellcreek.c
@@ -1266,7 +1266,7 @@ static int hellcreek_probe(struct platform_device *pdev)
 
 	ret = dsa_register_switch(hellcreek->ds);
 	if (ret) {
-		dev_err(dev, "Unable to register switch\n");
+		dev_err_probe(dev, ret, "Unable to register switch\n");
 		return ret;
 	}
 
-- 
2.20.1

Re: [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer

[Florian Fainelli]

On 11/21/2020 3:44 AM, Kurt Kanzenbach wrote:
> When DSA is not loaded when the driver is probed an error message is
> printed. But, that's not really an error, just a defer. Use dev_err_probe()
> instead.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer

[Vladimir Oltean]

On Sat, Nov 21, 2020 at 12:44:55PM +0100, Kurt Kanzenbach wrote:
> When DSA is not loaded when the driver is probed an error message is
> printed. But, that's not really an error, just a defer. Use dev_err_probe()
> instead.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

Re: [PATCH net-next 0/2] net: dsa: hellcreek: Minor cleanups

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Sat, 21 Nov 2020 12:44:53 +0100 you wrote:
> Hi,
> 
> fix two minor issues in the hellcreek driver.
> 
> Thanks,
> Kurt
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: dsa: tag_hellcreek: Cleanup includes
    https://git.kernel.org/netdev/net-next/c/8551fad63cd3
  - [net-next,2/2] net: dsa: hellcreek: Don't print error message on defer
    https://git.kernel.org/netdev/net-next/c/ed5ef9fb2023

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html