* [PATCH] nt: usb: USB_RTL8153_ECM should not default to y
@ 2021-01-13 14:43 Geert Uytterhoeven
2021-01-13 16:00 ` Greg KH
2021-01-14 19:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-01-13 14:43 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Hayes Wang, Marek Szyprowski
Cc: linux-usb, netdev, linux-kernel, Geert Uytterhoeven
In general, device drivers should not be enabled by default.
Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/net/usb/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 1e37190287808973..fbbe786436319013 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -631,7 +631,6 @@ config USB_NET_AQC111
config USB_RTL8153_ECM
tristate "RTL8153 ECM support"
depends on USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n)
- default y
help
This option supports ECM mode for RTL8153 ethernet adapter, when
CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nt: usb: USB_RTL8153_ECM should not default to y
2021-01-13 14:43 [PATCH] nt: usb: USB_RTL8153_ECM should not default to y Geert Uytterhoeven
@ 2021-01-13 16:00 ` Greg KH
2021-01-14 19:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-01-13 16:00 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: David S . Miller, Jakub Kicinski, Hayes Wang, Marek Szyprowski,
linux-usb, netdev, linux-kernel
On Wed, Jan 13, 2021 at 03:43:09PM +0100, Geert Uytterhoeven wrote:
> In general, device drivers should not be enabled by default.
>
> Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/net/usb/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 1e37190287808973..fbbe786436319013 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -631,7 +631,6 @@ config USB_NET_AQC111
> config USB_RTL8153_ECM
> tristate "RTL8153 ECM support"
> depends on USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n)
> - default y
> help
> This option supports ECM mode for RTL8153 ethernet adapter, when
> CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] nt: usb: USB_RTL8153_ECM should not default to y
2021-01-13 14:43 [PATCH] nt: usb: USB_RTL8153_ECM should not default to y Geert Uytterhoeven
2021-01-13 16:00 ` Greg KH
@ 2021-01-14 19:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-01-14 19:00 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: davem, kuba, hayeswang, m.szyprowski, linux-usb, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 13 Jan 2021 15:43:09 +0100 you wrote:
> In general, device drivers should not be enabled by default.
>
> Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/net/usb/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- nt: usb: USB_RTL8153_ECM should not default to y
https://git.kernel.org/netdev/net/c/7da17624e794
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-14 19:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 14:43 [PATCH] nt: usb: USB_RTL8153_ECM should not default to y Geert Uytterhoeven
2021-01-13 16:00 ` Greg KH
2021-01-14 19:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).