* [PATCH] b43:do not initialise statics to 0.
@ 2022-07-20 19:42 Xin Gao
2022-07-20 20:39 ` Larry Finger
2022-07-27 12:54 ` wifi: b43: do not initialise static variable " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Xin Gao @ 2022-07-20 19:42 UTC (permalink / raw)
To: kvalo, davem, edumazet, kuba, pabeni
Cc: linux-wireless, b43-dev, netdev, linux-kernel, Xin Gao
do not initialise statics to 0.
Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
drivers/net/wireless/broadcom/b43/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
index 17bcec5f3ff7..5e233d0e06c0 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -105,7 +105,7 @@ int b43_modparam_verbose = B43_VERBOSITY_DEFAULT;
module_param_named(verbose, b43_modparam_verbose, int, 0644);
MODULE_PARM_DESC(verbose, "Log message verbosity: 0=error, 1=warn, 2=info(default), 3=debug");
-static int b43_modparam_pio = 0;
+static int b43_modparam_pio;
module_param_named(pio, b43_modparam_pio, int, 0644);
MODULE_PARM_DESC(pio, "Use PIO accesses by default: 0=DMA, 1=PIO");
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] b43:do not initialise statics to 0.
2022-07-20 19:42 [PATCH] b43:do not initialise statics to 0 Xin Gao
@ 2022-07-20 20:39 ` Larry Finger
2022-07-27 12:54 ` wifi: b43: do not initialise static variable " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2022-07-20 20:39 UTC (permalink / raw)
To: Xin Gao, kvalo, davem, edumazet, kuba, pabeni
Cc: linux-wireless, b43-dev, netdev, linux-kernel
On 7/20/22 14:42, Xin Gao wrote:
> do not initialise statics to 0.
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> drivers/net/wireless/broadcom/b43/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
> index 17bcec5f3ff7..5e233d0e06c0 100644
> --- a/drivers/net/wireless/broadcom/b43/main.c
> +++ b/drivers/net/wireless/broadcom/b43/main.c
> @@ -105,7 +105,7 @@ int b43_modparam_verbose = B43_VERBOSITY_DEFAULT;
> module_param_named(verbose, b43_modparam_verbose, int, 0644);
> MODULE_PARM_DESC(verbose, "Log message verbosity: 0=error, 1=warn, 2=info(default), 3=debug");
>
> -static int b43_modparam_pio = 0;
> +static int b43_modparam_pio;
> module_param_named(pio, b43_modparam_pio, int, 0644);
> MODULE_PARM_DESC(pio, "Use PIO accesses by default: 0=DMA, 1=PIO");
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks.
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wifi: b43: do not initialise static variable to 0
2022-07-20 19:42 [PATCH] b43:do not initialise statics to 0 Xin Gao
2022-07-20 20:39 ` Larry Finger
@ 2022-07-27 12:54 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-07-27 12:54 UTC (permalink / raw)
To: Xin Gao
Cc: davem, edumazet, kuba, pabeni, linux-wireless, b43-dev, netdev,
linux-kernel, Xin Gao
Xin Gao <gaoxin@cdjrlc.com> wrote:
> No need to initialise static variables to zero.
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
> [kvalo@kernel.org: improve commit log]
Patch applied to wireless-next.git, thanks.
dbf8cd368a47 wifi: b43: do not initialise static variable to 0
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220720194245.8442-1-gaoxin@cdjrlc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-27 12:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 19:42 [PATCH] b43:do not initialise statics to 0 Xin Gao
2022-07-20 20:39 ` Larry Finger
2022-07-27 12:54 ` wifi: b43: do not initialise static variable " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).