[PATCH] b43:do not initialise statics to 0.

[PATCH] b43:do not initialise statics to 0.

[Xin Gao]

do not initialise statics to 0.

Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
 drivers/net/wireless/broadcom/b43/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
index 17bcec5f3ff7..5e233d0e06c0 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -105,7 +105,7 @@ int b43_modparam_verbose = B43_VERBOSITY_DEFAULT;
 module_param_named(verbose, b43_modparam_verbose, int, 0644);
 MODULE_PARM_DESC(verbose, "Log message verbosity: 0=error, 1=warn, 2=info(default), 3=debug");
 
-static int b43_modparam_pio = 0;
+static int b43_modparam_pio;
 module_param_named(pio, b43_modparam_pio, int, 0644);
 MODULE_PARM_DESC(pio, "Use PIO accesses by default: 0=DMA, 1=PIO");
 
-- 
2.30.2

Re: [PATCH] b43:do not initialise statics to 0.

[Larry Finger]

On 7/20/22 14:42, Xin Gao wrote:
> do not initialise statics to 0.
> 
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>   drivers/net/wireless/broadcom/b43/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
> index 17bcec5f3ff7..5e233d0e06c0 100644
> --- a/drivers/net/wireless/broadcom/b43/main.c
> +++ b/drivers/net/wireless/broadcom/b43/main.c
> @@ -105,7 +105,7 @@ int b43_modparam_verbose = B43_VERBOSITY_DEFAULT;
>   module_param_named(verbose, b43_modparam_verbose, int, 0644);
>   MODULE_PARM_DESC(verbose, "Log message verbosity: 0=error, 1=warn, 2=info(default), 3=debug");
>   
> -static int b43_modparam_pio = 0;
> +static int b43_modparam_pio;
>   module_param_named(pio, b43_modparam_pio, int, 0644);
>   MODULE_PARM_DESC(pio, "Use PIO accesses by default: 0=DMA, 1=PIO");

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks.

Larry

Re: wifi: b43: do not initialise static variable to 0

[Kalle Valo]

Xin Gao <gaoxin@cdjrlc.com> wrote:

> No need to initialise static variables to zero.
> 
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
> [kvalo@kernel.org: improve commit log]

Patch applied to wireless-next.git, thanks.

dbf8cd368a47 wifi: b43: do not initialise static variable to 0

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220720194245.8442-1-gaoxin@cdjrlc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches