* [PATCH 1/1]net:ethernet:fixed a coding style issue relating space.
@ 2012-05-18 21:45 Jeffrin Jose
2012-05-18 21:56 ` Stephen Hemminger
[not found] ` <1337421732.6524.YahooMailNeo@web192306.mail.sg3.yahoo.com>
0 siblings, 2 replies; 3+ messages in thread
From: Jeffrin Jose @ 2012-05-18 21:45 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, ahiliation
Fixed a coding style issue relating to space found
by checkpatch.pl tool in net/ethernet/eth.c
Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
---
net/ethernet/eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index 36e5880..c847aa6 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -178,7 +178,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
* seems to set IFF_PROMISC.
*/
- else if (1 /*dev->flags&IFF_PROMISC */ ) {
+ else if (1 /*dev->flags&IFF_PROMISC */) {
if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
dev->dev_addr)))
skb->pkt_type = PACKET_OTHERHOST;
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1]net:ethernet:fixed a coding style issue relating space.
2012-05-18 21:45 [PATCH 1/1]net:ethernet:fixed a coding style issue relating space Jeffrin Jose
@ 2012-05-18 21:56 ` Stephen Hemminger
[not found] ` <1337421732.6524.YahooMailNeo@web192306.mail.sg3.yahoo.com>
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2012-05-18 21:56 UTC (permalink / raw)
To: Jeffrin Jose; +Cc: davem, netdev, linux-kernel
On Sat, 19 May 2012 03:15:37 +0530
Jeffrin Jose <ahiliation@yahoo.co.in> wrote:
> Fixed a coding style issue relating to space found
> by checkpatch.pl tool in net/ethernet/eth.c
>
> Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
> ---
> net/ethernet/eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
> index 36e5880..c847aa6 100644
> --- a/net/ethernet/eth.c
> +++ b/net/ethernet/eth.c
> @@ -178,7 +178,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
> * seems to set IFF_PROMISC.
> */
>
> - else if (1 /*dev->flags&IFF_PROMISC */ ) {
> + else if (1 /*dev->flags&IFF_PROMISC */) {
> if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
> dev->dev_addr)))
> skb->pkt_type = PACKET_OTHERHOST;
Rather than put lips on a pig, why not remove the bogus if?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1]net:ethernet:fixed a coding style issue relating space.
[not found] ` <1337421732.6524.YahooMailNeo@web192306.mail.sg3.yahoo.com>
@ 2012-05-19 18:36 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-05-19 18:36 UTC (permalink / raw)
To: ahiliation; +Cc: netdev, linux-kernel
From: Jeffrin Jose <ahiliation@yahoo.co.in>
Date: Sat, 19 May 2012 18:02:12 +0800 (SGT)
>>> Rather than put lips on a pig, why not remove the bogus if?
> is there anything i should work on this patch or should i move on
He's telling you to remove the code rather then try to fix
it's coding style.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-19 18:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-18 21:45 [PATCH 1/1]net:ethernet:fixed a coding style issue relating space Jeffrin Jose
2012-05-18 21:56 ` Stephen Hemminger
[not found] ` <1337421732.6524.YahooMailNeo@web192306.mail.sg3.yahoo.com>
2012-05-19 18:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).