From: David Miller <davem@davemloft.net>
To: jim_baxter@mentor.com
Cc: Frank.Li@freescale.com, B38611@freescale.com,
fabio.estevam@freescale.com, l.stach@pengutronix.de,
shawn.guo@linaro.org, netdev@vger.kernel.org,
bhutchings@solarflare.com
Subject: Re: [PATCH net-next v2 1/1] net: fec: Add VLAN receive HW support.
Date: Mon, 01 Jul 2013 17:09:29 -0700 (PDT) [thread overview]
Message-ID: <20130701.170929.2145379004044730481.davem@davemloft.net> (raw)
In-Reply-To: <1372428503-13744-1-git-send-email-jim_baxter@mentor.com>
From: Jim Baxter <jim_baxter@mentor.com>
Date: Fri, 28 Jun 2013 15:08:23 +0100
> @@ -803,6 +807,9 @@ fec_enet_rx(struct net_device *ndev, int budget)
> ushort pkt_len;
> __u8 *data;
> int pkt_received = 0;
> + struct bufdesc_ex *ebdp = NULL;
> + bool vlan_packet_rcvd = false;
> + u16 vlan_tag;
>
> #ifdef CONFIG_M532x
> flush_cache_all();
> @@ -866,6 +873,24 @@ fec_enet_rx(struct net_device *ndev, int budget)
> if (id_entry->driver_data & FEC_QUIRK_SWAP_FRAME)
> swap_buffer(data, pkt_len);
>
> + /* Extract the enhanced buffer descriptor */
> + ebdp = NULL;
> + if (fep->bufdesc_ex)
> + ebdp = (struct bufdesc_ex *)bdp;
I would use a union here, so you'd have something like:
union {
struct bufdesc *bdp;
struct bufdesc_ex *bdp_ex;
} *p;
Alternatively, you can always use "struct bufdesc_ex *p", along with
the boolean saying if the extended descriptors are in use.
> + if ((ndev->features & NETIF_F_HW_VLAN_CTAG_RX) &&
> + ebdp && (ebdp->cbd_esc & BD_ENET_RX_VLAN)) {
This is not indented properly. The "ebp" on that second line must line
up exactly with the first column after the openning parenthesis on the
first line.
I see what you're trying to do, purely using TAB characters to indent
that second line. But you must take the care and time to use the
appropriate number of TAB and space characters to place things at the
proper column.
> + skb_copy_to_linear_data_offset(skb, (2 * ETH_ALEN),
> + data + payload_offset,
> + pkt_len - 4 - (2 * ETH_ALEN));
Again, line up the first non-space character on the second and third
lines of this function call so that they line up to the first column
after the openning parenthesis of the first line.
> + __vlan_hwaccel_put_tag(skb,
> + htons(ETH_P_8021Q), vlan_tag);
Likewise.
next prev parent reply other threads:[~2013-07-02 0:09 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Jim Baxter <jim_baxter@mentor.com>
2013-04-17 20:07 ` [PATCH net-next v3 1/1] net: fec: Enable imx6 enet checksum acceleration Jim Baxter
2013-04-17 21:37 ` Eric Dumazet
2013-04-18 12:49 ` Jim Baxter
2013-04-18 16:16 ` Ben Hutchings
2013-04-18 17:07 ` Ben Hutchings
2013-04-18 17:08 ` Jim Baxter
2013-04-18 17:12 ` Ben Hutchings
2013-04-18 17:21 ` Jim Baxter
2013-04-18 21:27 ` Jim Baxter
2013-04-18 22:03 ` Ben Hutchings
2013-04-17 22:45 ` Francois Romieu
2013-04-18 10:18 ` Jim Baxter
2013-04-18 11:31 ` Fabio Estevam
2013-04-18 21:54 ` Francois Romieu
2013-04-19 8:45 ` Jim Baxter
2013-04-19 15:10 ` [PATCH net-next v4 " Jim Baxter
2013-04-19 15:29 ` Eric Dumazet
2013-04-19 15:55 ` Jim Baxter
2013-04-19 15:56 ` Ben Hutchings
2013-04-19 15:59 ` Eric Dumazet
2013-04-19 15:34 ` Ben Hutchings
2013-04-19 16:16 ` Jim Baxter
2013-04-19 16:20 ` Ben Hutchings
2013-04-19 18:10 ` [PATCH net-next v5 " Jim Baxter
2013-04-19 18:50 ` Ben Hutchings
2013-04-25 7:59 ` David Miller
2013-06-25 23:55 ` [PATCH net-next v1 1/1] net: fec: Add VLAN receive HW support Jim Baxter
2013-06-26 2:22 ` Duan Fugang-B38611
2013-06-26 2:31 ` Duan Fugang-B38611
2013-06-26 2:56 ` Shawn Guo
2013-06-26 3:13 ` Duan Fugang-B38611
2013-06-26 5:49 ` David Miller
2013-06-26 10:09 ` Jim Baxter
2013-06-26 11:18 ` Duan Fugang-B38611
2013-06-26 11:45 ` Jim Baxter
2013-06-27 1:41 ` Duan Fugang-B38611
2013-06-27 9:35 ` Jim Baxter
2013-06-27 9:44 ` Lucas Stach
2013-06-27 14:03 ` Jim Baxter
2013-06-27 18:25 ` [PATCH net v1 1/1] net: fec: Fix Transmitted bytes counter Jim Baxter
2013-06-28 2:11 ` Duan Fugang-B38611
2013-07-01 20:40 ` David Miller
2013-07-02 8:32 ` Jim Baxter
2013-07-02 8:46 ` David Miller
2013-06-28 9:51 ` [PATCH net v2 " Jim Baxter
2013-06-28 10:10 ` Duan Fugang-B38611
2013-06-28 14:08 ` [PATCH net-next v2 1/1] net: fec: Add VLAN receive HW support Jim Baxter
2013-06-29 5:34 ` Duan Fugang-B38611
2013-07-02 0:09 ` David Miller [this message]
2013-07-02 9:39 ` Jim Baxter
2013-06-28 15:07 ` [PATCH RFC net-next v1 1/1] net: fec: Fix RMON registers on imx6 Jim Baxter
2013-06-29 5:58 ` Duan Fugang-B38611
[not found] ` <CAFXsbZpgAqvkEy+S83iJNMH9-N7h68MDRuvARE9pmT7HbcpAOQ@mail.gmail.com>
[not found] ` <CAFXsbZoBQ3ODUnFg-VumP+YAfCJ2-d=nL_=Gk2LKXm7PadHUuQ@mail.gmail.com>
2013-07-01 10:16 ` Jim Baxter
2013-07-01 10:31 ` [PATCH " Jim Baxter
[not found] ` <CAFXsbZoDWn4KgAVEpUtajo+PwfnrJoO0eTw9g6+MdQ8b666=EQ@mail.gmail.com>
2013-07-01 13:52 ` Jim Baxter
2013-07-02 19:41 ` David Miller
2013-07-01 13:57 ` [PATCH net-next v3 " Jim Baxter
2013-07-02 21:52 ` [PATCH net-next v3 1/1] net: fec: Add VLAN receive HW support Jim Baxter
2013-07-03 23:45 ` David Miller
2014-05-29 17:12 ` [PATCH v1 0/3] usb: gadget: NCM: Fixes and Multi-frame for TX Jim Baxter
2014-05-29 17:12 ` [PATCH v1 1/3] usb: gadget: NCM: RX function support multiple NDPs Jim Baxter
2014-05-29 18:55 ` Bjørn Mork
2014-05-30 11:45 ` Jim Baxter
2014-05-29 17:12 ` [PATCH v1 2/3] usb: gadget: NCM: Add transmit multi-frame Jim Baxter
2014-05-29 17:12 ` [PATCH v1 3/3] usb: gadget: NCM: Stop RX TCP Bursts getting dropped Jim Baxter
2014-05-29 19:04 ` Eric Dumazet
2014-05-30 11:25 ` Jim Baxter
2014-06-12 9:38 ` Jim Baxter
2014-06-12 9:42 ` David Laight
2014-07-07 17:33 ` [PATCH v2 0/3] usb: gadget: NCM: Fixes and Multi-frame for TX Jim Baxter
2014-07-07 17:33 ` [PATCH v2 1/3] usb: gadget: NCM: RX function support multiple NDPs Jim Baxter
2014-07-07 17:33 ` [PATCH v2 2/3] usb: gadget: NCM: Add transmit multi-frame Jim Baxter
2014-07-07 17:33 ` [PATCH v2 3/3] usb: gadget: NCM: Stop RX TCP Bursts getting dropped Jim Baxter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701.170929.2145379004044730481.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=B38611@freescale.com \
--cc=Frank.Li@freescale.com \
--cc=bhutchings@solarflare.com \
--cc=fabio.estevam@freescale.com \
--cc=jim_baxter@mentor.com \
--cc=l.stach@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).